New issue
Advanced search Search tips

Issue 840153 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: ----
Type: ----

Blocking:
issue 837088
issue 852556



Sign in to add a comment

Add caBLE extensions

Project Member Reported by kpaulhamus@chromium.org, May 6 2018

Issue description

Add extensions to get() and create() to enable cloud-assisted BLE (a pairingless BLE connection).
 
Blocking: 837088
Project Member

Comment 2 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a

commit c04ce6838b673646a77d4587e1e0a19eb0d7fe9a
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Mon May 14 20:14:10 2018

Implement the caBLE registration and authentication extensions.

This CL adds the extension at the Blink layer and in authenticator.mojom
and includes typeconverters and layout tests.

This will be used by cloud-assisted BLE, a protocol used by
the WebAuthN API to communicate with certain BLE devices without
explicit pairing.

Also, note that this extension is in early stages of standardization
and still being presented to the working group, so names and such will
likely change in future versions.

This is a low-risk feature - its functionality will be behind a flag,
and if a request is made with either the registration or authentication
extensions and the feature is disabled, then the request will proceed
normally as if the extension was not used at all.

Bug:  840153 
Change-Id: I554452d5702511f77f47666a2abf35bf5bd9d99e
Reviewed-on: https://chromium-review.googlesource.com/1046110
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558432}
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/content/browser/webauth/webauth_browsertest.cc
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/test-inputs.js
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/public/platform/modules/webauth/authenticator.mojom
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/credentialmanager/authentication_extensions_client_inputs.idl
[add] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/credentialmanager/cable_authentication_data.idl
[add] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/credentialmanager/cable_registration_data.idl
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/credentialmanager/credential_manager_type_converters.cc
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/credentialmanager/credential_manager_type_converters.h
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/credentialmanager/credentials_container.cc
[modify] https://crrev.com/c04ce6838b673646a77d4587e1e0a19eb0d7fe9a/third_party/blink/renderer/modules/modules_idl_files.gni

Status: Fixed (was: Started)

Comment 5 by nepper@chromium.org, Jun 13 2018

Blocking: 852556

Sign in to add a comment