Display zoom feature breaks Crostini |
||||
Issue descriptionThis is because chrome is now sending the client an inverse scale compared to before. Example: If you increased the resolution one step (85% zoom or 1350x900 size if zoom is disabled) then aura shell protocol sends the following scale to the client: Zoom feature disabled, current scale is 1.125. Zoom feature enabled, current scale is 0.85. Sommelier expects 1.125 today so this breaks Crostini when zoom is set to anything other than 1.0. We need to align this behavior. Either invert the scale when zoom feature is enabled or when disabled. If the go with the latter, then we need to bump the aura shell protocol version so sommelier has a way of knowing if values are inverted or not.
,
May 7 2018
There are too many scales to send the inverse for display zoom (Lot of them repeating decimals). It would be safer to send the inverse of ui-scales and bump the aura shell protocol version.
,
May 7 2018
OK. Inverse of ui-scales is probably better long term anyhow. Let's make sure the aura-shell protocol description is updated to make this clear at the same time as we bump the version. Can you create a chromium patch for this? I can take care of updating sommelier.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c569e5dfc3268efca4cadf70c38e160711f7b22 commit 8c569e5dfc3268efca4cadf70c38e160711f7b22 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue May 08 05:05:11 2018 Inverse the ui scales in wayland server before sending to clients This patch inverses the ui scales before sending them as output device scale factor. Bug: 840107 Change-Id: I19eb520818281161abd53230b8cabcd0d40e1ebd Component: wayland, scaling, aura shell Reviewed-on: https://chromium-review.googlesource.com/1049115 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556693} [modify] https://crrev.com/8c569e5dfc3268efca4cadf70c38e160711f7b22/components/exo/wayland/protocol/aura-shell.xml [modify] https://crrev.com/8c569e5dfc3268efca4cadf70c38e160711f7b22/components/exo/wayland/public/aura-shell-protocol.c [modify] https://crrev.com/8c569e5dfc3268efca4cadf70c38e160711f7b22/components/exo/wayland/server.cc
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9931746a2d467cad80490c44b2aeaa99ebc0f079 commit 9931746a2d467cad80490c44b2aeaa99ebc0f079 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue May 08 18:34:13 2018 Increase the aura shell version to 6 This patch increases the aura shel version to 6 that was missed in the previous change(I19eb520818281161abd53230b8cabcd0d40e1ebd). Bug: 840107 Change-Id: I749a72dcfbf74e805164ff3adfe210c5fc6b9155 Component: aura shell Reviewed-on: https://chromium-review.googlesource.com/1050514 Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#556891} [modify] https://crrev.com/9931746a2d467cad80490c44b2aeaa99ebc0f079/components/exo/wayland/server.cc
,
May 9 2018
,
May 10 2018
,
May 10 2018
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2db034f430b6f100dd93ef417f33db5121b4b6b8 commit 2db034f430b6f100dd93ef417f33db5121b4b6b8 Author: David Reveman <reveman@chromium.org> Date: Thu May 10 22:09:57 2018 vm_tools: update to version 6 of aura shell. This allows us to transition away from inverted scale values. If the host compositor support version 6, then we know that scales are not inverted. BUG= chromium:840107 TEST=xrandr output is showing a larger output display zoom is reduced Change-Id: I1b2783f625dadcc1ffad4d62516c16cacd70c0dd Reviewed-on: https://chromium-review.googlesource.com/1049950 Commit-Ready: David Reveman <reveman@chromium.org> Tested-by: David Reveman <reveman@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/2db034f430b6f100dd93ef417f33db5121b4b6b8/vm_tools/sommelier/sommelier.c [modify] https://crrev.com/2db034f430b6f100dd93ef417f33db5121b4b6b8/vm_tools/sommelier/protocol/aura-shell.xml
,
May 13 2018
,
Oct 8
Issue 839417 has been merged into this issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted