Issue metadata
Sign in to add a comment
|
Copy Screen Capture Notification Doesn't work after first time
Reported by
alvarogu...@gmail.com,
May 5 2018
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 10575.22.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.26 Safari/537.36 Platform: 10575.22.0 (Official Build) beta-channel lulu Steps to reproduce the problem: 1. Do a screenshot (partial or whole does not matter) 2. Click the copy to clipboard button on the notification you have just got because of the screenshot. 3. Do the steps 1 and 2 again. 4. Open a gdoc and paste the screenshot on a document to see what you got. What is the expected behavior? You should paste the second screenshot What went wrong? You just pasted the first screenshot, even after taking and copying a second one. Did this work before? Yes 66 Chrome version: 67.0.3396.26 Channel: beta OS Version: 10575.22.0 Flash Version: It should be great if someone develops a new key combo to let you automatically copy the recent screenshot. Without the need to click the notification button. 99% of the time i do a screenshot to copy it inmediatly in another place. Maybe Ctrl + Shift + Alt + Change_window
,
May 11 2018
estade@ please triage this bug
,
May 11 2018
thanks for the report. Not sure how many other kinds of notifications besides screenshots this would effect, but the fix is small so I'll request a merge to 67 after it lands.
,
May 11 2018
Great. Thanks I should create another ticket for the suggestion of having a key combo for screenshot and copying at the same time? Le ven. 11 mai 2018 à 18:24, est… via monorail < monorail+v2.3328755010@chromium.org> a écrit :
,
May 11 2018
> I should create another ticket for the suggestion of having a key combo for screenshot and copying at the same time? sure, although I have a feeling it will be hard to convince UX folks that's a common enough use pattern to warrant a shortcut.
,
May 13 2018
Same root cause as issue 840469 ?
,
May 14 2018
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/070b773c468f3aeed645334f53850175512e8b08 commit 070b773c468f3aeed645334f53850175512e8b08 Author: Evan Stade <estade@chromium.org> Date: Mon May 14 15:25:37 2018 Correctly update notification delegate for Chrome OS mojo notifications. When a notification was updated (same ID, new properties), the appearance --- title, image, etc. --- was updated, but the old delegate wasn't replaced with the new delegate. Fix that and add a test. Bug: 840105 Change-Id: I83fd7453f13c41adf96a417e3945a85933a9e1a3 Reviewed-on: https://chromium-review.googlesource.com/1056091 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#558315} [modify] https://crrev.com/070b773c468f3aeed645334f53850175512e8b08/chrome/browser/notifications/chrome_ash_message_center_client.cc [modify] https://crrev.com/070b773c468f3aeed645334f53850175512e8b08/chrome/browser/notifications/notification_platform_bridge_chromeos.cc [add] https://crrev.com/070b773c468f3aeed645334f53850175512e8b08/chrome/browser/notifications/notification_platform_bridge_chromeos_unittest.cc [modify] https://crrev.com/070b773c468f3aeed645334f53850175512e8b08/chrome/test/BUILD.gn
,
May 14 2018
,
May 15 2018
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 15 2018
Fairly big change into beta but it looks like most is for the unit test. Has this been tested in M68/ToT to verify no unintended consequences?
,
May 15 2018
manually tested on trunk, yes, and yes, change to non-test code is very minimal
,
May 15 2018
Approving merge to M67 Chrome OS.
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb0919b4144c81e29d30a503c0219e946c28e05f commit cb0919b4144c81e29d30a503c0219e946c28e05f Author: Evan Stade <estade@chromium.org> Date: Wed May 16 20:05:58 2018 Correctly update notification delegate for Chrome OS mojo notifications. When a notification was updated (same ID, new properties), the appearance --- title, image, etc. --- was updated, but the old delegate wasn't replaced with the new delegate. Fix that and add a test. TBR=estade@chromium.org (cherry picked from commit 070b773c468f3aeed645334f53850175512e8b08) Bug: 840105 Change-Id: I83fd7453f13c41adf96a417e3945a85933a9e1a3 Reviewed-on: https://chromium-review.googlesource.com/1056091 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#558315} Reviewed-on: https://chromium-review.googlesource.com/1062651 Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#616} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/cb0919b4144c81e29d30a503c0219e946c28e05f/chrome/browser/notifications/chrome_ash_message_center_client.cc [modify] https://crrev.com/cb0919b4144c81e29d30a503c0219e946c28e05f/chrome/browser/notifications/notification_platform_bridge_chromeos.cc [add] https://crrev.com/cb0919b4144c81e29d30a503c0219e946c28e05f/chrome/browser/notifications/notification_platform_bridge_chromeos_unittest.cc [modify] https://crrev.com/cb0919b4144c81e29d30a503c0219e946c28e05f/chrome/test/BUILD.gn
,
May 22 2018
Merge has been completed, marking this as fixed. Thanks.
,
May 22 2018
,
May 24 2018
,
May 25 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 Deleted