New issue
Advanced search Search tips

Issue 840080 link

Starred by 6 users

Issue metadata

Status: Duplicate
Merged: issue 791231
Owner:
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

"Keep local data only until you quit your browser" does not delete non-cookie data

Reported by rkirya...@gmail.com, May 5 2018

Issue description

Chrome Version       : 66.0.3359.139
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari: not tested
    Firefox: not tested
    IE/Edge: not tested

What steps will reproduce the problem?
1. Confirm there are no extensions available.
2. Set "Keep local data only until you quit your browser".
3. Visit a website (reddit.com).
4. Confirm there is some local data.
5. Close Chrome.
6. Open Chrome.
7. Confirm there is no local data.
8. Install an extension (uBlock Origin).
9. Visit a website (reddit.com).
10. Confirm there is some local data.
11. Close Chrome.
12. Open Chrome.
13. The website still has some local data (name and "File system").
14. REMOVE the extension.
15. Close Chrome.
16. Open Chrome.
17. The website still has some local data (name and "File system").

What is the expected result?
Chrome should remove local data regardless if extensions are installed or not.

What happens instead of that?
Once local data is there the only way to prevent it from staying there is to remove all extensions and remove all local data. Then the feature works as expected.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36
 
Labels: Needs-Triage-M66
Cc: phanindra.mandapaka@chromium.org
Components: UI>Browser>Sessions
Labels: Needs-Feedback Triaged-ET
As per comment #0 followed the same steps and unable to reproduce it on  version 66.0.3359.139 using Windows 10. Attaching screencast for reference.

@Reporter: As we are unable to reproduce the issue from our end. Can you please let us know if we miss anything and could you please provide any test file/Screencast for better triaging this issue.

Thanks! 

840080.mp4
4.3 MB View Download

Comment 3 by rkirya...@gmail.com, May 11 2018

Hi. Thank you for looking into this issue. I found it is not 100% repro. This is what I see on my end (about 50% times):

https://youtu.be/tAPP7PeV_CA

Please notice that cookies were deleted, but "File system" was still there.
Project Member

Comment 4 by sheriffbot@chromium.org, May 11 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
rkiryanov@ Thanks for the update.

Retried the issue on Windows 10 on the reported version 66.0.3359.139 and the latest Canary 68.0.3433.0 as per comment #3 and unable to reproduce the issue.

After enabling the  "Keep local data only until you quit your browser" option -> navigated to a site -> Exited and relaunched chrome, cannot observe the cookies of the previous session.
Attached is the screen cast of the steps followed.

As per comment #3. as the reporter has confirmed that the issue is inconsistent, requesting UI>Browser>Sessions team to look into the issue and help in further triaging.

Thanks..


840080.mp4
3.3 MB View Download

Comment 6 by rkirya...@gmail.com, May 17 2018

If you look at the video I uploaded, reddit.com looked differently from your video (my has a large box over small topics). I noticed, the issue does not repro if reddit looks like on your video - no box in from and large topics.

I found tripadvisor.com reproduced this issue twice out of two times for me.
Labels: M-68 FoundIn-68 Target-68 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
As per comment #6 tested this issue and we are able to reproduce the issue on reported chrome version 66.0.3359.139 and on latest chrome 68.0.3438.0 using Windows 10, Mac 10.13.3 and Ubuntu 14.04.  
 
Same behavior is seen on M62(62.0.3202.97) hence considering it as non-regression and marking it as Untriaged.
Thanks! 

Components: -UI>Browser>Sessions Blink>Storage>FileSystem Privacy
I'm able to reproduce this with tripadvisor.com even without any extension. 
Using Clear Browsing Data for "Last hour" also leaves the file system entry behind. It looks like this entry doesn't actually contain any data but it should still be cleaned up properly.
Owner: nhiroki@chromium.org
Status: Assigned (was: Untriaged)
As a very simple reproduction case:
1. Visit example.com
2. Execute "window.webkitRequestFileSystem(TEMPORARY, 1024, console.log)" in the console
3. Delete cookies for "Last hour" at chrome://settings/clearBrowserData
4. Check chrome://settings/siteData
5. See that example.com is still listed for file system storage.

Deletion for "All time" works correctly. 
nhiroki@, could you or some other file system owner take a look?
Cc: nhiroki@chromium.org
Owner: pwnall@chromium.org
We need to own this on the storage team. (Not that I'd turn down Hiroki-san's help!) 

pwnall@ - can we prioritize appropriately?
Cc: dullweber@chromium.org
Labels: -Target-68
I see two issues discussed in this bug.

1) The early comments state that some storage features don't honor the "Keep local data only until you quit your browser" preference. This is a fairly straightforward privacy bug and we can prioritize it accordingly.

2) Comments #8 and #9 state that storage features don't honor "Delete cookies for last X [hour / 24 hours / 7 days / 4 weeks / all time]". This is a bit unclear to me. Is the feature supposed to be a rewind (set the local state to what it was X ago) or a selective nuke (delete the local data for every site I've accessed in the last X).

This matters because selecting nuking is possible, but I don't know how to implement rewinding efficiently (without burning through disk space) for most of our storage mechanisms. Even if disk space weren't a concern, rewind would have to be implemented feature-by-feature in AppCache, Cache Storage, DOM Storage, FileSystem, IndexedDB, and WebSQL. This would be a multi-quarter project.

dullwebber@: Would it make sense to focus this bug on the first issue (per the title) and move the 2nd issue into a separate bug, where we discuss what's the meaning of the feature and what guarantees we can provide for it?

Removed Target-68, because I'm fairly sure we wouldn't pursue a merge for this.
Sure, the first part is more important. I assumed that it is the same issue because the remaining data looks similar and both are partial deletions. 

Delete for the last hour remvoves all data that was modified during the last hour. 
I can reproduce this issue on Chrome 69. Local storage as well as indexedDB data are preserved after session.
Mergedinto: 791231
Status: Duplicate (was: Assigned)
No repro for me for comment #9 on tip-of-tree.

Issues with "Keep local data only until you quit your browser" appears to be a duplicate of  issue 791231  so resolving this. If there's a separate repro, let's get a different bug. 

Sign in to add a comment