Issue metadata
Sign in to add a comment
|
SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0 is Flaky |
||||||||||||||||||||||
Issue descriptionFindit has detected a flake at test SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0. Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I3335bfd452cc284a585e84a87b8912207b843813 Regression range: https://crrev.com/3698e89bf23d74b96c09610d6425a601f567f714..3698e89bf23d74b96c09610d6425a601f567f714?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKdAWNocm9taXVtLm1hYy9NYWMxMC4xMSBUZXN0cy8yNTkyMi9icm93c2VyX3Rlc3RzIG9uIE1hYy0xMC4xMS9VMkYyWlZSNWNHVXZVMkYyWlZCaFoyVlBjbWxuYVc1aGJGWnpVMkYyWldSRGIyMXdZWEpwYzI5dVZHVnpkQzVQWW1wbFkzUkZiR1Z0Wlc1MGMxWnBZVVpwYkdVdk1BPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
,
May 7 2018
IMO, the culprit does not look related to the failed test. Assigning to majidvp@ for further analysis.
,
May 15 2018
This is completely unrelated to my CL. I gave find-it an "incorrect" feedback. :) I did some investigation see my notes below. Assigning to qinmin@ who is the relevant owner in that area who can further triage id this is an actual issue. Looking at the task output with failure, the test is timing out. https://chromium-swarm.appspot.com/task?id=3d46b9370578ea10&refresh=10&show_raw=1 In particular in SavePageOriginalVsSavedComparisonTest::AssertExpectationsAboutCurrentTab() is trying to find something in the page and is waiting for it to complete which apparently it never does. See here: https://codesearch.chromium.org/chromium/src/chrome/test/base/ui_test_utils.cc?type=cs&sq=package:chromium&g=0&l=350 That code seems to rely on receiving a notification NOTIFICATION_FIND_RESULT_AVAILABLE. https://codesearch.chromium.org/chromium/src/chrome/browser/chrome_notification_types.h?type=cs&sq=package:chromium&g=0&l=131 Incidentally, there is the following message that precedes this failure "AlertNotificationService: XPC connection invalidated" which suggests there is a system level failure at work here. Here is the output: Still waiting for the following processes to finish: ./browser_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0 --single_process --test-launcher-bot-mode --test-launcher-output=/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.UZbY3r/resultsxO5fBi/test_results.xml --test-launcher-retry-limit=0 --test-launcher-summary-output=/b/s/w/iotRC_55/output.json --user-data-dir=/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.UZbY3r/dawzim5 Still waiting for the following processes to finish: ./browser_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0 --single_process --test-launcher-bot-mode --test-launcher-output=/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.UZbY3r/resultsxO5fBi/test_results.xml --test-launcher-retry-limit=0 --test-launcher-summary-output=/b/s/w/iotRC_55/output.json --user-data-dir=/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.UZbY3r/dawzim5 [ RUN ] SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0 [28444:14599:0504/183008.858037:WARNING:notification_platform_bridge_mac.mm(509)] AlertNotificationService: XPC connection invalidated. [28444:775:0504/183009.568177:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) [28444:775:0504/183010.615860:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) BrowserTestBase received signal: Terminated: 15. Backtrace: 0 browser_tests 0x000000010c4f9d8c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x000000010ca88d85 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229 2 libsystem_platform.dylib 0x00007fff9e7ec52a _sigtramp + 26 3 ??? 0x0000000000000001 0x0 + 1 4 CoreFoundation 0x00007fff9daeb1c4 __CFRunLoopServiceMachPort + 212 5 CoreFoundation 0x00007fff9daea68c __CFRunLoopRun + 1356 6 CoreFoundation 0x00007fff9dae9ed8 CFRunLoopRunSpecific + 296 7 HIToolbox 0x00007fff9e4f3935 RunCurrentEventLoopInMode + 235 8 HIToolbox 0x00007fff9e4f376f ReceiveNextEventCommon + 432 9 HIToolbox 0x00007fff9e4f35af _BlockUntilNextEventMatchingListInModeWithFilter + 71 10 AppKit 0x00007fff8ea3cdf6 _DPSNextEvent + 1067 11 AppKit 0x00007fff8ea3c226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 454 12 browser_tests 0x000000010c5a4800 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 13 browser_tests 0x000000010c46444a base::mac::CallWithEHFrame(void () block_pointer) + 10 14 browser_tests 0x000000010c5a4734 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164 15 AppKit 0x00007fff8ea30d80 -[NSApplication run] + 682 16 browser_tests 0x000000010c47459c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364 17 browser_tests 0x000000010c4730be base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110 18 browser_tests 0x000000010c497025 base::RunLoop::Run() + 53 19 browser_tests 0x000000010caad6a0 content::MessageLoopRunner::Run() + 48 20 browser_tests 0x000000010c533fea ui_test_utils::FindInPage(content::WebContents*, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, bool, bool, int*, gfx::Rect*) + 138 21 browser_tests 0x00000001092bffd9 (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::AssertExpectationsAboutCurrentTab(int, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) + 1385 22 browser_tests 0x00000001092bfa04 (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::TestOriginalVsSavedPage(content::SavePageType, GURL const&, int, int, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) + 644 23 browser_tests 0x00000001092c09dd (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::RunObjectElementsTest(GURL) + 1133 24 browser_tests 0x00000001092c0ed6 (anonymous namespace)::SavePageOriginalVsSavedComparisonTest_ObjectElementsViaFile_Test::RunTestOnMainThread() + 694 25 browser_tests 0x000000010ca88aa3 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 515 26 browser_tests 0x000000010c5aa7f9 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4233 27 browser_tests 0x000000010c5a966e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 28 browser_tests 0x000000010b09fad3 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 29 browser_tests 0x000000010b450e27 content::StartupTaskRunner::RunAllTasksNow() + 39 30 browser_tests 0x000000010b09e6ed content::BrowserMainLoop::CreateStartupTasks() + 813 31 browser_tests 0x000000010b0a1cc0 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 96 32 browser_tests 0x000000010b09c634 content::BrowserMain(content::MainFunctionParams const&) + 180 33 browser_tests 0x000000010c3ec7e9 content::ContentMainRunnerImpl::Run() + 377 34 browser_tests 0x000000010e0ac912 service_manager::Main(service_manager::MainParams const&) + 2354 35 browser_tests 0x000000010c3ebc74 content::ContentMain(content::ContentMainParams const&) + 68 36 browser_tests 0x000000010ca886be content::BrowserTestBase::SetUp() + 2574 37 browser_tests 0x000000010c52ff28 InProcessBrowserTest::SetUp() + 536 38 browser_tests 0x000000010a5f337d testing::Test::Run() + 109 39 browser_tests 0x000000010a5f3fc0 testing::TestInfo::Run() + 304 40 browser_tests 0x000000010a5f4537 testing::TestCase::Run() + 279 41 browser_tests 0x000000010a5ffb97 testing::internal::UnitTestImpl::RunAllTests() + 855 42 browser_tests 0x000000010a5ff81e testing::UnitTest::Run() + 110 43 browser_tests 0x000000010c5486e7 base::TestSuite::Run() + 167 44 browser_tests 0x000000010c442d15 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37 45 browser_tests 0x000000010caa9815 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389 46 browser_tests 0x000000010c4431fc LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 348 47 browser_tests 0x000000010c442c8e main + 94 48 libdyld.dylib 0x00007fff99a085ad start + 1 49 ??? 0x000000000000000b 0x0 + 11 [1/1] SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0 (TIMED OUT)
,
Aug 17
Also failing on win/asan: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-asan/11
,
Aug 17
Looks like it fails consistently with a use-after-free on Linux ASan, same as Windows: https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxASan/3188 Shall we disable it? Whoever debugs this in the end, I recommend using ASan. It seems to report an error determinsticaly.
,
Aug 17
The linux asan bot has an excellent stack: [ RUN ] SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0 Xlib: extension "RANDR" missing on display ":99". [6794:6794:0817/121008.759733:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 32 characters (32 were expected). [6794:6987:0817/121009.119069:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix") [6794:6794:0817/121009.141246:WARNING:password_store_factory.cc(261)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. (browser_tests:6794): LIBDBUSMENU-GLIB-WARNING **: Unable to get session bus: Unknown or unsupported transport 'disabled' for address 'disabled:' [6794:6794:0817/121010.716921:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source: (0) ================================================================= ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x615000048190 at pc 0x000010d36737 bp 0x7ffdb8fd82c0 sp 0x7ffdb8fd82b8 READ of size 1 at 0x615000048190 thread T0 (browser_tests) #0 0x10d36736 in extensions::MimeHandlerViewContainerBase::MaybeCreatePluginThrottle(GURL const&) extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container_base.cc:204:8 #1 0x124c288a in URLLoaderThrottleProviderImpl::CreateThrottles(int, blink::WebURLRequest const&, content::ResourceType) chrome/renderer/url_loader_throttle_provider_impl.cc:209:32 #2 0x208215a9 in content::RenderFrameImpl::WillSendRequest(blink::WebURLRequest&) content/renderer/render_frame_impl.cc:4920:56 #3 0x1d232768 in blink::LocalFrameClientImpl::DispatchWillSendRequest(blink::ResourceRequest&) third_party/blink/renderer/core/exported/local_frame_client_impl.cc:365:27 #4 0x1e312ab9 in blink::FrameFetchContext::PrepareRequest(blink::ResourceRequest&, blink::FetchContext::RedirectType) third_party/blink/renderer/core/loader/frame_fetch_context.cc:526:26 #5 0x1079667c in blink::ResourceFetcher::PrepareRequest(blink::FetchParameters&, blink::ResourceFactory const&, blink::SubstituteData const&, unsigned long) third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc:745:13 #6 0x10797145 in blink::ResourceFetcher::RequestResource(blink::FetchParameters&, blink::ResourceFactory const&, blink::ResourceClient*, blink::SubstituteData const&) third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc:813:7 #7 0x1e385dda in blink::ImageResource::Fetch(blink::FetchParameters&, blink::ResourceFetcher*) third_party/blink/renderer/core/loader/resource/image_resource.cc:167:16 #8 0x1e390a88 in blink::ImageResourceContent::Fetch(blink::FetchParameters&, blink::ResourceFetcher*) third_party/blink/renderer/core/loader/resource/image_resource_content.cc:121:29 #9 0x1e34671c in blink::ImageLoader::DoUpdateFromElement(blink::ImageLoader::BypassMainWorldBehavior, blink::ImageLoader::UpdateFromElementBehavior, blink::KURL const&, blink::ReferrerPolicy, blink::ImageLoader::UpdateType) third_party/blink/renderer/core/loader/image_loader.cc:454:25 #10 0x1e3486fd in blink::ImageLoader::UpdateFromElement(blink::ImageLoader::UpdateFromElementBehavior, blink::ReferrerPolicy) third_party/blink/renderer/core/loader/image_loader.cc:556:5 #11 0x1d59aecd in blink::HTMLPlugInElement::CustomStyleForLayoutObject() third_party/blink/renderer/core/html/html_plugin_element.cc:727:20 #12 0x1c96281f in blink::Element::StyleForLayoutObject() third_party/blink/renderer/core/dom/element.cc:2280:46 #13 0x1c964c10 in blink::Element::RecalcOwnStyle(blink::StyleRecalcChange) third_party/blink/renderer/core/dom/element.cc:2469:17 #14 0x1c963adb in blink::Element::RecalcStyle(blink::StyleRecalcChange) third_party/blink/renderer/core/dom/element.cc:2379:16 #15 0x1c806936 in blink::ContainerNode::RecalcDescendantStyles(blink::StyleRecalcChange) third_party/blink/renderer/core/dom/container_node.cc:1376:18 #16 0x1c9640b9 in blink::Element::RecalcStyle(blink::StyleRecalcChange) third_party/blink/renderer/core/dom/element.cc:2416:7 #17 0x1c806936 in blink::ContainerNode::RecalcDescendantStyles(blink::StyleRecalcChange) third_party/blink/renderer/core/dom/container_node.cc:1376:18 #18 0x1c9640b9 in blink::Element::RecalcStyle(blink::StyleRecalcChange) third_party/blink/renderer/core/dom/element.cc:2416:7 #19 0x1c855d22 in blink::Document::UpdateStyle() third_party/blink/renderer/core/dom/document.cc:2305:25 #20 0x1c849548 in blink::Document::UpdateStyleAndLayoutTree() third_party/blink/renderer/core/dom/document.cc:2219:3 #21 0x1c88590d in blink::Document::FinishedParsing() third_party/blink/renderer/core/dom/document.cc:5937:7 #22 0x1d701e77 in end third_party/blink/renderer/core/html/parser/html_document_parser.cc:890:18 #23 0x1d701e77 in blink::HTMLDocumentParser::AttemptToRunDeferredScriptsAndEnd() third_party/blink/renderer/core/html/parser/html_document_parser.cc:905:0 #24 0x1d707db1 in blink::HTMLDocumentParser::ProcessTokenizedChunkFromBackgroundParser(std::__1::unique_ptr<blink::HTMLDocumentParser::TokenizedChunk, std::__1::default_delete<blink::HTMLDocumentParser::TokenizedChunk> >) third_party/blink/renderer/core/html/parser/html_document_parser.cc:543:7 #25 0x1d7035c8 in blink::HTMLDocumentParser::PumpPendingSpeculations() third_party/blink/renderer/core/html/parser/html_document_parser.cc:591:9 #26 0x1bddf7d1 in Run base/callback.h:99:12 #27 0x1bddf7d1 in blink::TaskHandle::Runner::Run(blink::TaskHandle const&) third_party/blink/renderer/platform/web_task_runner.cc:55:0 #28 0x1142b003 in Run base/callback.h:99:12 #29 0x1142b003 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101:0 #30 0x1150f397 in base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) base/task/sequence_manager/thread_controller_impl.cc:178:23 #31 0x1142b003 in Run base/callback.h:99:12 #32 0x1142b003 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101:0 #33 0x11426490 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:431:46 #34 0x11427728 in DeferOrRunPendingTask base/message_loop/message_loop.cc:442:5 #35 0x11427728 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:514:0 #36 0x114311bf in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:37:31 #37 0x1149d421 in base::RunLoop::Run() base/run_loop.cc:102:14 #38 0x215b29df in content::RendererMain(content::MainFunctionParams const&) content/renderer/renderer_main.cc:201:23 #39 0x10e5cb9d in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:494:14 #40 0x10e5fdba in content::ContentMainRunnerImpl::Run(bool) content/app/content_main_runner_impl.cc:892:10 #41 0x176490c4 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:472:29 #42 0x10e5b2df in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #43 0x127912b2 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:635:12 #44 0x113a136a in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:170:10 #45 0x113a002b in main chrome/test/base/browser_tests_main.cc:36:10 #46 0x7f9ec318ff44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 0x615000048190 is located 144 bytes inside of 488-byte region [0x615000048100,0x6150000482e8) freed by thread T0 (browser_tests) here: #0 0x5b6f570 in operator delete(void*) _asan_rtl_:0 #1 0x21909895 in guest_view::GuestViewContainer::Destroy(bool) components/guest_view/renderer/guest_view_container.cc:118:3 #2 0x21346a15 in content::BrowserPlugin::~BrowserPlugin() content/renderer/browser_plugin/browser_plugin.cc:114:16 #3 0x213471cd in content::BrowserPlugin::~BrowserPlugin() content/renderer/browser_plugin/browser_plugin.cc:110:33 #4 0x1142b003 in Run base/callback.h:99:12 #5 0x1142b003 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101:0 #6 0x1150f397 in base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) base/task/sequence_manager/thread_controller_impl.cc:178:23 #7 0x1142b003 in Run base/callback.h:99:12 #8 0x1142b003 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101:0 #9 0x11426490 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:431:46 #10 0x11427728 in DeferOrRunPendingTask base/message_loop/message_loop.cc:442:5 #11 0x11427728 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:514:0 #12 0x114311bf in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:37:31 #13 0x1149d421 in base::RunLoop::Run() base/run_loop.cc:102:14 #14 0x215b29df in content::RendererMain(content::MainFunctionParams const&) content/renderer/renderer_main.cc:201:23 #15 0x10e5cb9d in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:494:14 #16 0x10e5fdba in content::ContentMainRunnerImpl::Run(bool) content/app/content_main_runner_impl.cc:892:10 #17 0x176490c4 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:472:29 #18 0x10e5b2df in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #19 0x127912b2 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:635:12 #20 0x113a136a in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:170:10 #21 0x113a002b in main chrome/test/base/browser_tests_main.cc:36:10 #22 0x7f9ec318ff44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 previously allocated by thread T0 (browser_tests) here: #0 0x5b6e718 in operator new(unsigned long) _asan_rtl_:0 #1 0x12534ad7 in ChromeExtensionsRendererClient::CreateBrowserPluginDelegate(content::RenderFrame*, content::WebPluginInfo const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, GURL const&) chrome/renderer/extensions/chrome_extensions_renderer_client.cc:325:10 #2 0x207ee23f in content::RenderFrameImpl::CreatePlugin(content::WebPluginInfo const&, blink::WebPluginParams const&, std::__1::unique_ptr<content::PluginInstanceThrottler, std::__1::default_delete<content::PluginInstanceThrottler> >) content/renderer/render_frame_impl.cc:2771:41 #3 0x1243f650 in ChromeContentRendererClient::CreatePlugin(content::RenderFrame*, blink::WebPluginParams const&, chrome::mojom::PluginInfo const&) chrome/renderer/chrome_content_renderer_client.cc:929:30 #4 0x1243af31 in ChromeContentRendererClient::OverrideCreatePlugin(content::RenderFrame*, blink::WebPluginParams const&, blink::WebPlugin**) chrome/renderer/chrome_content_renderer_client.cc:685:13 #5 0x207fbe76 in content::RenderFrameImpl::CreatePlugin(blink::WebPluginParams const&) content/renderer/render_frame_impl.cc:3475:39 #6 0x1d237e25 in blink::LocalFrameClientImpl::CreatePlugin(blink::HTMLPlugInElement&, blink::KURL const&, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const&, WTF::Vector<WTF::String, 0u, WTF::PartitionAllocator> const&, WTF::String const&, bool) third_party/blink/renderer/core/exported/local_frame_client_impl.cc:806:49 #7 0x1d595ae8 in blink::HTMLPlugInElement::LoadPlugin(blink::KURL const&, WTF::String const&, blink::PluginParameters const&, bool) third_party/blink/renderer/core/html/html_plugin_element.cc:602:55 #8 0x1d5945c9 in blink::HTMLPlugInElement::RequestObjectInternal(blink::PluginParameters const&) third_party/blink/renderer/core/html/html_plugin_element.cc:203:10 #9 0x1d59a01a in blink::HTMLPlugInElement::RequestObject(blink::PluginParameters const&) third_party/blink/renderer/core/html/html_plugin_element.cc:566:17 #10 0x1d587e64 in blink::HTMLObjectElement::UpdatePluginInternal() third_party/blink/renderer/core/html/html_object_element.cc:280:30 #11 0x1d5973ad in blink::HTMLPlugInElement::UpdatePlugin() third_party/blink/renderer/core/html/html_plugin_element.cc:275:3 #12 0x1d0fc743 in blink::LocalFrameView::UpdatePlugins() third_party/blink/renderer/core/frame/local_frame_view.cc:1986:16 #13 0x1d0e3e2d in blink::LocalFrameView::UpdatePluginsTimerFired(blink::TimerBase*) third_party/blink/renderer/core/frame/local_frame_view.cc:2001:9 #14 0x1bdb7e2c in blink::TimerBase::RunInternal() third_party/blink/renderer/platform/timer.cc:156:3 #15 0x1142b003 in Run base/callback.h:99:12 #16 0x1142b003 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101:0 #17 0x1150f397 in base::sequence_manager::internal::ThreadControllerImpl::DoWork(base::sequence_manager::internal::ThreadControllerImpl::WorkType) base/task/sequence_manager/thread_controller_impl.cc:178:23 #18 0x1142b003 in Run base/callback.h:99:12 #19 0x1142b003 in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) base/debug/task_annotator.cc:101:0 #20 0x11426490 in base::MessageLoop::RunTask(base::PendingTask*) base/message_loop/message_loop.cc:431:46 #21 0x11427728 in DeferOrRunPendingTask base/message_loop/message_loop.cc:442:5 #22 0x11427728 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:514:0 #23 0x114311bf in base::MessagePumpDefault::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_default.cc:37:31 #24 0x1149d421 in base::RunLoop::Run() base/run_loop.cc:102:14 #25 0x215b29df in content::RendererMain(content::MainFunctionParams const&) content/renderer/renderer_main.cc:201:23 #26 0x10e5cb9d in content::RunZygote(content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:494:14 #27 0x10e5fdba in content::ContentMainRunnerImpl::Run(bool) content/app/content_main_runner_impl.cc:892:10 #28 0x176490c4 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:472:29 #29 0x10e5b2df in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #30 0x127912b2 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:635:12 #31 0x113a136a in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:170:10 #32 0x113a002b in main chrome/test/base/browser_tests_main.cc:36:10 SUMMARY: AddressSanitizer: heap-use-after-free (/b/s/w/ir/out/Release/browser_tests+0x10d36736) Shadow bytes around the buggy address: 0x0c2a80000fe0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c2a80000ff0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c2a80001000: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa 0x0c2a80001010: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c2a80001020: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd =>0x0c2a80001030: fd fd[fd]fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c2a80001040: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c2a80001050: fd fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa 0x0c2a80001060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c2a80001070: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c2a80001080: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==1==ABORTING ../../chrome/browser/download/save_page_browsertest.cc:1115: Failure Expected equality of these values: expected_number_of_frames Which is: 7 actual_number_of_frames Which is: 1 Stack trace: #0 0x00000a14ba5c in StackTraceGetter::CurrentStackTrace(int, int) third_party/googletest/custom/gtest/internal/custom/stack_trace_getter.cc:22:27 #1 0x00000a16eb40 in testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) third_party/googletest/src/googletest/src/gtest.cc:825:35 #2 0x00000a16d6b7 in testing::internal::AssertHelper::operator=(testing::Message const&) const third_party/googletest/src/googletest/src/gtest.cc:401:25 #3 0x0000063163f7 in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::AssertExpectationsAboutCurrentTab(int, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) chrome/browser/download/save_page_browsertest.cc:1115:5 #4 0x000006315ad4 in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::TestOriginalVsSavedPage(content::SavePageType, GURL const&, int, int, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) chrome/browser/download/save_page_browsertest.cc:1073:5 #5 0x0000063189aa in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::RunObjectElementsTest(GURL) chrome/browser/download/save_page_browsertest.cc:1104:5 #6 0x0000063196c7 in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest_ObjectElementsViaFile_Test::RunTestOnMainThread() chrome/browser/download/save_page_browsertest.cc:1193:3 #7 0x000012710cbf in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:406:5 #8 0x000011805432 in Run base/callback.h:129:12 #9 0x000011805432 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:2000:0 #10 0x0000118025af in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1384:18 #11 0x00000cb41258 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1023:13 #12 0x00000d94a486 in Run base/callback.h:129:12 #13 0x00000d94a486 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:43:0 #14 0x00000cb3caad in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:934:25 #15 0x00000cb49b52 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:141:15 #16 0x00000cb35fdb in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:43:32 #17 0x000010e601d8 in RunBrowserProcessMain content/app/content_main_runner_impl.cc:536:10 #18 0x000010e601d8 in content::ContentMainRunnerImpl::Run(bool) content/app/content_main_runner_impl.cc:888:0 #19 0x0000176490c5 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:472:29 #20 0x000010e5b2e0 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #21 0x00001270f884 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:322:3 #22 0x0000116bbd57 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:251:20 BrowserTestBase received signal: Terminated. Backtrace: #0 0x000005aa43d1 in __interceptor_backtrace /b/c/b/ToTLinuxASan/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4024:0 #1 0x0000115f803c in base::debug::StackTrace::StackTrace(unsigned long) base/debug/stack_trace_posix.cc:808:41 #2 0x000012712c36 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) content/public/test/browser_test_base.cc:84:5 #3 0x7fe926229cb0 in killpg ??:? #4 0x7fe926229cb0 in ?? ??:0 #5 0x7fe9262e3c9d in __poll /build/eglibc-ripdx6/eglibc-2.19/io/../sysdeps/unix/syscall-template.S:81:0 #6 0x000005a74fd2 in __interceptor_poll /b/c/b/ToTLinuxASan/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:3846:0 #7 0x7fe92c3c8fe4 in g_main_context_dispatch ??:? #8 0x7fe92c3c8fe4 in ?? ??:0 #9 0x7fe92c3c90ec in g_main_context_iteration ??:0:0 #10 0x0000114322b6 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:305:30 #11 0x00001149d422 in base::RunLoop::Run() base/run_loop.cc:102:14 #12 0x0000127a1867 in RunThisRunLoop content/public/test/test_utils.cc:128:13 #13 0x0000127a1867 in content::MessageLoopRunner::Run() content/public/test/test_utils.cc:293:0 #14 0x0000116cf068 in ui_test_utils::FindInPage(content::WebContents*, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, bool, bool, int*, gfx::Rect*) chrome/test/base/ui_test_utils.cc:351:12 #15 0x0000063166cf in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::AssertExpectationsAboutCurrentTab(int, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) chrome/browser/download/save_page_browsertest.cc:1118:38 #16 0x000006315ad4 in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::TestOriginalVsSavedPage(content::SavePageType, GURL const&, int, int, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) chrome/browser/download/save_page_browsertest.cc:1073:5 #17 0x0000063189aa in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest::RunObjectElementsTest(GURL) chrome/browser/download/save_page_browsertest.cc:1104:5 #18 0x0000063196c7 in (anonymous namespace)::SavePageOriginalVsSavedComparisonTest_ObjectElementsViaFile_Test::RunTestOnMainThread() chrome/browser/download/save_page_browsertest.cc:1193:3 #19 0x000012710cbf in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:406:5 #20 0x000011805432 in Run base/callback.h:129:12 #21 0x000011805432 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:2000:0 #22 0x0000118025af in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1384:18 #23 0x00000cb41258 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1023:13 #24 0x00000d94a486 in Run base/callback.h:129:12 #25 0x00000d94a486 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:43:0 #26 0x00000cb3caad in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:934:25 #27 0x00000cb49b52 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:141:15 #28 0x00000cb35fdb in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:43:32 #29 0x000010e601d8 in RunBrowserProcessMain content/app/content_main_runner_impl.cc:536:10 #30 0x000010e601d8 in content::ContentMainRunnerImpl::Run(bool) content/app/content_main_runner_impl.cc:888:0 #31 0x0000176490c5 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:472:29 #32 0x000010e5b2e0 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10 #33 0x00001270f884 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:322:3 #34 0x0000116bbd57 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:251:20 #35 0x0000062e3051 in (anonymous namespace)::SavePageBrowserTest::SetUp() chrome/browser/download/save_page_browsertest.cc:296:27 #36 0x00000a1840d3 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:0:0 #37 0x00000a1864a5 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11 #38 0x00000a1878b7 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28 #39 0x00000a1ad407 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43 #40 0x00000a1ac633 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:0:0 #41 0x000011705498 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46 #42 0x000011705498 in base::TestSuite::Run() base/test/test_suite.cc:277:0 #43 0x0000113a05ae in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/chrome_test_launcher.cc:65:38 #44 0x00001279137d in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:645:31 #45 0x0000113a136b in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:170:10 #46 0x0000113a002c in main chrome/test/base/browser_tests_main.cc:36:10 #47 0x7fe926214f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #48 0x000005a4e02a in _start ??:0:0
,
Aug 17
The regular linux/asan bot is happy however for some reason: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20LSan%20Tests%20%281%29/48703
,
Aug 17
Hey the top function on that stack was touched 4 days ago in https://chromium.googlesource.com/chromium/src/+/040df725447fda691ec72eeea88916b442f5a867
,
Aug 17
https://chromium.googlesource.com/chromium/src/+/bb8e738e5eb7ab4286d69494b3b89aebc3eedb3b also landed shortly before the original report and is owner-ship-py.
,
Aug 19
,
Aug 19
lukasza, does the stack in comment 6 look oopif-y?
,
Aug 19
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eee777fd81eaef87fbdb0b77fe53334090db4af4 commit eee777fd81eaef87fbdb0b77fe53334090db4af4 Author: Nico Weber <thakis@chromium.org> Date: Mon Aug 20 01:42:40 2018 Disable flaky test and run network_service_browser_tests on win-asan. Disables SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile which is flaky on several platforms (and fails consistenly on linux/asan). TBR=lukasza Bug: 840063 Change-Id: I7ac546dcb8f4a60417e45ca9b7ce20667b31abcb Reviewed-on: https://chromium-review.googlesource.com/1180709 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#584351} [modify] https://crrev.com/eee777fd81eaef87fbdb0b77fe53334090db4af4/chrome/browser/download/save_page_browsertest.cc [modify] https://crrev.com/eee777fd81eaef87fbdb0b77fe53334090db4af4/testing/buildbot/chromium.memory.json [modify] https://crrev.com/eee777fd81eaef87fbdb0b77fe53334090db4af4/testing/buildbot/test_suite_exceptions.pyl
,
Aug 20
RE: #c11: thakis@: The test and stack are both somewhat OOPIF-y:
- the test uses OOPIFs
- the GuestView is implemented on top of OOPIFs
FWIW, I've tried to repro the UaF/ASAN report, but it didn't repro for me...
$ cat out/asan/args.gn
is_asan = true
is_debug = false
dcheck_always_on = true
is_component_build = true
use_goma = true
enable_nacl = false
$ ninja -C out/asan browser_tests
...
$ DISPLAY=:20 out/asan/browser_tests \
--gtest_filter=*SavePageOriginalVsSavedComparisonTest*ObjectElementsViaFile* \
--gtest_also_run_disabled_tests
... all tests pass...
I hope that ekaramad@ will have better luck...
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by Findit
, May 5 2018