New issue
Advanced search Search tips

Issue 840058 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payment Handler] Installation fails if instrument icon is specified is incorrect

Project Member Reported by ma...@chromium.org, May 5 2018

Issue description

In Payment Handler, instrument-level icon is currently not used. Rather, the Payment Handler web app manifest's icon is fetched and used. 

During installation, we fail to install the payment handler if the instrument-level icon is not valid. We should probably ignore it? Perhaps I'm misunderstanding something.
 
Screen Shot 2018-05-04 at 9.29.24 PM.png
77.8 KB View Download
Agree, we could ignore this, even though the spec specifies TypeError when failed to parse the source.

Comment 2 by ma...@chromium.org, May 7 2018

Cc: anthonyvd@chromium.org
It's not a type error in this case, since it's a valid string '/pay/not-an-icon.png'. But I think we somehow try to fetch it? Not sure.

BTW seems like install still works.
There has been issues with the icon for a while now. There are some funky validation rules on the instrument level icon for a while. The only way i could get my app to install was to use the alipay icon from the example even though my web manifest contained my actual icon which was the one used. Even worse than this. There was no error given if I specified my icon in the insturment level. It just failed

Comment 4 by ma...@chromium.org, May 16 2018

Thanks for the feedback dannykrussell@. If your example is public, please like to it so we can make sure it's a supported configuration. 
ma..@chromium.org thanks for getting back to me so quickly. After further inspection it looks like the fix for https://bugs.chromium.org/p/chromium/issues/detail?id=828894 has resolved my issue so please disregard

Comment 6 by ma...@chromium.org, May 16 2018

Not sure how the linked bug would make a difference on this issue.
well it has highlighted that we no longer need to supply icon in the instrument at all which means there cannot be issues with its validation. Admittedly it is a stretch
Cc: rouslan@chromium.org

Sign in to add a comment