Issue metadata
Sign in to add a comment
|
TaskSchedulerImplTest.IdentifiableStacks is Flaky |
||||||||||||||||||||||||
Issue descriptionFindit has detected a flake at test TaskSchedulerImplTest.IdentifiableStacks. Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I8c1e928914aa6d2e35fedc1db4e8a639d39116b2 Regression range: https://crrev.com/7dae0564c3288a89d2c2af19dcaf169c15ffe5a7..7dae0564c3288a89d2c2af19dcaf169c15ffe5a7?pretty=fuller Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyngELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJoY2hyb21pdW0ubGludXgvTGludXggVGVzdHMvNjk3MjkvYmFzZV91bml0dGVzdHMvVkdGemExTmphR1ZrZFd4bGNrbHRjR3hVWlhOMExrbGtaVzUwYVdacFlXSnNaVk4wWVdOcmN3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If this result was incorrect, apply the label Findit-Incorrect-Result, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
,
May 5 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Linux Tests (dbg)(1)(32)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ1Y2hyb21pdW0ubGludXgvTGludXggVGVzdHMgKGRiZykoMSkoMzIpLzQ5ODUzL2Jhc2VfdW5pdHRlc3RzL1ZHRnphMU5qYUdWa2RXeGxja2x0Y0d4VVpYTjBMa2xrWlc1MGFXWnBZV0pzWlZOMFlXTnJjdz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 5 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 7 2018
r556169 has been reverted at https://chromium-review.googlesource.com/c/chromium/src/+/1045747. Assigning gab@ for followup.
,
May 7 2018
,
May 7 2018
This was caused by issue 840429 I believe, I'll reland with tests disabled on POSIX.
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be2419c13b0a7a1c43d9aeef8804266c923c0191 commit be2419c13b0a7a1c43d9aeef8804266c923c0191 Author: Gabriel Charette <gab@chromium.org> Date: Mon May 07 18:32:11 2018 Reland "[TaskScheduler] Label SchedulerWorker threads stacks with an identifying frame" This is a reland of 5b0cb536a073784425e1ba4e1fa594aefb58bebe It was reverted @ r556169 because the tests were flaky on POSIX. I believe the instability is in base::debug::StackTrace().Print(). This reland excludes the tests on POSIX. The logic is cross-platform and the tests on Windows prove it works. I will investigate POSIX separately in crbug.com/840429 Original change's description: > [TaskScheduler] Label SchedulerWorker threads stacks with an identifying frame > > I intentionally didn't add "Foreground" to non "Background" workers as > they may be used for background tasks in some configurations and I don't > want it to be confusing for developers. > > R=fdoray@chromium.org > > Bug: 839525 > Change-Id: I8c1e928914aa6d2e35fedc1db4e8a639d39116b2 > Reviewed-on: https://chromium-review.googlesource.com/1044501 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556169} TBR=fdoray@chromium.org Bug: 839525 , 840050 , 840429 Change-Id: Id1ee52a52483717990336920487ea1eee790358b Reviewed-on: https://chromium-review.googlesource.com/1047846 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#556506} [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_single_thread_task_runner_manager.h [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker.cc [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker.h [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_pool_impl.cc [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_stack_unittest.cc [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_unittest.cc [modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/task_scheduler_impl_unittest.cc
,
May 8 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAMM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 8 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAQM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 10 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAUM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 14 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAYM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 15 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAcM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
May 15 2018
@sullivan/benhenry (please add right folks for FindIt) : It's annoying that I keep getting these notifications a week later (I reverted r556169 within a few hours of it landing and its reland hasn't been causing flakes). It also means the infrastructure is doing useless churn work on already identified issue. I remember causing a DoS "attack" on bisect tools in Q1 when landing a CL that regressed performance so much that running the bisect itself was extremely slow, compound that with searching forever for an already identified issue and you have a lot of wasted resources...
,
May 18 2018
Sorry for the noise! I apologize for the spamming. There is a bug within Findit to NOT post bug updates when an analysis is RERUN. Assign this bug to lijeffrey@ to follow up as he used this flake to rerun the flake analysis because this one could complete very quickly.
,
May 18 2018
,
May 18 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAkM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
,
Jun 19 2018
Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGA0M If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20TaskSchedulerImplTest.IdentifiableStacks&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGA0M Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by Findit
, May 5 2018