New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840050 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: TaskSchedulerImplTest.IdentifiableStacks

Blocked on:
issue 840429



Sign in to add a comment

TaskSchedulerImplTest.IdentifiableStacks is Flaky

Project Member Reported by Findit, May 5 2018

Issue description

Project Member

Comment 1 by Findit, May 5 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Linux Tests"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyngELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJoY2hyb21pdW0ubGludXgvTGludXggVGVzdHMvNjk3MjkvYmFzZV91bml0dGVzdHMvVkdGemExTmphR1ZrZFd4bGNrbHRjR3hVWlhOMExrbGtaVzUwYVdacFlXSnNaVk4wWVdOcmN3PT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Project Member

Comment 2 by Findit, May 5 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Linux Tests (dbg)(1)(32)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyqwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ1Y2hyb21pdW0ubGludXgvTGludXggVGVzdHMgKGRiZykoMSkoMzIpLzQ5ODUzL2Jhc2VfdW5pdHRlc3RzL1ZHRnphMU5qYUdWa2RXeGxja2x0Y0d4VVpYTjBMa2xrWlc1MGFXWnBZV0pzWlZOMFlXTnJjdz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Project Member

Comment 3 by Findit, May 5 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Labels: -Sheriff-Chromium
Owner: gab@chromium.org
Status: Assigned (was: Available)
r556169 has been reverted at https://chromium-review.googlesource.com/c/chromium/src/+/1045747.

Assigning gab@ for followup.

Comment 5 by gab@chromium.org, May 7 2018

Blockedon: 840429

Comment 6 by gab@chromium.org, May 7 2018

Status: Fixed (was: Assigned)
This was caused by issue 840429 I believe, I'll reland with tests disabled on POSIX.
Project Member

Comment 7 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2419c13b0a7a1c43d9aeef8804266c923c0191

commit be2419c13b0a7a1c43d9aeef8804266c923c0191
Author: Gabriel Charette <gab@chromium.org>
Date: Mon May 07 18:32:11 2018

Reland "[TaskScheduler] Label SchedulerWorker threads stacks with an identifying frame"

This is a reland of 5b0cb536a073784425e1ba4e1fa594aefb58bebe

It was reverted @ r556169 because the tests were flaky on POSIX.
I believe the instability is in base::debug::StackTrace().Print().

This reland excludes the tests on POSIX. The logic is cross-platform
and the tests on Windows prove it works. I will investigate POSIX
separately in crbug.com/840429


Original change's description:
> [TaskScheduler] Label SchedulerWorker threads stacks with an identifying frame
>
> I intentionally didn't add "Foreground" to non "Background" workers as
> they may be used for background tasks in some configurations and I don't
> want it to be confusing for developers.
>
> R=fdoray@chromium.org
>
> Bug:  839525 
> Change-Id: I8c1e928914aa6d2e35fedc1db4e8a639d39116b2
> Reviewed-on: https://chromium-review.googlesource.com/1044501
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#556169}

TBR=fdoray@chromium.org

Bug:  839525 ,  840050 , 840429
Change-Id: Id1ee52a52483717990336920487ea1eee790358b
Reviewed-on: https://chromium-review.googlesource.com/1047846
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556506}
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_single_thread_task_runner_manager.h
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker.h
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_pool_impl.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_stack_unittest.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/scheduler_worker_unittest.cc
[modify] https://crrev.com/be2419c13b0a7a1c43d9aeef8804266c923c0191/base/task_scheduler/task_scheduler_impl_unittest.cc

Project Member

Comment 8 by Findit, May 8 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAMM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Project Member

Comment 9 by Findit, May 8 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAQM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Project Member

Comment 10 by Findit, May 10 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAUM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Project Member

Comment 11 by Findit, May 14 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAYM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Project Member

Comment 12 by Findit, May 15 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAcM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Comment 13 by gab@chromium.org, May 15 2018

Cc: benhenry@chromium.org sullivan@chromium.org
@sullivan/benhenry (please add right folks for FindIt) :

It's annoying that I keep getting these notifications a week later (I reverted r556169 within a few hours of it landing and its reland hasn't been causing flakes).

It also means the infrastructure is doing useless churn work on already identified issue.

I remember causing a DoS "attack" on bisect tools in Q1 when landing a CL that regressed performance so much that running the bisect itself was extremely slow, compound that with searching forever for an already identified issue and you have a lot of wasted resources...

Comment 14 by st...@chromium.org, May 18 2018

Cc: -sullivan@chromium.org -benhenry@chromium.org
Owner: lijeffrey@chromium.org
Sorry for the noise! I apologize for the spamming.
There is a bug within Findit to NOT post bug updates when an analysis is RERUN.

Assign this bug to lijeffrey@ to follow up as he used this flake to rerun the flake analysis because this one could complete very quickly.

Comment 15 by st...@chromium.org, May 18 2018

Components: -Tests>Flaky Tools>Test>FindIt>Flakiness
Project Member

Comment 16 by Findit, May 18 2018

Findit identified the culprit r556169 with confidence 100.0% in the config "chromium.linux / Cast Audio Linux"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyowELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJtY2hyb21pdW0ubGludXgvQ2FzdCBBdWRpbyBMaW51eC8xMDM3My9iYXNlX3VuaXR0ZXN0cy9WR0Z6YTFOamFHVmtkV3hsY2tsdGNHeFVaWE4wTGtsa1pXNTBhV1pwWVdKc1pWTjBZV05yY3c9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAkM


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Sign in to add a comment