New issue
Advanced search Search tips

Issue 840044 link

Starred by 3 users
Status: Assigned
Owner:
robliao@chromium.org
Cc:
julien.isorce@chromium.org
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MediaStreamUIProxy is destroyed before task replying on OSX

Project Member Reported by braveyao@chromium.org, May 5 2018 
Chrome Version: M67 and onwards
OS: MacOSX

What steps will reproduce the problem?
(1) Start Chrome Canary on Mac OSX
(2) Join a Hangout meeting
(3) Start to present a screen

What is the expected result?
The screen capture notification bar won't be captured and shown at peer

What happens instead?
The screen capture notification bar is captured and shown at peer


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

This is a regress, which doesn't happen in Stable M66.

Comment 1 by braveyao@chromium.org, May 5 2018

Cc: julien.isorce@chromium.org
Owner: robliao@chromium.org
The problem is in MediaStreamUIProxy::OnStarted(), https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_stream_ui_proxy.cc?l=239. 
When we post a task and wait for reply, the MediaStreamUIProxy is destroyed before the reply. So MediaStreamUIProxy::OnWindowId() is not called.

The offending cl is https://chromium-review.googlesource.com/c/chromium/src/+/932014.

robliao@, please take a look.

Comment 2 by robliao@chromium.org, May 30 2018

Labels: Proj-MacViews

Comment 3 by robliao@chromium.org, Jul 21

Labels: Group-Views_Regressions_from_Cocoa
►

Sign in to add a comment