Modify 'atest host' to accept '--skylab'. When '--skylab' is provided, 'atest' should interact with the skylab inventory instead of the AFE DB.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/68c4edffbc015ba644504f67b98172b47f205834 commit 68c4edffbc015ba644504f67b98172b47f205834 Author: Ningning Xia <nxia@google.com> Date: Wed May 09 21:43:34 2018 Change DeviceLock proto Remove bool lock: a device_lock object means it's locked. Add lock_id: when users want to clean a lock, they need to provide the lock_id. BUG= chromium:840039 TEST=None Change-Id: I43d067c0151cfb035ca34b1d43326bd7efe2e9b4 Reviewed-on: https://chromium-review.googlesource.com/1050912 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/68c4edffbc015ba644504f67b98172b47f205834/venv/skylab_inventory/protos/device_pb2.py [modify] https://crrev.com/68c4edffbc015ba644504f67b98172b47f205834/protos/device.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/44acea10664c405a20c4d37656b920b7029d9025 commit 44acea10664c405a20c4d37656b920b7029d9025 Author: Ningning Xia <nxia@google.com> Date: Thu May 10 01:20:19 2018 Add device lib. BUG= chromium:840039 TEST=None Change-Id: I7588d786fab10c6ee397903eb884b2f179ce4902 Reviewed-on: https://chromium-review.googlesource.com/1045685 Reviewed-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Trybot-Ready: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/44acea10664c405a20c4d37656b920b7029d9025/venv/skylab_inventory/translation_utils.py [add] https://crrev.com/44acea10664c405a20c4d37656b920b7029d9025/venv/skylab_inventory/lib/device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/10b40725ff07a15e90076c8c641f9c8b1bed5f11 commit 10b40725ff07a15e90076c8c641f9c8b1bed5f11 Author: Ningning Xia <nxia@google.com> Date: Tue May 15 23:59:38 2018 Fix the logic of checking whether a device is locked. DeviceLock.lock flag was deprecated. Check whether a device is locked by looking at the length of device.common.device_locks. BUG= chromium:840039 TEST=bin/print_dut_state Change-Id: Ia0bcbc2f48d61d30f6232d8bb37324103e7d538e Reviewed-on: https://chromium-review.googlesource.com/1058182 Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/10b40725ff07a15e90076c8c641f9c8b1bed5f11/venv/skylab_inventory/lib/device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/8ddef6a1b51136d9d66ab66fe256cf07917a2750 commit 8ddef6a1b51136d9d66ab66fe256cf07917a2750 Author: Ningning Xia <nxia@google.com> Date: Wed May 16 00:02:28 2018 Convert device objects to printable autotest hosts. BUG= chromium:840039 TEST=bin/print_servers Change-Id: I0709b895939d4857fca00397b5dd45b3c6e00330 Reviewed-on: https://chromium-review.googlesource.com/1056190 Reviewed-by: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/8ddef6a1b51136d9d66ab66fe256cf07917a2750/venv/skylab_inventory/translation_utils.py [modify] https://crrev.com/8ddef6a1b51136d9d66ab66fe256cf07917a2750/venv/skylab_inventory/lib/device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/a922b5c97ca82c132f96145a2ac877c36a2ade43 commit a922b5c97ca82c132f96145a2ac877c36a2ade43 Author: Ningning Xia <nxia@google.com> Date: Thu May 17 19:54:58 2018 Deprecate int lock_id and add string id. BUG= chromium:840039 TEST=None Change-Id: If889dacd8b37aefdb93c0bf9f3fb6ad597ba7804 Reviewed-on: https://chromium-review.googlesource.com/1064706 Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/a922b5c97ca82c132f96145a2ac877c36a2ade43/venv/skylab_inventory/protos/device_pb2.py [modify] https://crrev.com/a922b5c97ca82c132f96145a2ac877c36a2ade43/protos/device.proto
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ea02ab13341877bd6bb93c8e2e56e23457638290 commit ea02ab13341877bd6bb93c8e2e56e23457638290 Author: Ningning Xia <nxia@google.com> Date: Fri May 18 05:21:15 2018 Support 'atest host list' with '--skylab' BUG= chromium:840039 TEST=manually run 'atest host list --skylab' Change-Id: I7ed6cf2b3c9b8ab0ec87fb20641df1c05296e245 Reviewed-on: https://chromium-review.googlesource.com/1045495 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/ea02ab13341877bd6bb93c8e2e56e23457638290/cli/topic_common.py [modify] https://crrev.com/ea02ab13341877bd6bb93c8e2e56e23457638290/cli/host.py [modify] https://crrev.com/ea02ab13341877bd6bb93c8e2e56e23457638290/cli/skylab_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5aaca4a449a5fa2e60330ec40724c494be761f54 commit 5aaca4a449a5fa2e60330ec40724c494be761f54 Author: Ningning Xia <nxia@google.com> Date: Fri May 18 17:05:18 2018 atest: add an option to set logging level. BUG= chromium:840039 TEST=run atest Change-Id: I533feaa6fb99bd8237435f1bdcd36d92a9a54ede Reviewed-on: https://chromium-review.googlesource.com/1062731 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/5aaca4a449a5fa2e60330ec40724c494be761f54/cli/topic_common.py [modify] https://crrev.com/5aaca4a449a5fa2e60330ec40724c494be761f54/cli/topic_common_unittest.py [modify] https://crrev.com/5aaca4a449a5fa2e60330ec40724c494be761f54/cli/server.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/627626468e490524383ee961125ebf0612a7e010 commit 627626468e490524383ee961125ebf0612a7e010 Author: Ningning Xia <nxia@google.com> Date: Fri May 18 19:06:07 2018 Add device lib methods to modify device. BUG= chromium:840039 TEST='atest host mod --skylab' Change-Id: I8e01af0ec9cff77fb840bb30c381fcc6555ea569 Reviewed-on: https://chromium-review.googlesource.com/1063124 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/627626468e490524383ee961125ebf0612a7e010/venv/skylab_inventory/translation_utils.py [modify] https://crrev.com/627626468e490524383ee961125ebf0612a7e010/venv/skylab_inventory/lib/device.py [modify] https://crrev.com/627626468e490524383ee961125ebf0612a7e010/venv/skylab_inventory/text_manager.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/f8a08ebfc52cbd63fbbb6e6a5b69903fab2d26db commit f8a08ebfc52cbd63fbbb6e6a5b69903fab2d26db Author: Ningning Xia <nxia@google.com> Date: Fri May 18 19:26:18 2018 Verify labels in convert_to_label_map. 1) renmae get_label_map and verify labels in convert_to_label_map. 2) change lib/device methods to take label_map instead of label_list. BUG= chromium:840039 TEST='atest host --skylab' with '-l' Change-Id: Ib236f27ec05356b937ef5979b83833690c993c96 Reviewed-on: https://chromium-review.googlesource.com/1063165 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/f8a08ebfc52cbd63fbbb6e6a5b69903fab2d26db/venv/skylab_inventory/lib/device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/c4d11685ba34c794370cfca3099c92ba5b731612 commit c4d11685ba34c794370cfca3099c92ba5b731612 Author: Ningning Xia <nxia@google.com> Date: Fri May 18 19:26:19 2018 Add device lib methods to create device. BUG= chromium:840039 TEST='atest host create --skylab' Change-Id: I057a89c9617e713f0567b8e839204b9912a201e2 Reviewed-on: https://chromium-review.googlesource.com/1063311 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/c4d11685ba34c794370cfca3099c92ba5b731612/venv/skylab_inventory/translation_utils.py [modify] https://crrev.com/c4d11685ba34c794370cfca3099c92ba5b731612/venv/skylab_inventory/lib/device.py [modify] https://crrev.com/c4d11685ba34c794370cfca3099c92ba5b731612/venv/skylab_inventory/text_manager.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/c1e867d38e574d31bc3ffda030a41a2e07e402df commit c1e867d38e574d31bc3ffda030a41a2e07e402df Author: Ningning Xia <nxia@google.com> Date: Sat May 19 00:32:38 2018 Add device lib method to delete device. BUG= chromium:840039 TEST='atest host delete --skylab' Change-Id: I9a714217cc9c5f9cf1fcad634dc6eb2d9057cfa1 Reviewed-on: https://chromium-review.googlesource.com/1065069 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/c1e867d38e574d31bc3ffda030a41a2e07e402df/venv/skylab_inventory/lib/device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ef35cb53f92200c964eda241903900d969880e1e commit ef35cb53f92200c964eda241903900d969880e1e Author: Ningning Xia <nxia@google.com> Date: Sat May 19 00:39:59 2018 Support 'atest host mod' with '--skylab' BUG= chromium:840039 TEST='atest host mod --skylab' CQ-DEPEND=CL:1063124 Change-Id: Iad6a6350ce7771b0257eaa19a653635bfd6bdbbd Reviewed-on: https://chromium-review.googlesource.com/1062942 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/ef35cb53f92200c964eda241903900d969880e1e/client/common_lib/revision_control.py [modify] https://crrev.com/ef35cb53f92200c964eda241903900d969880e1e/cli/host.py [modify] https://crrev.com/ef35cb53f92200c964eda241903900d969880e1e/cli/server.py [modify] https://crrev.com/ef35cb53f92200c964eda241903900d969880e1e/cli/skylab_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/64ced00e42a6a2f12e3bfdc3f9e3c9276107cbe5 commit 64ced00e42a6a2f12e3bfdc3f9e3c9276107cbe5 Author: Ningning Xia <nxia@google.com> Date: Sat May 19 00:40:17 2018 Verify and convert labels in option parser. Verify labels, convert label list to label map, and raise errors if necessary earlier. This allows label verification without cloning skylab_inventory. BUG= chromium:840039 TEST='atest host --skylab' with '-l' CQ-DEPEND=CL:1063165 Change-Id: I7a3d2495e297bcf83d581f438d855ef9a7662c7d Reviewed-on: https://chromium-review.googlesource.com/1063172 Tested-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/64ced00e42a6a2f12e3bfdc3f9e3c9276107cbe5/cli/host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/73868fbbab1ce8165f2fe04b3833e46376c6e6dc commit 73868fbbab1ce8165f2fe04b3833e46376c6e6dc Author: Ningning Xia <nxia@google.com> Date: Sat May 19 00:40:37 2018 Support 'atest host create' with --skylab. BUG= chromium:840039 TEST='atest host create --skylab' CQ-DEPEND=CL:1063311 Change-Id: Ic935c93a449787ad42ca71aac194a921a947a52c Reviewed-on: https://chromium-review.googlesource.com/1063313 Commit-Queue: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/73868fbbab1ce8165f2fe04b3833e46376c6e6dc/cli/host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c8b430d021c0de9c29e40d9dd68918c7ee10fdc4 commit c8b430d021c0de9c29e40d9dd68918c7ee10fdc4 Author: Ningning Xia <nxia@google.com> Date: Mon May 21 22:18:14 2018 Support 'atest host delete' with '--skylab' BUG= chromium:840039 TEST='atest host delete --skylab' CQ-DEPEND=CL:1065069 Change-Id: Ia3d3e2ba3f9b3e72a7797d765c3e55088ec0c2d6 Reviewed-on: https://chromium-review.googlesource.com/1065072 Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/c8b430d021c0de9c29e40d9dd68918c7ee10fdc4/cli/host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5c0e8f3bf2b959b3b6160df797b962f1fc0a6f9a commit 5c0e8f3bf2b959b3b6160df797b962f1fc0a6f9a Author: Ningning Xia <nxia@google.com> Date: Wed May 30 00:15:23 2018 Disable "--skylab" for "atest host create". 1) do not allow "--skylab" with "host create". 2) do not allow "--unlock-lock-id" with "host create". BUG= chromium:840039 TEST="atest host create" Change-Id: I54c869270dd161c19ba1822a1354d10fa3da9af6 Reviewed-on: https://chromium-review.googlesource.com/1068200 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/5c0e8f3bf2b959b3b6160df797b962f1fc0a6f9a/cli/host.py
Comment 1 by ayatane@chromium.org
, May 7 2018