[BlinkGenPropertyTrees] Composited reflection is not positioned properly |
||
Issue descriptionDon't know why. Reflection are drawn, but at a wrong position. Related to filter origin maybe?
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6279876c5327a08c7d157942733db7c4b1f6a9f commit d6279876c5327a08c7d157942733db7c4b1f6a9f Author: Tien-Ren Chen <trchen@chromium.org> Date: Fri May 18 20:16:22 2018 [BlinkGenPropertyTrees] Fix composited reflection transform space This CL sets transform space of a render surface if a filter is present (otherwise by default we always draw in device space). Effects that move pixels are sensitive to the space used, for example, blur filter and reflection. Before this CL those effects would be applied in the wrong space. BUG= 840038 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iebbf2e09faa79179a7a5534a71981ce563540e47 Reviewed-on: https://chromium-review.googlesource.com/1060617 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#560005} [modify] https://crrev.com/d6279876c5327a08c7d157942733db7c4b1f6a9f/cc/trees/draw_property_utils.cc [modify] https://crrev.com/d6279876c5327a08c7d157942733db7c4b1f6a9f/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/d6279876c5327a08c7d157942733db7c4b1f6a9f/third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
,
May 25 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, May 7 2018