Issue metadata
Sign in to add a comment
|
Cast dialog is sometimes blank on Mac |
||||||||||||||||||||||||
Issue descriptionInitially reported at b/78972913. c#2 in the bug thread contains a video. Once every 10~20 times, while Casting, the Cast dialog is completely blank when it is opened. This is observed only on Mac. According to David's bisect in the buganizer bug, crrev.com/c/1011556 is the cause. Chris, could you take a look?
,
May 4 2018
Thanks. Please note that the culprit CLs are different.
,
May 4 2018
Oh. Thank you. I suspect when I fix one I'll end up fixing both. But I'll make sure to carefully check that.
,
May 13 2018
I'm removing the dupe as this is a separate bug. To reproduce this, you need to have not dismissed the Cast dialog's tutorial. If you have already dismissed it with the "OK Got It" button, you can effectively reset the tutorial with: $ out/Release/Chromium.app/Contents/MacOs/Chromium --user-data-dir=/tmp/aodjgw or whatever random subdir This repros about 1 in 10 runs.
,
May 14 2018
Applying M68 stable blocker label per comment in - https://bugs.chromium.org/p/chromium/issues/detail?id=840006#c26.
,
May 14 2018
In my case (68.0.3427.0 Canary), I can reproduce this only when there is no welcome message. When the welcome message is there, the resize to show the welcome message makes the dialog transition away from the blank state.
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b12316377b002c950e028ab69d31bc0c2000d4 commit e7b12316377b002c950e028ab69d31bc0c2000d4 Author: Chris Blume <cblume@chromium.org> Date: Mon May 14 20:09:04 2018 Revert child allocation in M67. This reverts commit 760b946849da9bd7a638418a762712f678a2e017. In M67 we hit a bug where a child allocation might not be presented unless it also has a resize event. This reverts child allocation and returns to a well-tested state. Bug: 840036 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I17546bb8ccd01318be6e88aa69bbeef3d3ade56a Reviewed-on: https://chromium-review.googlesource.com/1058124 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#595} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/components/viz/common/surfaces/child_local_surface_id_allocator.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/components/viz/common/surfaces/parent_local_surface_id_allocator.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/frame_host/render_widget_host_view_guest.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/frame_host/render_widget_host_view_guest.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/browser_compositor_view_mac.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/browser_compositor_view_mac.mm [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_delegate.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_base.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_child_frame_browsertest.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_mac.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/renderer_host/render_widget_host_view_mac.mm [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/common/view_messages.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/renderer/render_view_impl.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/renderer/render_widget.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/renderer/render_widget.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/renderer/render_widget_unittest.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/test/mock_render_widget_host_delegate.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/content/test/mock_render_widget_host_delegate.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/local/window_port_local.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/local/window_port_local.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/mus/window_port_mus.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/window.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/window.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/window_port.h [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/window_port_for_shutdown.cc [modify] https://crrev.com/e7b12316377b002c950e028ab69d31bc0c2000d4/ui/aura/window_port_for_shutdown.h
,
May 15 2018
I definitely tagged the wrong bug in that CL. It was supposed to go to http://crbug.com/840006 This issue is not yet fixed / merged. Sorry about that.
,
May 15 2018
I was able to repro a potentially different bug then. I just tried again. On the 58th attempt I hit a bug. But it isn't a pure-white dialog. Instead, it was like the other bug where only a dot and the header is shown. Interestingly, I was sure to repro with the tutorial on. The tutorial wasn't yet displayed when the bug reproed. I also was unable to repro with the tutorial off after 100 tries. Maybe Fady's patch fixed the white, tutorial off bug. And maybe there is a separate dot, tutorial on bug?
,
May 16 2018
On 68.0.3432.0, I'm no longer able to repro this bug after 100 tries. If Fady's patch landed between that and 68.0.3427.0, then it may have fixed it.
,
May 18 2018
To be clear, you were unable to repro the no-tutorial bug, right? I think a tutorial-on bug exists.
,
May 18 2018
Right, with the welcome message closed, I wasn't able to repro the blank dialog bug. I just opened the dialog with the welcome message 20 times, and was able to repro what I think is the same as the dot bug you mentioned in c#9, shown in the attached screenshot.
,
May 22 2018
The blank dialog bug is back (or never fixed?) in Canary 68.0.3437.2. It reproduces 10/10 on some sessions and 0/10 on others, so it may be affected by a finch experiment. It reproduces regardless of the values for secoundary-ui-md and views-browser-windows though, so those flags aren't the culprit. There also is another bug in Canary that's new to me, in which only the top part of the dialog is drawn, although the rest is still clickable. Please see the screenshot for this one.
,
May 29 2018
+takumif can you mark this as a mac views blocker to make sure it gets looked at before that ships
,
Jun 12 2018
takumif@, Please check the issue on latest chrome versions 69.0.3455.0/68.0.3440.17 on Mac ,if still issue persists please update the bug as per C#14. Thanks..!
,
Jun 12 2018
I'm no longer able to reproduce this locally. Either way, per c#13, this shouldn't be related to MacViews. David, have you recently seen this issue on M68?
,
Jun 14 2018
No longer repros.
,
Jun 14 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
Jun 18 2018
Seems like there isn't any merge required to M68, correct?
,
Jun 18 2018
Right. Removing the Merge-TBD label. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by cblume@chromium.org
, May 4 2018Status: Duplicate (was: Assigned)