New issue
Advanced search Search tips

Issue 840032 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 834385



Sign in to add a comment

fontconfig: failed to build with glibc 2.27

Project Member Reported by yunlian@chromium.org, May 4 2018

Issue description

With glibc 2.27, I got the following error when building fontconfig

In file included from /var/tmp/portage/media-libs/fontconfig-2.11.1-r23/work/fontconfig-2.11.1/src/fcmatch.c:287:
/var/tmp/portage/media-libs/fontconfig-2.11.1-r23/work/fontconfig-2.11.1/src/fcobjs.h:54:1: error: use of undeclared identifier 'PRI_CHAR_WIDTH_STRONG'

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1eb617f50953366ee704bc218830916360854ac5

commit 1eb617f50953366ee704bc218830916360854ac5
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue May 08 03:46:01 2018

fontconfig: make it builds with glibc 2.27

This backports an upstream patch to avoid the conflicts with integer
width macros.

The commit message ws
Author: Khem Raj <raj.khem@gmail.com>
Date:   Wed Dec 14 16:11:05 2016 -0800

    Avoid conflicts with integer width macros from TS 18661-1:2014

    glibc 2.25+ has now defined these macros in <limits.h>
    https://sourceware.org/git/?p=glibc.git;a=commit;h=5b17fd0da62bf923cb61d1bb7b08cf2e1f1f9c1a

    Create an alias for FC_CHAR_WIDTH for ABI compatibility

    Signed-off-by: Khem Raj <raj.khem@gmail.com>

BUG= chromium:840032 
TEST=fontconfig builds with glibc 2.27

Change-Id: Ib12c68a772fc7e36902b87b064a8936d1df0080e
Reviewed-on: https://chromium-review.googlesource.com/1045899
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/1eb617f50953366ee704bc218830916360854ac5/media-libs/fontconfig/files/fontconfig-2.11.1-glibc2-26.patch
[rename] https://crrev.com/1eb617f50953366ee704bc218830916360854ac5/media-libs/fontconfig/fontconfig-2.11.1-r24.ebuild
[modify] https://crrev.com/1eb617f50953366ee704bc218830916360854ac5/media-libs/fontconfig/fontconfig-2.11.1-r1.ebuild

Status: Fixed (was: Untriaged)

Sign in to add a comment