Implement an dialog that will block Chrome startup due to policy.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bd16e326cef9324ccb097a975918440b5cb12b8 commit 7bd16e326cef9324ccb097a975918440b5cb12b8 Author: Owen Min <zmin@chromium.org> Date: Mon May 14 22:37:15 2018 Add the enterprise startup dialog The dialog will be displayed during Chrome launch if it's blocked by network request. screenshot: https://drive.google.com/open?id=1v4nbbCyY5mo6yTffelxjGhhg-vwYJOrv https://drive.google.com/open?id=1qigP2YSjQNhuzbWtLDfIZZO5Jyoxy91u Bug: 840018 Change-Id: I95f07bc68ef0837d071004598d0473719e2cb528 Reviewed-on: https://chromium-review.googlesource.com/1045548 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558497} [modify] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/chromium_strings.grd [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/chromium_strings_grd/IDS_ENTERPRISE_STARTUP_CANCEL_BUTTON.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/chromium_strings_grd/IDS_ENTERPRISE_STARTUP_CLOUD_POLICY_ENROLLMENT_ERROR.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/chromium_strings_grd/IDS_ENTERPRISE_STARTUP_CLOUD_POLICY_ENROLLMENT_TOOLTIP.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/chromium_strings_grd/IDS_ENTERPRISE_STARTUP_RELAUNCH_BUTTON.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/chromium_strings_grd/OWNERS [modify] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings.grd [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings_grd/IDS_ENTERPRISE_STARTUP_CANCEL_BUTTON.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings_grd/IDS_ENTERPRISE_STARTUP_CLOUD_POLICY_ENROLLMENT_ERROR.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings_grd/IDS_ENTERPRISE_STARTUP_CLOUD_POLICY_ENROLLMENT_TOOLTIP.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings_grd/IDS_ENTERPRISE_STARTUP_RELAUNCH_BUTTON.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings_grd/IDS_PRODUCT_LOGO_ENTERPRISE_ALT_TEXT.png.sha1 [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/app/google_chrome_strings_grd/OWNERS [modify] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/browser/ui/BUILD.gn [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/browser/ui/enterprise_startup_dialog.h [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/browser/ui/views/policy/enterprise_startup_dialog_view.cc [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/browser/ui/views/policy/enterprise_startup_dialog_view.h [add] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/browser/ui/views/policy/enterprise_startup_dialog_view_browsertest.cc [modify] https://crrev.com/7bd16e326cef9324ccb097a975918440b5cb12b8/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/485f15a7eb98e660412631cb2c62af0d423752e7 commit 485f15a7eb98e660412631cb2c62af0d423752e7 Author: Owen Min <zmin@chromium.org> Date: Thu May 17 17:27:08 2018 Remove title bar on Mac for enterprise startup dialog. Set the dialog type to ui::MODAL_TYPE_NONE as the dialog does not belong to any browser window and ui::MODAL_TYPE_SYSTEM is not supported in Mac. Screenshot: Before: https://drive.google.com/open?id=1KhKYST3mBwMpCOZ3r4p2TuhOopplENn- After: https://drive.google.com/open?id=1RX9RdaAW_mDiEqH2LYTyzocbH17bREmO Bug: 840018 Change-Id: I7e7cf14e3e934cafe5c4ca6b814617987cd41b10 Reviewed-on: https://chromium-review.googlesource.com/1060026 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#559588} [modify] https://crrev.com/485f15a7eb98e660412631cb2c62af0d423752e7/chrome/browser/ui/views/policy/enterprise_startup_dialog_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac commit 9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac Author: Owen Min <zmin@chromium.org> Date: Wed May 30 23:44:14 2018 Tuning EnterpriseStartupDialog Adjust the dialog based on UI review. 1) Align the enterprise logo with the head of button instead of tail. 2) Append "..." into the launching information. 3) Using close button instead of cancel button. Bug: 840018 Change-Id: I5689eceef9ad9b9061d5e4a3d1e314456704b6a2 Reviewed-on: https://chromium-review.googlesource.com/1072207 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563067} [modify] https://crrev.com/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac/chrome/app/chromium_strings.grd [modify] https://crrev.com/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac/chrome/browser/ui/enterprise_startup_dialog.h [modify] https://crrev.com/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac/chrome/browser/ui/views/policy/enterprise_startup_dialog_view.cc [modify] https://crrev.com/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac/chrome/browser/ui/views/policy/enterprise_startup_dialog_view.h [modify] https://crrev.com/9ad9c75bf5a90fa025c066c8d11274d5e6eaa1ac/chrome/browser/ui/views/policy/enterprise_startup_dialog_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a15c633eef5291e5ab651caac3bca89a8bb0fba commit 6a15c633eef5291e5ab651caac3bca89a8bb0fba Author: Owen Min <zmin@chromium.org> Date: Thu May 31 22:11:08 2018 Make the Chrome launch process wait for policy enrollment. If the device needs to enroll the machine level user cloud policy, showing EnterpriseStartupDialog until the enrollment is finshed before showing Chrome browser window. Show error information if enrollment failed. User could choose to relaunch Chrome to retry or close Chrome. Bug: 840018 Change-Id: I9f7a88e70d57ef032ca65c3bad9bd1d560c7344d Reviewed-on: https://chromium-review.googlesource.com/1054693 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#563394} [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/BUILD.gn [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/policy/chrome_browser_policy_connector.cc [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/policy/chrome_browser_policy_connector.h [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/policy/cloud/machine_level_user_cloud_policy_browsertest.cc [add] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.cc [add] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher.h [add] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/browser/policy/machine_level_user_cloud_policy_register_watcher_unittest.cc [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/common/chrome_result_codes.h [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/chrome/test/BUILD.gn [modify] https://crrev.com/6a15c633eef5291e5ab651caac3bca89a8bb0fba/tools/metrics/histograms/enums.xml
Comment 1 by bugdroid1@chromium.org
, May 14 2018