New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 840013 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Gaia window from views-based login has version on top right in dev/test image

Project Member Reported by xiy...@chromium.org, May 4 2018

Issue description

See attached screenshot.

We probably want to get rid of that. And if want to show it, it should show by views login code on top right of the screen.
 
views_login_gaia.png
163 KB View Download
Issue 841078 has been merged into this issue.
Labels: -M-68 M-69
Labels: ReleaseBlock-Beta
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a257468835309b4f3d2efbe093d8226c46f6f82e

commit a257468835309b4f3d2efbe093d8226c46f6f82e
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Tue Jun 19 22:38:47 2018

Display version info in views login screen and hide it in gaia dialog

Bug:  840013 
Change-Id: I1e1e8a21144d2b1cdf62b40b33f7b16f8d157d98
Reviewed-on: https://chromium-review.googlesource.com/1106707
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568622}
[modify] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/login/lock/views_screen_locker.h
[add] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/login/mojo_version_info_dispatcher.cc
[add] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/login/mojo_version_info_dispatcher.h
[modify] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/a257468835309b4f3d2efbe093d8226c46f6f82e/ui/login/display_manager.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on M69 (10836.0.0, 69.0.3479.0).

Sign in to add a comment