New issue
Advanced search Search tips

Issue 839992 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove webstore widget app, and unused parts of webstoreWidgetPrivate API

Project Member Reported by tbarzic@chromium.org, May 4 2018

Issue description

Webstore widget app was used to show printer provider apps available in Chrome Webstore for attached USB printer.
Since its introduction, printer support has been updated, and the printer setup flow does not include launching the app anymore.
We should remove the unused component app code, and remove parts of webstoreWidgetPrivate API used exclusively by the app.

Note that some of the UI code used by the app is shared with Files app - this code should be moved from components/chrome_apps/webstore_widget/cws_widget to ui/file_manager/.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d85eec289ef7293f3660a038fa8012a54ab2e755

commit d85eec289ef7293f3660a038fa8012a54ab2e755
Author: Toni Barzic <tbarzic@google.com>
Date: Fri Oct 19 04:26:13 2018

Move cws_widget to file_manager

This code is currently shared between file_manager app and
webstore_widget app. The latter is not longer used and will be removed.
Given that file manager will becaume the only user of the widget
currently under components/chrome_apps/webstore_widget/cws_widget, move
this to ui/file_manager.
(This breaks webstore widget app, but as stated before, the app is no
longer used)

BUG= 839992 
TEST=Verify that installing new file system service in file manager
     works.

Change-Id: Ibe0778b2bb8ef075765ce864835751414baa8841
Reviewed-on: https://chromium-review.googlesource.com/c/1288076
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601052}
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/chrome/test/BUILD.gn
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/components/chrome_apps/webstore_widget/app/main.js
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/components/chrome_apps/webstore_widget_resources.grdp
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/BUILD.gn
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/app_installer.js
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/cws_webview_client.js
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/cws_widget_container.css
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/cws_widget_container.js
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/cws_widget_container_error_dialog.js
[rename] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/cws_widget/cws_widget_container_platform_delegate.js
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager/test/scripts/create_test_main.py
[modify] https://crrev.com/d85eec289ef7293f3660a038fa8012a54ab2e755/ui/file_manager/file_manager_resources.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29f273013a8f8b43433e695cd2d9f058c3e99f0f

commit 29f273013a8f8b43433e695cd2d9f058c3e99f0f
Author: Toni Barzic <tbarzic@google.com>
Date: Fri Oct 19 18:28:53 2018

Removing consts and extension APIs only used by Web Store Widget app

The app was used as a wrapper around Web Store Widget UI. The widget
provides way of displaying filtered list of extensions in Chrome Web
Store and is able to request an extension installation. The widget
itself is still used in Files app, but the Web Store Widget component
app, which was used to list printer provider extensions for a printer
when the printer gets plugged in is not used anymore
( https://crbug.com/734161 ), and can be removed.

This removes APIs specific to the Web Store Widget app, and stops
loading the app in component loader.

A CL that removes the app implementation itself will follow.

BUG= 839992 

Change-Id: I06a71ed1527ea41ac6b464c1cad1a7a7279e753f
Reviewed-on: https://chromium-review.googlesource.com/c/1289439
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601232}
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.cc
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/api/webstore_widget_private/webstore_widget_private_api.h
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/chrome_component_extension_resource_manager.cc
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/browser/extensions/component_loader.h
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/common/extensions/api/webstore_widget_private.idl
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/common/extensions/extension_constants.cc
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/chrome/common/extensions/extension_constants.h
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/components/chrome_apps/BUILD.gn
[delete] https://crrev.com/7297063c2296370ca43d4c1e13f687cea12c11f8/components/chrome_apps/chrome_apps_resource_util.cc
[delete] https://crrev.com/7297063c2296370ca43d4c1e13f687cea12c11f8/components/chrome_apps/chrome_apps_resource_util.h
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/29f273013a8f8b43433e695cd2d9f058c3e99f0f/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment