New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839988 link

Starred by 2 users
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[PIP] Video resolution changes resizes window and places back in position

Project Member Reported by apaci...@chromium.org, May 4 2018 
When the video resolution changes, the window is moved back to the original position on the screen (bottom right), and resized to the original expected size.

Example: https://mounirlamouri.github.io/bunny-player/index.html
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0189de8a2074fcfe88855c939404c100234fa0a

commit f0189de8a2074fcfe88855c939404c100234fa0a
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon May 14 21:46:02 2018

[Picture in Picture] Handle resizing to video resolution changes.

Currently, video resolution changes will send the Picture-in-Picture
window back to the original location (bottom right) with the original
size of 20% of the display.

This change will allow updating video resolution, but keep the window
in the same location and only resize to adhere to the aspect ratio.

BUG:  839988 
Change-Id: I58a21edeb11c1aa6b0338d381c245d75939e5a31
Reviewed-on: https://chromium-review.googlesource.com/1045268
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558480}
[modify] https://crrev.com/f0189de8a2074fcfe88855c939404c100234fa0a/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/f0189de8a2074fcfe88855c939404c100234fa0a/chrome/browser/ui/views/overlay/overlay_window_views.h

Comment 2 by apaci...@chromium.org, May 14 2018

Status: Fixed (was: Started)
►

Sign in to add a comment