Support extension scheme in shared workers |
|||||||||
Issue descriptionSimilar to bug 836129 , SharedWorkerScriptLoader needs to be able to use URLLoaderFactories from the embedder. ExtensionApiTest.Debugger fails because it has one case (discoverWorker) which loads a shared worker from an extension scheme. Matt: do you think you or someone from your time can take this?
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd91c73de09a6d6366eca672b6898ba1dc3bfd09 commit dd91c73de09a6d6366eca672b6898ba1dc3bfd09 Author: John Abd-El-Malek <jam@chromium.org> Date: Mon May 07 02:36:28 2018 Classify 2 extension tests that fail because shared workers can't load extension schemes. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9a74ae26c42cf2672d382d178da76f22f5758fb2 Reviewed-on: https://chromium-review.googlesource.com/1045555 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#556366} [modify] https://crrev.com/dd91c73de09a6d6366eca672b6898ba1dc3bfd09/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 7 2018
Thanks!
,
May 21 2018
I investigated a bit. It seems to me there are at least 3 places of missing plumbing. (1) SharedWorkerScriptLoaderFactory just has the direct network factory, so the shared worker's main script load will fail for chrome-extension://. (2) WorkerShadowPage::CreateURLLoaderFactory() is used for importScripts() for *uncontrolled* shared workers (as the ServiceWorkerNetworkProvider won't intercept the request). It uses a bare RendererBlinkPlatformImpl::CreateDefaultURLLoaderFactory(), which is a bundle made from a network and blob factory. So importScripts() will fail for chrome-extension:// for uncontrolled shared workers. (3) EmbeddedSharedWorkerStub::CreateServiceWorkerNetworkProvider() -> ServiceWorkerNetworkProvider::CreateForSharedWorker() makes the ServiceWorkerProviderContext with |fallback_factory| used when a *controlled* shared worker does importScripts() and the service worker falls back to network. This |fallback_factory| is a bare RendererBlinkPlatformImpl::CreateDefaultURLLoaderFactory() as above. So importScripts() will fail for chrome-extension:// for controlled shared workers when the service worker doesn't provide a response. So I think we in addition to adding the bundle to SharedWorkerScriptLoaderFactory for (1), we have to pass a bundle to SharedWorkerFactory::CreateSharedWorker() similar to CommitNavigation() for (2) and (3). (I don't think we have tests for all these, and I suspect off-main-thread importScripts will change this a bit...)
,
May 21 2018
Here is another probably related problem. In a CL where I disable file access in the network service, the following tests start failing: WorkerTest.MultipleSharedWorkers WorkerTest.PassMessagePortToSharedWorkerDontWaitForConnect WorkerTest.PassMessagePortToSharedWorker WorkerTest.SingleSharedWorker WorkerTest.SharedWorkerTlsClientAuthImportScripts If I understand these tests correctly, they create workers with file URLs but workers don't have a FileURLLoaderFactory and we fail to create the worker now that file access is removed. Do you think adding the bundle to SharedWorkerScriptLoaderFactory will help? (assuming just like for navigations we add a FileURLLoaderFactory to the bundle if the page creating the worker is loaded off a file URL)?
,
May 21 2018
,
May 21 2018
c#5: Sounds right, we probably also need to plumb it through spots (2) and (3) identified in c#4 in order for importScripts() to work also. However, file:// URLs are a bit weird and usually can't be used by the web. I think you need to use a flag like --allow-file-access-from-files. So unless those tests are trying to test file:// specifically, it'd probably be better if they are rewritten to not use such URLs.
,
May 22 2018
@Matt: how we plumb it for RenderFrames is that on commit we only pass in a mojo pipe to the FileURLLoaderFactory if the frame is on file:// already [1]. I presume we'd want to do the same thing for workers, to help with local testing. [1] https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?rcl=9c80c3e332e1f742e503a1d3c6cd7aec1dd5387c&l=3645
,
May 22 2018
Thanks for the pointer! Yes I agree we should do the same for workers. I didn't mean to say that file:// shouldn't be supported, just that it's odd all these basic tests are depending on the strange case of file://. Generally, it's looking like a chunk of code in RenderFrameHostImpl to make the subresource loaders and the restartable network loader needs to be reused somehow for shared workers. I'm still working on a patch for c#4.
,
May 22 2018
It's probably straightforward enough for me to change these tests to use the embedded server instead of using files as you suggested. I'll do that soon.
,
May 23 2018
Expanding this bug to include file:// as well.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96887d521041287e710dc1cec46d595f482ec987 commit 96887d521041287e710dc1cec46d595f482ec987 Author: Matt Falkenhagen <falken@chromium.org> Date: Wed May 23 10:15:40 2018 shared worker: Allow chrome-extension:// workers under NetworkService. This allows SharedWorkerScriptLoaderFactory to use non-NetworkService factories like for chrome-extension://. It allows loading such URLs for the main shared worker script. Remaining work is to add plumbing to Blink so that importScripts() also works. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I332ca96c8eef46771ca0ea7f290208642b2f82d0 Reviewed-on: https://chromium-review.googlesource.com/1068900 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561022} [modify] https://crrev.com/96887d521041287e710dc1cec46d595f482ec987/content/browser/shared_worker/shared_worker_script_loader.cc [modify] https://crrev.com/96887d521041287e710dc1cec46d595f482ec987/content/browser/shared_worker/shared_worker_script_loader.h [modify] https://crrev.com/96887d521041287e710dc1cec46d595f482ec987/content/browser/shared_worker/shared_worker_script_loader_factory.cc [modify] https://crrev.com/96887d521041287e710dc1cec46d595f482ec987/content/browser/shared_worker/shared_worker_script_loader_factory.h [modify] https://crrev.com/96887d521041287e710dc1cec46d595f482ec987/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/96887d521041287e710dc1cec46d595f482ec987/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79573b376b7242d8eb416e5cae697bcd684f16ab commit 79573b376b7242d8eb416e5cae697bcd684f16ab Author: Matt Falkenhagen <falken@chromium.org> Date: Thu May 24 08:31:28 2018 shared worker: Give the renderer a factory bundle when NetworkService is enabled. Similar to frames, the shared worker needs a factory bundle in order to load non-NetworkService URLs like chrome-extension://. This fixes the remaining test failure but we're still missing test coverage. I think the factory bundle needs to be propagated to ServiceWorkerSubresourceLoaderFactory for use with network fallback. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d Reviewed-on: https://chromium-review.googlesource.com/1069956 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561423} [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/browser/storage_partition_impl.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/public/platform/DEPS [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/public/platform/platform.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/79573b376b7242d8eb416e5cae697bcd684f16ab/third_party/blink/tools/audit_non_blink_usage.py
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8a6fa91b946a067652d0312b95d4073bc5eddc4 commit c8a6fa91b946a067652d0312b95d4073bc5eddc4 Author: Daniel Bratell <bratell@opera.com> Date: Thu May 24 12:04:47 2018 [jumbo] Fixing collision between wtf ntohs and Windows ntohs A recent change in blink added a dependency on services/network which indirectly use winsock2.h for htons a ntohs. Since blink uses its custom ntohs and htons for Windows, those clash. This changes so that blink also uses winsock2.h for htons, ntohs. Bug: 839982 Change-Id: I5bebce4e62227512da2c922dc41a564ce442f388 Reviewed-on: https://chromium-review.googlesource.com/1070973 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#561469} [modify] https://crrev.com/c8a6fa91b946a067652d0312b95d4073bc5eddc4/third_party/blink/renderer/platform/wtf/byte_order.h
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816 commit 4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816 Author: Trent Apted <tapted@chromium.org> Date: Fri May 25 01:40:14 2018 Revert "shared worker: Give the renderer a factory bundle when NetworkService is enabled." This reverts commit 79573b376b7242d8eb416e5cae697bcd684f16ab. Reason for revert: Suspect for msan failures starting https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7284 errors like =1==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x26931324 in is_empty ./../../base/unguessable_token.h:68:45 #1 0x26931324 in blink::IdentifiersFactory::IdFromToken(base::UnguessableToken const&) ./../../third_party/blink/renderer/core/inspector/identifiers_factory.cc:95:0 #2 0x26b81609 in blink::InspectorNetworkAgent::InspectorNetworkAgent(blink::InspectedFrames*, blink::WorkerGlobalScope*, v8_inspector::V8InspectorSession*) ./../../third_party/blink/renderer/core/inspector/inspector_network_agent.cc:1809:23 ... Uninitialized value was created by a heap allocation #0 0xac2699 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:45:35 #1 0x2e6764af in blink::WebSharedWorker::Create(blink::WebSharedWorkerClient*) ./../../third_party/blink/renderer/core/exported/web_shared_worker_impl.cc:392:27 #2 0x2ac0c8ea in content::EmbeddedSharedWorkerStub::EmbeddedSharedWorkerStub Original change's description: > shared worker: Give the renderer a factory bundle when NetworkService is enabled. > > Similar to frames, the shared worker needs a factory bundle in order to > load non-NetworkService URLs like chrome-extension://. > > This fixes the remaining test failure but we're still missing test > coverage. I think the factory bundle needs to be propagated to > ServiceWorkerSubresourceLoaderFactory for use with network fallback. > > Bug: 839982 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d > Reviewed-on: https://chromium-review.googlesource.com/1069956 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561423} TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org Change-Id: Iada07ec8bdddf612dbd441f702ede3dc8239ad21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1073007 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#561728} [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/browser/storage_partition_impl.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/public/platform/DEPS [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/public/platform/platform.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/4b40049fa3dcdb23f17d6ad82bd50d7dbc81d816/third_party/blink/tools/audit_non_blink_usage.py
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f904fcc9f834483e9a5a57d934b5d77636064657 commit f904fcc9f834483e9a5a57d934b5d77636064657 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri May 25 06:55:00 2018 Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." This relands r561423. Original code review: https://chromium-review.googlesource.com/1069956 The original patch had a problem because the shadow page was created before UnguessableToken. The fix is to not create the shadow page early, which was only needed in an earlier patchset to get the task runner from it. Bug: 839982 , 846545 Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1073037 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#561793} [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/browser/storage_partition_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/public/platform/DEPS [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/public/platform/platform.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/f904fcc9f834483e9a5a57d934b5d77636064657/third_party/blink/tools/audit_non_blink_usage.py
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a commit 2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a Author: Olga Sharonova <olka@chromium.org> Date: Fri May 25 09:14:33 2018 Revert "Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled."" This reverts commit f904fcc9f834483e9a5a57d934b5d77636064657. Reason for revert: Suspected of causing virtual/service-worker-servicification/external/wpt/service-workers/service-worker/worker-interception-redirect.https.html failures (example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32483) Original change's description: > Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." > > This relands r561423. > Original code review: https://chromium-review.googlesource.com/1069956 > > The original patch had a problem because the shadow page was created > before UnguessableToken. The fix is to not create the shadow page early, > which was only needed in an earlier patchset to get the task runner > from it. > > Bug: 839982 , 846545 > Change-Id: Id6545d9d86a3a56a04e7f83a840d9acddd55f51b > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > TBR: kinuko, dcheng > Reviewed-on: https://chromium-review.googlesource.com/1073037 > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561793} TBR=falken@chromium.org,dcheng@chromium.org,kinuko@chromium.org,nhiroki@chromium.org Change-Id: I56e491c5d74ee738c2ce6e530b7448319e14ab20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839982 , 846545 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1073248 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#561815} [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/browser/storage_partition_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/public/platform/DEPS [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/public/platform/platform.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/2d10a8a7b01a727e6692feb8e5f5ccbbf80a596a/third_party/blink/tools/audit_non_blink_usage.py
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7e6a5626720fc556b4159f5903780a0d364b845 commit d7e6a5626720fc556b4159f5903780a0d364b845 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri May 25 13:12:48 2018 Reland "shared worker: Give the renderer a factory bundle when NetworkService is enabled." This relands r561423 and r561793. Original code review: https://chromium-review.googlesource.com/1069956 Second code review: https://chromium-review.googlesource.com/1073037 This collided with the landing of the S13nSW virtual test suite. I'm relanding with an expectation for the S13nSW failure. Probably we're using NetworkService when S13nSW is on and NetworkService is off. Bug: 839982 , 846545 , 846637 Change-Id: Ib1c3122ee532cce56a040356433002a24edc5553 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR: nhiroki, kinuko, dcheng Reviewed-on: https://chromium-review.googlesource.com/1072991 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561844} [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/mock_shared_worker.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/mock_shared_worker.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_host_unittest.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_service_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/shared_worker/shared_worker_service_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/browser/storage_partition_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/common/shared_worker/shared_worker_factory.mojom [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/renderer_blink_platform_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/renderer_blink_platform_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/shared_worker_factory_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/content/renderer/shared_worker/shared_worker_factory_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/platform/DEPS [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/platform/platform.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/public/web/web_shared_worker.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/DEPS [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/web_shared_worker_impl.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/worker_shadow_page.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/core/exported/worker_shadow_page.h [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/modules/DEPS [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc [modify] https://crrev.com/d7e6a5626720fc556b4159f5903780a0d364b845/third_party/blink/tools/audit_non_blink_usage.py
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62628bf9be490104ecef351c24df1199f17779bb commit 62628bf9be490104ecef351c24df1199f17779bb Author: Matt Falkenhagen <falken@chromium.org> Date: Wed May 30 02:23:24 2018 shared worker: Add tests for Chrome extensions. We didn't have specific test coverage for shared worker from Chrome extensions, just incidental ones via the ExtensionApiTest.Debugger and ExtensionApiTestWithSwitch.ExtensionDebugger. Shared workers go through a very different loading path than other resources, so it's useful to have tests for them especially including interaction with service workers. This adds tests that currently fail with NetworkService, a next patch will have a fix. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifa6bb3dec8bdea34c3fbefbaeab324fadcb5c929 Bug: 839982 Reviewed-on: https://chromium-review.googlesource.com/1074848 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#562700} [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/browser/extensions/shared_worker_apitest.cc [modify] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/BUILD.gn [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/basic/background.js [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/basic/manifest.json [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/basic/worker-with-import.js [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/basic/worker.js [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/background.html [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/background.js [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/data_for_fetch [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/manifest.json [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/service_worker.js [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/shared_worker.js [add] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/chrome/test/data/extensions/api_test/shared_worker/service_worker_controlled/shared_worker_import.js [modify] https://crrev.com/62628bf9be490104ecef351c24df1199f17779bb/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4796a2aa76bfecbf0e268ab495cc8466406fece3 commit 4796a2aa76bfecbf0e268ab495cc8466406fece3 Author: Thiemo Nagel <tnagel@chromium.org> Date: Wed May 30 08:54:48 2018 Revert "shared worker: Add tests for Chrome extensions." This reverts commit 62628bf9be490104ecef351c24df1199f17779bb. Reason for revert: Speculative revert due to Linux ChromiumOS MSan Tests failures: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7fe3e82dacb0 in killpg ??:? #5 0x7fe3e82dacb0 in ?? ??:0 #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [9681:9681:0529/225648.292655:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9681:9709:0529/225648.491081:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9681:9709:0529/225648.491704:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [9681:9681:0529/225653.563139:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [9681:9764:0529/225653.719267:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [9681:9681:0529/225654.670750:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225657.293016:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225700.335612:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225703.324806:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225804.664156:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9681:9681:0529/225928.685288:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7f6d3333fcb0 in killpg ??:? #5 0x7f6d3333fcb0 in ?? ??:0 #6 0x7f6d334076d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 #44 0x7f6d3332af45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 #45 0x000000a511ba in _start ??:0:0 [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired [9971:9971:0529/225953.241021:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9971:9999:0529/225953.449328:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory ALSA lib confmisc.c:768:(parse_card) cannot find card '0' ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default [9971:9999:0529/225953.449892:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory [9971:9971:0529/225958.400556:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() [9971:10053:0529/225958.532493:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico [9971:9971:0529/225959.377349:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230002.227064:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230005.286414:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230008.209328:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230103.646916:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) [9971:9971:0529/230224.632095:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) BrowserTestBase received signal: Terminated. Backtrace: #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 #4 0x7f12d1488cb0 in killpg ??:? #5 0x7f12d1488cb0 in ?? ??:0 #6 0x7f12d15506d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/bro
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/610eddf7f6c6627857a3481495cb6f1da8ed0c29 commit 610eddf7f6c6627857a3481495cb6f1da8ed0c29 Author: Thiemo Nagel <tnagel@chromium.org> Date: Wed May 30 09:04:34 2018 Reland "shared worker: Add tests for Chrome extensions." This reverts commit 4796a2aa76bfecbf0e268ab495cc8466406fece3. Reason for revert: The test failure is a flake. I should have checked before. :( Original change's description: > Revert "shared worker: Add tests for Chrome extensions." > > This reverts commit 62628bf9be490104ecef351c24df1199f17779bb. > > Reason for revert: Speculative revert due to Linux ChromiumOS MSan Tests failures: > > https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/7363 > > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [14149:14149:0529/223016.256914:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [14149:14299:0529/223016.655436:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [14149:14299:0529/223016.656150:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [14149:14149:0529/223023.245267:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [14149:14372:0529/223023.626405:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [14149:14149:0529/223024.849020:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223027.955574:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223031.378924:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223034.498789:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [14149:14149:0529/223216.859287:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7fe3e82dacb0 in killpg ??:? > #5 0x7fe3e82dacb0 in ?? ??:0 > #6 0x7fe3e83a26d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 > #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 > #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 > #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 > #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 > #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 > #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 > #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 > #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 > #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 > #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 > #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 > #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 > #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 > #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 > #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 > #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 > #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 > #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 > #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 > #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 > #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 > #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 > #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 > #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 > #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 > #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 > #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 > #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 > #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 > #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 > #44 0x7fe3e82c5f45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 > #45 0x000000a511ba in _start ??:0:0 > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [9681:9681:0529/225648.292655:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9681:9709:0529/225648.491081:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9681:9709:0529/225648.491704:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [9681:9681:0529/225653.563139:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [9681:9764:0529/225653.719267:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [9681:9681:0529/225654.670750:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225657.293016:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225700.335612:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225703.324806:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225804.664156:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9681:9681:0529/225928.685288:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7f6d3333fcb0 in killpg ??:? > #5 0x7f6d3333fcb0 in ?? ??:0 > #6 0x7f6d334076d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 > #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 > #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 > #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 > #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 > #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../chrome/browser/extensions/api/web_request/web_request_apitest.cc:445:3 > #16 0x000014f9e3f2 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:385:5 > #17 0x00001387fbe5 in Run ./../../base/callback.h:125:12 > #18 0x00001387fbe5 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:2098:0 > #19 0x00001387b5c0 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1492:18 > #20 0x000007604b81 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:684:32 > #21 0x00000bd8f78b in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:962:13 > #22 0x00000d34ab21 in Run ./../../base/callback.h:125:12 > #23 0x00000d34ab21 in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:44:0 > #24 0x00000bd875e8 in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:873:25 > #25 0x00000bd9b176 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main_runner_impl.cc:148:15 > #26 0x00000bd7c28c in content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/browser/browser_main.cc:47:20 > #27 0x000012ff6795 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) ./../../content/app/content_main_runner_impl.cc:620:10 > #28 0x000012ffa9aa in content::ContentMainRunnerImpl::Run() ./../../content/app/content_main_runner_impl.cc:964:12 > #29 0x00001c607013 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:459:29 > #30 0x000012ff0d18 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #31 0x000014f9c8c0 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:323:3 > #32 0x00001372d0cf in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:244:20 > #33 0x000008b46826 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #34 0x000008b4a8bc in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2667:11 > #35 0x000008b4c34a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2785:28 > #36 0x000008b82a55 in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5047:43 > #37 0x000008b81328 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x0000137959f1 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46 > #39 0x0000137959f1 in base::TestSuite::Run() ./../../base/test/test_suite.cc:275:0 > #40 0x0000131f45a4 in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:65:38 > #41 0x000015048025 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:625:31 > #42 0x0000131f5d07 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:170:10 > #43 0x0000131f4390 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10 > #44 0x7f6d3332af45 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0 > #45 0x000000a511ba in _start ??:0:0 > [ RUN ] ExtensionWebRequestApiTest.WebRequestAuthRequired > [9971:9971:0529/225953.241021:WARNING:user_session_manager.cc(1091)] Attempting to save user password for non enterprise user. > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9971:9999:0529/225953.449328:WARNING:alsa_util.cc(24)] PcmOpen: default,No such file or directory > ALSA lib confmisc.c:768:(parse_card) cannot find card '0' > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory > ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory > ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name > ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory > ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory > ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default > [9971:9999:0529/225953.449892:WARNING:alsa_util.cc(24)] PcmOpen: plug:default,No such file or directory > [9971:9971:0529/225958.400556:ERROR:textfield.cc(1754)] Not implemented reached in virtual bool views::Textfield::ShouldDoLearning() > [9971:10053:0529/225958.532493:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico > [9971:9971:0529/225959.377349:INFO:CONSOLE(0)] "[SUCCESS] authRequiredNonBlocking", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230002.227064:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230005.286414:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230008.209328:INFO:CONSOLE(0)] "[SUCCESS] authRequiredSyncSetAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230103.646916:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncNoAction", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > [9971:9971:0529/230224.632095:INFO:CONSOLE(0)] "[SUCCESS] authRequiredAsyncCancelAuth", source: chrome-extension://chbigaineimkgiedpecafcaejhjcdebm/test_auth_required.html (0) > BrowserTestBase received signal: Terminated. Backtrace: > #0 0x000000a8dfe1 in __interceptor_backtrace /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:3980:13 > #1 0x00001350f30f in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:808:41 > #2 0x000014f9f062 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:87:5 > #3 0x000000ab5989 in SignalHandler(int) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:995:3 > #4 0x7f12d1488cb0 in killpg ??:? > #5 0x7f12d1488cb0 in ?? ??:0 > #6 0x7f12d15506d3 in epoll_wait /build/eglibc-ripdx6/eglibc-2.19/misc/../sysdeps/unix/syscall-template.S:81:0 > #7 0x000000a770a4 in __interceptor_epoll_wait /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:862:13 > #8 0x00001704b89b in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8 > #9 0x00001703ec8b in event_base_loop ./../../base/third_party/libevent/event.c:512:9 > #10 0x00001355a138 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9 > #11 0x00001336b330 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14 > #12 0x000015058275 in content::RunThisRunLoop(base::RunLoop*) ./../../content/public/test/test_utils.cc:128:13 > #13 0x00002b95647d in extensions::ResultCatcher::GetNextResult() ./../../extensions/test/result_catcher.cc:35:5 > #14 0x000004dfa6f2 in extensions::ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) ./../../chrome/browser/extensions/extension_apitest.cc:392:16 > #15 0x0000049ace7e in extensions::ExtensionWebRequestApiTest_WebRequestAuthRequired_Test::RunTestOnMainThread() ./../../c
,
May 31 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4ed921474f6ac91065b6d5326963287b3ab746f commit e4ed921474f6ac91065b6d5326963287b3ab746f Author: Matt Falkenhagen <falken@chromium.org> Date: Thu May 31 17:04:18 2018 shared worker: More fully support Chrome extensions with NetworkService. This plumbs the factory bundle that understands chrome-extension:// to more requisite places. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6cd8750ef0891910ab968fd4a91070d7ea5e2f2c Reviewed-on: https://chromium-review.googlesource.com/1077875 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#563283} [modify] https://crrev.com/e4ed921474f6ac91065b6d5326963287b3ab746f/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/e4ed921474f6ac91065b6d5326963287b3ab746f/content/renderer/service_worker/worker_fetch_context_impl.cc [modify] https://crrev.com/e4ed921474f6ac91065b6d5326963287b3ab746f/content/renderer/shared_worker/embedded_shared_worker_stub.cc [modify] https://crrev.com/e4ed921474f6ac91065b6d5326963287b3ab746f/content/renderer/shared_worker/embedded_shared_worker_stub.h [modify] https://crrev.com/e4ed921474f6ac91065b6d5326963287b3ab746f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
May 31 2018
The file scheme is tracked at bug 848510 .
,
May 31 2018
I think I can call this done now for the extension scheme.
,
May 31 2018
,
Jun 1 2018
,
Jun 1 2018
I'll do the reconnection thing later as I suspect it doesn't block Canary, but can reprioritize if needed.
,
Jul 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab39b893750485f84d1f607be642fe1efdc27f7f commit ab39b893750485f84d1f607be642fe1efdc27f7f Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Jul 12 09:20:42 2018 shared worker: Simplify the default network factory logic. When NetworkService is off but S13nSW is on, shared worker jumped through hoops to get a factory bundle to the renderer. It was giving the renderer a NetworkService default factory and expecting the renderer to clear it. But we can just give a non-NetworkService direct network default factory, since that capability was added in r565058. Bug: 839982 Change-Id: Ie5c4f182b87526e2f15a7b2a8b62ed03f7e5595f Reviewed-on: https://chromium-review.googlesource.com/1134708 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#574510} [modify] https://crrev.com/ab39b893750485f84d1f607be642fe1efdc27f7f/content/browser/shared_worker/shared_worker_host.cc [modify] https://crrev.com/ab39b893750485f84d1f607be642fe1efdc27f7f/content/renderer/shared_worker/embedded_shared_worker_stub.cc |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by falken@chromium.org
, May 7 2018Owner: falken@chromium.org
Status: Assigned (was: Available)