Add a message to the SSL interstitial when users see frequent warnings |
||||||||||
Issue descriptionSome error codes (net::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED, net::ERR_CERT_SYMANTEC_LEGACY) may result in frequent interstitials for a time. If a user sees more than some number of these during a browsing session, we'd like to add a message to the interstitial telling them to check back in a few days.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e58df467024fa836bcea8c3e49805f1be2ab66b commit 9e58df467024fa836bcea8c3e49805f1be2ab66b Author: Emily Stark <estark@google.com> Date: Wed May 09 15:25:14 2018 Show the recurrent error message on the interstitial When an error message has recurred several times, show a message on the interstitial. Note: the message isn't styled yet; the feature is off by default so I'll do the styling (and translation screenshot) in a follow-up CL. Bug: 839969 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I94a31ff16eaf9e8ef82134f372852f03b19e28df Reviewed-on: https://chromium-review.googlesource.com/1049119 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#557190} [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/bad_clock_blocking_page.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/captive_portal_blocking_page.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/captive_portal_blocking_page.h [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/mitm_software_blocking_page.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/ssl_error_controller_client.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/ssl_error_controller_client.h [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ssl/ssl_error_handler.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/chrome/browser/ui/webui/interstitials/interstitial_ui.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/browser/resources/interstitial_large.html [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/browser/resources/interstitial_large.js [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/common_string_util.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/controller_client.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/controller_client.h [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/safe_browsing_loud_error_ui.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/safe_browsing_quiet_error_ui.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/ssl_error_ui.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials/core/superfish_error_ui.cc [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/components/security_interstitials_strings.grdp [modify] https://crrev.com/9e58df467024fa836bcea8c3e49805f1be2ab66b/ios/chrome/browser/ssl/ios_captive_portal_blocking_page.mm
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/541ee9fe1a988b1c2428462acbe21daade632d7f commit 541ee9fe1a988b1c2428462acbe21daade632d7f Author: Emily Stark <estark@google.com> Date: Thu May 10 14:39:11 2018 Add CSS for recurrent error message When an error message has recurred several times, show a message on the interstitial. This CL adds the CSS for the recurrent error message. See https://bugs.chromium.org/p/chromium/issues/detail?id=839969#c3 for a current screenshot. Bug: 839969 Change-Id: I4a3ce380563d7053bf6d241ae18a380f67d22300 Reviewed-on: https://chromium-review.googlesource.com/1052918 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#557513} [modify] https://crrev.com/541ee9fe1a988b1c2428462acbe21daade632d7f/components/security_interstitials/core/browser/resources/interstitial_large.js [modify] https://crrev.com/541ee9fe1a988b1c2428462acbe21daade632d7f/components/security_interstitials/core/common/resources/interstitial_common.css
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c657d45e536fd43357f9d90b529ce52d42138c1c commit c657d45e536fd43357f9d90b529ce52d42138c1c Author: Emily Stark <estark@google.com> Date: Fri May 11 19:03:19 2018 Implement a pref mode for the recurrent error message When a certificate error recurs multiple times within a browsing session, we add a special message to the interstitial. This CL adds a Finch-controlled mode where the count of certificate errors is stored in a pref instead of in memory, so that we can trigger the recurrent error message when an error recurs within a certain period of time (even spanning browsing sessions). We might want to roll out this pref mode on certain platforms (like Android) where browsing sessions might be significantly shorter than desktop. Bug: 839969 Change-Id: I04f1af1aa30043821859f4459602627b9ba7af77 Reviewed-on: https://chromium-review.googlesource.com/1053563 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557966} [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/profiles/profile.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/ssl/chrome_ssl_host_state_delegate.h [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/common/pref_names.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/common/pref_names.h
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c657d45e536fd43357f9d90b529ce52d42138c1c commit c657d45e536fd43357f9d90b529ce52d42138c1c Author: Emily Stark <estark@google.com> Date: Fri May 11 19:03:19 2018 Implement a pref mode for the recurrent error message When a certificate error recurs multiple times within a browsing session, we add a special message to the interstitial. This CL adds a Finch-controlled mode where the count of certificate errors is stored in a pref instead of in memory, so that we can trigger the recurrent error message when an error recurs within a certain period of time (even spanning browsing sessions). We might want to roll out this pref mode on certain platforms (like Android) where browsing sessions might be significantly shorter than desktop. Bug: 839969 Change-Id: I04f1af1aa30043821859f4459602627b9ba7af77 Reviewed-on: https://chromium-review.googlesource.com/1053563 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#557966} [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/profiles/profile.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/ssl/chrome_ssl_host_state_delegate.h [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/common/pref_names.cc [modify] https://crrev.com/c657d45e536fd43357f9d90b529ce52d42138c1c/chrome/common/pref_names.h
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8878d534c0826a0270765114d61ec3d34d68d42 commit e8878d534c0826a0270765114d61ec3d34d68d42 Author: Emily Stark <estark@google.com> Date: Fri May 11 21:27:26 2018 Add recurrent interstitial to chrome://flags Bug: 839969 Change-Id: Id9a0ceff654f518e0adeeba74ed05dcb7f178bf2 Reviewed-on: https://chromium-review.googlesource.com/1055809 Reviewed-by: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558023} [modify] https://crrev.com/e8878d534c0826a0270765114d61ec3d34d68d42/chrome/browser/about_flags.cc [modify] https://crrev.com/e8878d534c0826a0270765114d61ec3d34d68d42/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/e8878d534c0826a0270765114d61ec3d34d68d42/chrome/browser/flag_descriptions.h [modify] https://crrev.com/e8878d534c0826a0270765114d61ec3d34d68d42/tools/metrics/histograms/enums.xml
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b873b84414c1b8f42134f9b0e72f16b72a4c1711 commit b873b84414c1b8f42134f9b0e72f16b72a4c1711 Author: Emily Stark <estark@google.com> Date: Tue May 15 14:26:02 2018 Update recurrent interstitial CSS to match specs Bug: 839969 Change-Id: I5c0de5f31d997be815a2c956e279f06dc1047d84 Reviewed-on: https://chromium-review.googlesource.com/1058113 Reviewed-by: Edward Jung <edwardjung@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558698} [modify] https://crrev.com/b873b84414c1b8f42134f9b0e72f16b72a4c1711/components/security_interstitials/core/browser/resources/interstitial_large.html [modify] https://crrev.com/b873b84414c1b8f42134f9b0e72f16b72a4c1711/components/security_interstitials/core/common/resources/interstitial_common.css
,
May 15 2018
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f5dc831f7c28f25b41c4bf0ae19e07f78663819 commit 6f5dc831f7c28f25b41c4bf0ae19e07f78663819 Author: Emily Stark <estark@google.com> Date: Fri May 25 03:25:00 2018 Add some metrics for the recurrent interstitial feature This CL adds two metrics of interest for the recurrent interstitial UI that is shown when the user sees the same error code multiples times. The metrics record how often the recurrent interstitial is shown (split by overridable/nonoverridable) and when the user proceeds through a recurrent interstitial, so that we can check whether the clickthrough rate is higher for recurrent interstitials than normal SSL interstitials. I've also added an additional parameter to the field trial to control whether the recurrent error message is actually displayed on the interstitial. This allows us to configure an experiment group in which recurrent errors are tracked and histograms are recorded but the recurrent error message isn't actually shown, so that we can compare clickthrough rates for identical error conditions with and without the recurrent error message showing up. Bug: 839969 Change-Id: I3739b193b9d35e9d75dc584a77514a22a5f1356b Reviewed-on: https://chromium-review.googlesource.com/1071069 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561755} [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/chrome/browser/ssl/chrome_ssl_host_state_delegate.h [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/chrome/browser/ssl/ssl_error_controller_client.cc [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/chrome/browser/ssl/ssl_error_controller_client.h [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/tools/metrics/histograms/enums.xml [modify] https://crrev.com/6f5dc831f7c28f25b41c4bf0ae19e07f78663819/tools/metrics/histograms/histograms.xml
,
May 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c47789a352fffceb46d85f8025bb8ed825ac3298 commit c47789a352fffceb46d85f8025bb8ed825ac3298 Author: Emily Stark <estark@google.com> Date: Sat May 26 00:07:32 2018 Clean up recurrent interstitial metrics This has some style cleanups following up from https://chromium-review.googlesource.com/c/chromium/src/+/1071069. Bug: 839969 Change-Id: I3aed16eb21a4f5d4b4bc6a86d4c28d196f5d3adc Reviewed-on: https://chromium-review.googlesource.com/1074147 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562074} [modify] https://crrev.com/c47789a352fffceb46d85f8025bb8ed825ac3298/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/c47789a352fffceb46d85f8025bb8ed825ac3298/chrome/browser/ssl/ssl_error_controller_client.cc [modify] https://crrev.com/c47789a352fffceb46d85f8025bb8ed825ac3298/chrome/browser/ssl/ssl_error_controller_client.h
,
May 29 2018
Requesting a merge for the change in c10. This is a metrics change that is covered by automated tests and has been baking on canary; I've verified that the UMA metrics from canary look as expected.
,
May 29 2018
This bug requires manual review: There is .grd file changes and we are only 55 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
Note to TPMs re c13: the change that (c10) I need to merge doesn't have grd file changes.
,
May 29 2018
Branch:3440
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832 commit ad75ea8bb6c781c25e8c10a4355c6e9ac486c832 Author: Emily Stark <estark@google.com> Date: Tue May 29 20:22:25 2018 Add some metrics for the recurrent interstitial feature This CL adds two metrics of interest for the recurrent interstitial UI that is shown when the user sees the same error code multiples times. The metrics record how often the recurrent interstitial is shown (split by overridable/nonoverridable) and when the user proceeds through a recurrent interstitial, so that we can check whether the clickthrough rate is higher for recurrent interstitials than normal SSL interstitials. I've also added an additional parameter to the field trial to control whether the recurrent error message is actually displayed on the interstitial. This allows us to configure an experiment group in which recurrent errors are tracked and histograms are recorded but the recurrent error message isn't actually shown, so that we can compare clickthrough rates for identical error conditions with and without the recurrent error message showing up. Bug: 839969 Change-Id: I3739b193b9d35e9d75dc584a77514a22a5f1356b Reviewed-on: https://chromium-review.googlesource.com/1071069 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#561755}(cherry picked from commit 6f5dc831f7c28f25b41c4bf0ae19e07f78663819) Reviewed-on: https://chromium-review.googlesource.com/1077032 Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#34} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/chrome/browser/ssl/chrome_ssl_host_state_delegate.cc [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/chrome/browser/ssl/chrome_ssl_host_state_delegate.h [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/chrome/browser/ssl/ssl_browsertest.cc [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/chrome/browser/ssl/ssl_error_controller_client.cc [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/chrome/browser/ssl/ssl_error_controller_client.h [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/tools/metrics/histograms/enums.xml [modify] https://crrev.com/ad75ea8bb6c781c25e8c10a4355c6e9ac486c832/tools/metrics/histograms/histograms.xml
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e7b681eaa5d1c787a71daf4841be6ffa79549d3 commit 9e7b681eaa5d1c787a71daf4841be6ffa79549d3 Author: Emily Stark <estark@google.com> Date: Wed May 30 17:56:24 2018 Default to showing recurrent interstitial UI with unset parameter In https://chromium-review.googlesource.com/c/chromium/src/+/1071069, I added a Finch parameter to control whether the recurrent interstitial UI actually shows up or not (so that we could have a control group that doesn't show the UI for comparison). I defaulted the UI to be hidden if the parameter is unset, but this CL changes it to default to show if the parameter is unset. This isn't important for the experiment or functionality; it's purely to facilitate testing on Android and ChromeOS where the parameter is unset after toggling the flag in chrome://flags. Bug: 839969 Change-Id: If51e7fdeaef2c57a81c0b1da0110d8f953b06539 Reviewed-on: https://chromium-review.googlesource.com/1079407 Reviewed-by: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#562905} [modify] https://crrev.com/9e7b681eaa5d1c787a71daf4841be6ffa79549d3/chrome/browser/ssl/ssl_error_controller_client.cc
,
Jun 1 2018
Requesting an additional merge for #17. This is a one-line change that won't affect behavior for users in the field trial, it simply facilitates testing with chrome://flags.
,
Jun 1 2018
This bug requires manual review: There is .grd file changes and we are only 52 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 1 2018
(no .grd file changes because I only want to merge #17)
,
Jun 4 2018
Approved - branch:3440
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cfc37a62be053af5bb769dd17e62f98576c757b commit 0cfc37a62be053af5bb769dd17e62f98576c757b Author: Emily Stark <estark@google.com> Date: Mon Jun 04 20:38:17 2018 Default to showing recurrent interstitial UI with unset parameter In https://chromium-review.googlesource.com/c/chromium/src/+/1071069, I added a Finch parameter to control whether the recurrent interstitial UI actually shows up or not (so that we could have a control group that doesn't show the UI for comparison). I defaulted the UI to be hidden if the parameter is unset, but this CL changes it to default to show if the parameter is unset. This isn't important for the experiment or functionality; it's purely to facilitate testing on Android and ChromeOS where the parameter is unset after toggling the flag in chrome://flags. Bug: 839969 Change-Id: If51e7fdeaef2c57a81c0b1da0110d8f953b06539 Reviewed-on: https://chromium-review.googlesource.com/1079407 Reviewed-by: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562905}(cherry picked from commit 9e7b681eaa5d1c787a71daf4841be6ffa79549d3) Reviewed-on: https://chromium-review.googlesource.com/1085973 Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#168} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/0cfc37a62be053af5bb769dd17e62f98576c757b/chrome/browser/ssl/ssl_error_controller_client.cc
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/541e64f39d4879fc20946ddc3ada66d44ddc66af commit 541e64f39d4879fc20946ddc3ada66d44ddc66af Author: Emily Stark <estark@google.com> Date: Tue Jun 12 21:39:09 2018 Turn on recurrent interstitial in field trial testing config Bug: 839969 Change-Id: Ib677bf13f737e5cc2fb5cd5b43466f2d6b796f69 Reviewed-on: https://chromium-review.googlesource.com/1096370 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#566580} [modify] https://crrev.com/541e64f39d4879fc20946ddc3ada66d44ddc66af/testing/variations/fieldtrial_testing_config.json
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17667924bdcdf48ad56f3955f866f28fecbb0091 commit 17667924bdcdf48ad56f3955f866f28fecbb0091 Author: Emily Stark <estark@google.com> Date: Fri Jul 13 20:27:11 2018 Add Android field trial config for recurrent interstitial Bug: 839969 Change-Id: I07ad560f50aa25a10a5a9fb55ebdd525d0fa6e84 Reviewed-on: https://chromium-review.googlesource.com/1136711 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575054} [modify] https://crrev.com/17667924bdcdf48ad56f3955f866f28fecbb0091/testing/variations/fieldtrial_testing_config.json
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89e8120b30ff3138cde3a4791e979b14c22cd44e commit 89e8120b30ff3138cde3a4791e979b14c22cd44e Author: Emily Stark <estark@google.com> Date: Fri Jul 13 20:30:58 2018 Split out recurrent error metrics for CT errors specifically This will allow us to see whether the recurrent interstitial message affects CTR for CT errors specifically (rather than lumping them in with Symantec distrust errors, which can also trigger the recurrent error message). Bug: 839969 Change-Id: I04764573c6f225ab25c61fb268983f02f38fdc3f Reviewed-on: https://chromium-review.googlesource.com/1136717 Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575056} [modify] https://crrev.com/89e8120b30ff3138cde3a4791e979b14c22cd44e/chrome/browser/ssl/ssl_blocking_page.cc [modify] https://crrev.com/89e8120b30ff3138cde3a4791e979b14c22cd44e/chrome/browser/ssl/ssl_error_controller_client.cc [modify] https://crrev.com/89e8120b30ff3138cde3a4791e979b14c22cd44e/tools/metrics/histograms/histograms.xml |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by est...@chromium.org
, May 4 2018