Do not use extra space for WebAPK installation on Android J and K |
|||||||||
Issue descriptionExtra installation space is only allowed >= Android L. Do not use them in J and K
,
May 4 2018
,
May 5 2018
,
May 5 2018
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 5 2018
Sorry it should be P1 as WebAPK installations are failing on Android K-. Update priority and request again.
,
May 5 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 8 2018
How safe is it to merge this into M67? has the fix been verified in canary?
,
May 8 2018
The change should be very safe as we are increasing the minimum free space allowance for Android K- users for WebAPK. Previously we try to install WebAPK when the free space on device >=400MB, now we do the installation when the space >=500MB. This change should not break anything.
,
May 8 2018
,
May 14 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e0b6bd42f68b6c3f7466fa71d7911f566910dbc commit 3e0b6bd42f68b6c3f7466fa71d7911f566910dbc Author: Ran Ji <ranj@chromium.org> Date: Mon May 14 17:05:30 2018 Do not use extra space for WebAPK installation on Android J and K TBR=yfriedman@chromium.org Bug: 839964 Change-Id: I4fe48a721a878be716cc3fd2cc38fcf9ac3075a4 Reviewed-on: https://chromium-review.googlesource.com/1044953 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#556204}(cherry picked from commit 11edd3405625d391169ccbbebb9b0a9dfb198941) Reviewed-on: https://chromium-review.googlesource.com/1057691 Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#589} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/3e0b6bd42f68b6c3f7466fa71d7911f566910dbc/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, May 4 2018