New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839964 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Do not use extra space for WebAPK installation on Android J and K

Project Member Reported by ranj@chromium.org, May 4 2018

Issue description

Extra installation space is only allowed >= Android L. Do not use them in J and K
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11edd3405625d391169ccbbebb9b0a9dfb198941

commit 11edd3405625d391169ccbbebb9b0a9dfb198941
Author: Ran Ji <ranj@chromium.org>
Date: Fri May 04 21:35:24 2018

Do not use extra space for WebAPK installation on Android J and K

Bug:  839964 
Change-Id: I4fe48a721a878be716cc3fd2cc38fcf9ac3075a4
Reviewed-on: https://chromium-review.googlesource.com/1044953
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556204}
[modify] https://crrev.com/11edd3405625d391169ccbbebb9b0a9dfb198941/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java

Comment 2 by ranj@chromium.org, May 4 2018

Labels: Merge-Request-67
Labels: OS-Android
Project Member

Comment 4 by sheriffbot@chromium.org, May 5 2018

Labels: -Merge-Request-67 Merge-Reject-67 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M67 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by ranj@chromium.org, May 5 2018

Cc: yfried...@chromium.org
Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-67 Merge-Request-67 Pri-1
Status: Fixed (was: Untriaged)
Sorry it should be P1 as WebAPK installations are failing on Android K-. Update priority and request again.
Project Member

Comment 6 by sheriffbot@chromium.org, May 5 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
How safe is it to merge this into M67? has the fix been verified in canary?

Comment 8 by ranj@chromium.org, May 8 2018

Cc: cma...@chromium.org
The change should be very safe as we are increasing the minimum free space allowance for Android K- users for WebAPK.

Previously we try to install WebAPK when the free space on device >=400MB, now we do the installation when the space >=500MB. This change should not break anything.
Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Project Member

Comment 10 by sheriffbot@chromium.org, May 14 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, May 14 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e0b6bd42f68b6c3f7466fa71d7911f566910dbc

commit 3e0b6bd42f68b6c3f7466fa71d7911f566910dbc
Author: Ran Ji <ranj@chromium.org>
Date: Mon May 14 17:05:30 2018

Do not use extra space for WebAPK installation on Android J and K

TBR=yfriedman@chromium.org

Bug:  839964 
Change-Id: I4fe48a721a878be716cc3fd2cc38fcf9ac3075a4
Reviewed-on: https://chromium-review.googlesource.com/1044953
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Ran Ji <ranj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556204}(cherry picked from commit 11edd3405625d391169ccbbebb9b0a9dfb198941)
Reviewed-on: https://chromium-review.googlesource.com/1057691
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#589}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/3e0b6bd42f68b6c3f7466fa71d7911f566910dbc/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java

Sign in to add a comment