New issue
Advanced search Search tips

Issue 839955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

chrome os caption button colors wrong for themed browsers

Project Member Reported by est...@chromium.org, May 4 2018

Issue description

1. install https://chrome.google.com/webstore/detail/space/hepnfgiockihbakjbhonkinpagbkaobo?hl=en-GB
2. caption buttons should be white, but they're grey
3. press f11 twice to toggle fullscreen
4. now caption buttons are white
 
Status: Started (was: Assigned)
FWIW step (3) can be re-written as "do anything to make the frame repaint", including for example resizing the window.
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7665435ec16705f26cf15259d28b89d24ec80699

commit 7665435ec16705f26cf15259d28b89d24ec80699
Author: Evan Stade <estade@chromium.org>
Date: Thu May 10 18:54:47 2018

cros: Fix initial appearance of themed browser window's caption buttons.

Bug:  839955 
Change-Id: Ib8897bc667a0896f3f6cf607005738c6fbfc920d
Reviewed-on: https://chromium-review.googlesource.com/1048975
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557605}
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/ash/frame/caption_buttons/frame_caption_button.cc
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/ash/frame/caption_buttons/frame_caption_button.h
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/ash/frame/custom_frame_header.cc
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/ash/frame/custom_frame_header.h
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/7665435ec16705f26cf15259d28b89d24ec80699/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Comment 3 by est...@chromium.org, May 11 2018

Status: Fixed (was: Started)

Sign in to add a comment