New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839947 link

Starred by 1 user
Status: Fixed
Owner:
domfarolino@gmail.com
Closed: May 2018
Cc:
█ kozyatinskiy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Console API: Implement console.countReset()

Project Member Reported by domfarolino@gmail.com, May 4 2018 
The `console.countReset()` API is being spec'ed at https://github.com/whatwg/console/pull/133 and tested at https://github.com/w3c/web-platform-tests/pull/10722. As of now, Node.js and Edge implement this API, and given that it is being added to the spec, we're expecting implementations to conform.

I'm willing to own this addition, and have a WIP CL in progress but am getting a linking error with it, I'll publish it soon.

Comment 1 by domfarolino@gmail.com, May 4 2018

Summary: Console API: Implement console.countReset() (was: Console API: Implement )
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c9a728aaa05c2f400df90a97f8a80cb298ed97b0

commit c9a728aaa05c2f400df90a97f8a80cb298ed97b0
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Wed May 09 14:59:04 2018

[inspector] implement console.countReset()

Implement console.countReset() from the WHATWG Console Standard

R=bmeurer@chromium.org, dgozman@chromium.org, kozyatinskiy@chromium.org

Bug:  chromium:839947 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8a900e9cdf3e5b08506f709cf6497476c8c6c00b
Reviewed-on: https://chromium-review.googlesource.com/1044902
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#53106}
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/AUTHORS
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/bootstrapper.cc
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/builtins/builtins-console.cc
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/builtins/builtins-definitions.h
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/debug/interface-types.h
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/inspector/v8-console-message.cc
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/inspector/v8-console-message.h
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/inspector/v8-console.cc
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/src/inspector/v8-console.h
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/test/inspector/runtime/console-context-expected.txt
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/test/inspector/runtime/console-methods-expected.txt
[modify] https://crrev.com/c9a728aaa05c2f400df90a97f8a80cb298ed97b0/test/inspector/runtime/console-methods.js

Comment 3 by domfarolino@gmail.com, May 9 2018

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, May 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8fb1550cf42970f8cb5445e481e3f193df4c910

commit c8fb1550cf42970f8cb5445e481e3f193df4c910
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu May 10 17:57:53 2018

Mark wpt countReset tests as failed

These tests are failing already and with new V8 roll they will fail
differently.

TBR=dgozman@chromium.org

Bug:  chromium:839947 
Change-Id: I03399a6528e88d41025d577c44feec08f245d1ba
Reviewed-on: https://chromium-review.googlesource.com/1054187
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557581}
[modify] https://crrev.com/c8fb1550cf42970f8cb5445e481e3f193df4c910/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/883c397ddd952ca243d37f7ce68dc3b4235f2f20

commit 883c397ddd952ca243d37f7ce68dc3b4235f2f20
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Sun May 27 15:31:39 2018

Re-enable console counting WPTs

This re-enables console counting WPTs. The console.countReset WPT
failures were blocking V8's autorolling, so the test was disabled.
This CL re-enables it and updates the failing expectation file
(the original issue) because at the moment we expect the test to
fail but for different reasons.

R=kozyatinskiy@chromium.org

Bug:  839947 
Change-Id: I4d88e206dd213bc0b8113e921176e02f6c1f96d4
Reviewed-on: https://chromium-review.googlesource.com/1067003
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
Cr-Commit-Position: refs/heads/master@{#562149}
[modify] https://crrev.com/883c397ddd952ca243d37f7ce68dc3b4235f2f20/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/883c397ddd952ca243d37f7ce68dc3b4235f2f20/third_party/WebKit/LayoutTests/external/wpt/console/console-counting-label-conversion.any-expected.txt
[modify] https://crrev.com/883c397ddd952ca243d37f7ce68dc3b4235f2f20/third_party/WebKit/LayoutTests/external/wpt/console/console-counting-label-conversion.any.worker-expected.txt
►

Sign in to add a comment