Make gclient use separate properties for url and revision |
|
Issue descriptionMake gclient use separate properties for url and revision, instead of using a single url property with the revision separated by '@'.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d82cf6dc3fb8345d2b68851e31263ad55cf85657 commit d82cf6dc3fb8345d2b68851e31263ad55cf85657 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 10 00:52:28 2018 Roll src/third_party/depot_tools/ afec759dc..b61d387fa (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/afec759dca62..b61d387fa2d4 $ git log afec759dc..b61d387fa --date=short --no-merges --format='%ad %ae %s' 2018-05-09 ehmaldonado gclient: Make GetScmName and CreateSCM abstract methods. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia79fcc90ad5e83556336fa50dd41f1799cea66ab Reviewed-on: https://chromium-review.googlesource.com/1053357 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557399} [modify] https://crrev.com/d82cf6dc3fb8345d2b68851e31263ad55cf85657/DEPS
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e877b1776a14eb96a5fa201e160022b85df488fe commit e877b1776a14eb96a5fa201e160022b85df488fe Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu May 10 18:10:52 2018 gclient: Get rid of parsed_url. There is no reason I can see to set parsed_url so late. Also, the tests are misleading, since relative URLs don't behave the way the tests led you to believe. Bug: 839925 Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 Reviewed-on: https://chromium-review.googlesource.com/1047797 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe/testing_support/fake_repos.py [modify] https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe/tests/gclient_test.py [modify] https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe/gclient.py [modify] https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe/gclient_scm.py [modify] https://crrev.com/e877b1776a14eb96a5fa201e160022b85df488fe/tests/gclient_smoketest.py
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfafeb1d11777320f596a2a7de34581e8c72f52e commit dfafeb1d11777320f596a2a7de34581e8c72f52e Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 10 19:52:38 2018 Roll src/third_party/depot_tools/ d3f2c8e78..e877b1776 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d3f2c8e78346..e877b1776a14 $ git log d3f2c8e78..e877b1776 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado gclient: Get rid of parsed_url. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7130ec104ca053af5aa4be065bdfc0a0aa5c9315 Reviewed-on: https://chromium-review.googlesource.com/1054172 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557634} [modify] https://crrev.com/dfafeb1d11777320f596a2a7de34581e8c72f52e/DEPS
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e7273d25017a27aab7026bc0ef48fe9ab4e09f22 commit e7273d25017a27aab7026bc0ef48fe9ab4e09f22 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Fri May 11 01:26:52 2018 Reland "gclient: Get rid of parsed_url." This is a reland of e877b1776a14eb96a5fa201e160022b85df488fe Original change's description: > gclient: Get rid of parsed_url. > > There is no reason I can see to set parsed_url so late. > Also, the tests are misleading, since relative URLs don't behave the way > the tests led you to believe. > > Bug: 839925 > Change-Id: I08d92b7b7847bdc406f003d4a4139d968cc662b1 > Reviewed-on: https://chromium-review.googlesource.com/1047797 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> TBR=agable@chromium.org Bug: 839925 Change-Id: I9200ec5fbe7289022e9754f0c78676dc931fcaeb Reviewed-on: https://chromium-review.googlesource.com/1054567 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> [modify] https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22/gclient_scm.py [modify] https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22/recipes/trigger_recipe_roller.txt [modify] https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22/testing_support/fake_repos.py [modify] https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22/gclient.py [modify] https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22/tests/gclient_smoketest.py [modify] https://crrev.com/e7273d25017a27aab7026bc0ef48fe9ab4e09f22/tests/gclient_test.py
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a27b73b135bf547245c157fc7f499c5969a3448a commit a27b73b135bf547245c157fc7f499c5969a3448a Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 11 04:26:45 2018 Roll src/third_party/depot_tools/ 3d894aa45..e7273d250 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d894aa45e08..e7273d25017a $ git log 3d894aa45..e7273d250 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado Reland "gclient: Get rid of parsed_url." Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic0e6386f9d2f7b62b49ddc3e69dce7f4f20dcd76 Reviewed-on: https://chromium-review.googlesource.com/1055050 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557795} [modify] https://crrev.com/a27b73b135bf547245c157fc7f499c5969a3448a/DEPS
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/babd098f3684f1bc965a0f72f96cb701eec91e52 commit babd098f3684f1bc965a0f72f96cb701eec91e52 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Mon May 14 17:02:21 2018 gclient: Simplify GetScmName and CreateSCM. Bug: 839925 Change-Id: Ibf97acf3c74b6f406904e14545e13497c680b883 Reviewed-on: https://chromium-review.googlesource.com/1054852 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/babd098f3684f1bc965a0f72f96cb701eec91e52/tests/gclient_test.py [modify] https://crrev.com/babd098f3684f1bc965a0f72f96cb701eec91e52/gclient.py
,
May 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/305201ae672634fe6ea7a27faaf516d577b7f0ad commit 305201ae672634fe6ea7a27faaf516d577b7f0ad Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon May 14 18:22:10 2018 Roll src/third_party/depot_tools/ d1de725e0..babd098f3 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d1de725e0b53..babd098f3684 $ git log d1de725e0..babd098f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-11 ehmaldonado gclient: Simplify GetScmName and CreateSCM. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I63a00f02cbf4ee0a5c3c83fe758b807edf801abe Reviewed-on: https://chromium-review.googlesource.com/1057894 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558380} [modify] https://crrev.com/305201ae672634fe6ea7a27faaf516d577b7f0ad/DEPS
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/16f4bad9148c587a0254988138e713df72b035b7 commit 16f4bad9148c587a0254988138e713df72b035b7 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed May 16 21:00:41 2018 gclient: Merge hook_os with hooks and deps_os with os. This is done in gclient_eval, so we can remove all code that deals with deps_os and hooks_os from gclient. Bug: 839925 Change-Id: I491819207a712d62008ff010e313add87d22c937 Reviewed-on: https://chromium-review.googlesource.com/1058375 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7/gclient_eval.py [modify] https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7/tests/gclient_smoketest.py [modify] https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7/gclient.py [modify] https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7/tests/gclient_test.py [modify] https://crrev.com/16f4bad9148c587a0254988138e713df72b035b7/tests/gclient_eval_unittest.py
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ed1bb34fc59e5539ea29def4d68cd94a8e17e71b commit ed1bb34fc59e5539ea29def4d68cd94a8e17e71b Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed May 16 21:19:51 2018 gclient: Remove condition_value. It not used anywhere. Bug: 839925 Change-Id: Iad07b548744f2c58d34427f3e2225d8c75926eea Reviewed-on: https://chromium-review.googlesource.com/1060632 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/ed1bb34fc59e5539ea29def4d68cd94a8e17e71b/tests/gclient_test.py [modify] https://crrev.com/ed1bb34fc59e5539ea29def4d68cd94a8e17e71b/gclient.py
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/4db23d3790aeac2a8f09ce0d75e37aef474a83ea commit 4db23d3790aeac2a8f09ce0d75e37aef474a83ea Author: Edward Lemur <ehmaldonado@chromium.org> Date: Wed May 16 22:15:12 2018 Don't use deps_os in DEPS file Use checkout_* conditions to check if npm_modules should be synced instead Bug: 839925 Change-Id: Ie0989a3a09074d63395e5ef061743875591e2dac Reviewed-on: https://chromium-review.googlesource.com/1062721 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/4db23d3790aeac2a8f09ce0d75e37aef474a83ea/DEPS
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f546c27ece7f2e321716e4f4293f20882235995f commit f546c27ece7f2e321716e4f4293f20882235995f Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 16 23:25:16 2018 Roll src/third_party/depot_tools/ 8de3800ce..ed1bb34fc (3 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8de3800ce55b..ed1bb34fc59e $ git log 8de3800ce..ed1bb34fc --date=short --no-merges --format='%ad %ae %s' 2018-05-16 ehmaldonado gclient: Remove condition_value. 2018-05-16 ehmaldonado gclient: Merge hook_os with hooks and deps_os with os. 2018-04-26 ehmaldonado Reland "bot_update: Patch on gclient by default." Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925,chromium:839925, chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I593c53bdc762894bd3c7bdf61337327f4e2763f9 Reviewed-on: https://chromium-review.googlesource.com/1062929 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559329} [modify] https://crrev.com/f546c27ece7f2e321716e4f4293f20882235995f/DEPS
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/23a358764dd8cd61e7d6efe086fb51c78ae0ac9b commit 23a358764dd8cd61e7d6efe086fb51c78ae0ac9b Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu May 17 06:17:29 2018 gclient: Fix for extra custom_deps. Custom deps not present in DEPS files cause errors when syncing, since we add them as strings in postprocess_deps, but deps_to_objects expects a dictionary. TBR=agable@chromium.org Bug: 839925 Change-Id: Ic08a83e8692f1bf90d4456c72fe99493363ba747 Reviewed-on: https://chromium-review.googlesource.com/1063326 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/23a358764dd8cd61e7d6efe086fb51c78ae0ac9b/tests/gclient_test.py [modify] https://crrev.com/23a358764dd8cd61e7d6efe086fb51c78ae0ac9b/gclient.py [modify] https://crrev.com/23a358764dd8cd61e7d6efe086fb51c78ae0ac9b/recipes/trigger_recipe_roller.txt
,
May 17 2018
I am not sure it is related but on the WebRTC auto-roller we are getting: ERROR:root:Command failed: gclient setdep --revision src/base@ec6f13294e415f93dece3abbbc70c4ca93967ed4 stdout: stderr: Traceback (most recent call last): File "/b/depot_tools/gclient.py", line 2949, in <module> sys.exit(main(sys.argv[1:])) File "/b/depot_tools/gclient.py", line 2935, in main return dispatcher.execute(OptionParser(), argv) File "/b/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/b/depot_tools/gclient.py", line 2808, in CMDsetdep gclient_eval.SetRevision(local_scope, name, value) File "/b/depot_tools/gclient_eval.py", line 791, in SetRevision _UpdateRevision(gclient_dict['deps'], dep_name, new_revision) File "/b/depot_tools/gclient_eval.py", line 750, in _UpdateRevision dep_node = dep_dict.GetNode(dep_key) AttributeError: 'dict' object has no attribute 'GetNode'
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed3244b000f6e4951f6104f5f6843b7a649caa9c commit ed3244b000f6e4951f6104f5f6843b7a649caa9c Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 10:33:36 2018 Roll src/third_party/depot_tools/ ed1bb34fc..23a358764 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ed1bb34fc59e..23a358764dd8 $ git log ed1bb34fc..23a358764 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 ehmaldonado gclient: Fix for extra custom_deps. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I293439d96cfef1bb45b25e3e989f591efce049fb Reviewed-on: https://chromium-review.googlesource.com/1063557 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559478} [modify] https://crrev.com/ed3244b000f6e4951f6104f5f6843b7a649caa9c/DEPS
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4727c64750e84e093a8046384fb0d1f0fbb2b339 commit 4727c64750e84e093a8046384fb0d1f0fbb2b339 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu May 17 15:52:23 2018 gclient: Fix getdep and setdep and add tests. Bug: 843917 , 839925 Change-Id: I84e52c95fc91d67375d4d954018f057561896914 Reviewed-on: https://chromium-review.googlesource.com/1064005 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339/tests/gclient_smoketest.py [modify] https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339/gclient.py [modify] https://crrev.com/4727c64750e84e093a8046384fb0d1f0fbb2b339/recipes/trigger_recipe_roller.txt
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b496b6a0570bd4c9be2c1034ae1b5ae4360b327b commit b496b6a0570bd4c9be2c1034ae1b5ae4360b327b Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu May 17 18:11:03 2018 gclient: Fix roll-dep. Bug: 839925 Change-Id: I5a56ad03866bd0b8f7d43bb3a643372d7b66343c Reviewed-on: https://chromium-review.googlesource.com/1064692 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/b496b6a0570bd4c9be2c1034ae1b5ae4360b327b/roll_dep.py [modify] https://crrev.com/b496b6a0570bd4c9be2c1034ae1b5ae4360b327b/recipes/trigger_recipe_roller.txt
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bfca97905e72e616739cb9f96d28f8294d3eee8 commit 3bfca97905e72e616739cb9f96d28f8294d3eee8 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 19:47:13 2018 Roll src/third_party/depot_tools/ 23a358764..b496b6a05 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/23a358764dd8..b496b6a0570b $ git log 23a358764..b496b6a05 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 ehmaldonado gclient: Fix roll-dep. 2018-05-17 ehmaldonado gclient: Fix getdep and setdep and add tests. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925, chromium:843917 ,chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I21d57efe8cacbd4c2f7c8043e4ab71d0f38ee747 Reviewed-on: https://chromium-review.googlesource.com/1064735 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559646} [modify] https://crrev.com/3bfca97905e72e616739cb9f96d28f8294d3eee8/DEPS
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3 commit 8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu May 17 20:27:43 2018 gclient: Actually fix roll-dep. Bug: 839925 Change-Id: I5cb6655309d6aa8dada7e6bd245d859593fb055f Reviewed-on: https://chromium-review.googlesource.com/1064809 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3/roll_dep.py [modify] https://crrev.com/8fe4d8cbef3bff9d615de14d9a414679cf9ca8c3/recipes/trigger_recipe_roller.txt
,
May 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9b5cd4a9fc18cd62993b4a2dba6623868020b54 commit c9b5cd4a9fc18cd62993b4a2dba6623868020b54 Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Thu May 17 21:50:32 2018 Roll src/third_party/depot_tools/ b496b6a05..8fe4d8cbe (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b496b6a0570b..8fe4d8cbef3b $ git log b496b6a05..8fe4d8cbe --date=short --no-merges --format='%ad %ae %s' 2018-05-17 ehmaldonado gclient: Actually fix roll-dep. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1c97bac163b7bfe994c6f19b7a28b6ceeaca4d0 Reviewed-on: https://chromium-review.googlesource.com/1064879 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559695} [modify] https://crrev.com/c9b5cd4a9fc18cd62993b4a2dba6623868020b54/DEPS
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/083eb25f9acbe034db94a1bd5c1659125b6ebf98 commit 083eb25f9acbe034db94a1bd5c1659125b6ebf98 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Fri May 18 17:57:24 2018 gclient: Don't allow URL to be None. Bug: 839925 Change-Id: I5a559db846ac19e3c61e77f3019c7d5362beccba Reviewed-on: https://chromium-review.googlesource.com/1063029 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/083eb25f9acbe034db94a1bd5c1659125b6ebf98/tests/gclient_test.py [modify] https://crrev.com/083eb25f9acbe034db94a1bd5c1659125b6ebf98/gclient.py [modify] https://crrev.com/083eb25f9acbe034db94a1bd5c1659125b6ebf98/tests/gclient_smoketest.py
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a38b4ccd0cb1eaed184481b784b634a867880f4c commit a38b4ccd0cb1eaed184481b784b634a867880f4c Author: depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri May 18 19:18:29 2018 Roll src/third_party/depot_tools/ 8fe4d8cbe..083eb25f9 (1 commit) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8fe4d8cbef3b..083eb25f9acb $ git log 8fe4d8cbe..083eb25f9 --date=short --no-merges --format='%ad %ae %s' 2018-05-17 ehmaldonado gclient: Don't allow URL to be None. Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3e7a39e52ff5a30844adb5f558d3b18c7d6dbc7f Reviewed-on: https://chromium-review.googlesource.com/1066399 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559987} [modify] https://crrev.com/a38b4ccd0cb1eaed184481b784b634a867880f4c/DEPS
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9 commit 54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue May 22 17:52:27 2018 gclient: Refactor PrintRevInfo Bug: 839925 Change-Id: I9d1b2572676a7d61862382f6882622521d28ef97 Reviewed-on: https://chromium-review.googlesource.com/1068250 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9/gclient.py [modify] https://crrev.com/54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9/tests/gclient_smoketest.py
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a commit ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a Author: Edward Lemur <ehmaldonado@chromium.org> Date: Tue May 22 18:14:18 2018 gclient: Remove URLs from hierarchy. Bug: 839925 Change-Id: I66d0bd074433288e780e1bdde9ebfce4fa85db0f Reviewed-on: https://chromium-review.googlesource.com/1067496 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a/gclient.py
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b9615b978664d9415a86ff93a2bf6cb85896407 commit 0b9615b978664d9415a86ff93a2bf6cb85896407 Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed May 23 01:01:37 2018 Roll src/third_party/depot_tools/ 398fb44e2..ebdd0db49 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/398fb44e2866..ebdd0db493b2 $ git log 398fb44e2..ebdd0db49 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 ehmaldonado gclient: Remove URLs from hierarchy. 2018-05-21 ehmaldonado gclient: Refactor PrintRevInfo Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925,chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I116c57cdcbf6d9c09c93663777cfd970a1fa9ae6 Reviewed-on: https://chromium-review.googlesource.com/1069596 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560864} [modify] https://crrev.com/0b9615b978664d9415a86ff93a2bf6cb85896407/DEPS
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/fbb06aaab10757b082ca450da5ba146182eef622 commit fbb06aaab10757b082ca450da5ba146182eef622 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Mon Jun 11 20:43:06 2018 gclient: Use only recursedeps to decide whether to process a dependency. Bug: 839925 Change-Id: If86cfbdbea795b6da53dec1ea6e44c5af8a3b846 Reviewed-on: https://chromium-review.googlesource.com/1086270 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/fbb06aaab10757b082ca450da5ba146182eef622/tests/gclient_test.py [modify] https://crrev.com/fbb06aaab10757b082ca450da5ba146182eef622/gclient.py [modify] https://crrev.com/fbb06aaab10757b082ca450da5ba146182eef622/gclient_scm.py [modify] https://crrev.com/fbb06aaab10757b082ca450da5ba146182eef622/tests/gclient_smoketest.py
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b63c4663d478bcf8d4fd163a52dc42eb85861ea7 commit b63c4663d478bcf8d4fd163a52dc42eb85861ea7 Author: Edward Lemur <ehmaldonado@chromium.org> Date: Mon Jun 11 20:56:16 2018 gclient: Use only recursedeps to decide whether to process a dependency (Trigger recipe roller) Tbr: agable@chromium.org Bug: 839925 Change-Id: Ie1dab7cfaa831af65fd9f8d2962161a729fb7a36 Reviewed-on: https://chromium-review.googlesource.com/1096121 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> [modify] https://crrev.com/b63c4663d478bcf8d4fd163a52dc42eb85861ea7/recipes/trigger_recipe_roller.txt
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba76c5f5dbec374e50a9efdbba41974a1afaf826 commit ba76c5f5dbec374e50a9efdbba41974a1afaf826 Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 12 07:10:15 2018 Roll src/third_party/depot_tools a10370c44be8..b63c4663d478 (4 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a10370c44be8..b63c4663d478 git log a10370c44be8..b63c4663d478 --date=short --no-merges --format='%ad %ae %s' 2018-06-11 ehmaldonado@chromium.org gclient: Use only recursedeps to decide whether to process a dependency (Trigger recipe roller) 2018-06-11 ehmaldonado@chromium.org gclient: Use only recursedeps to decide whether to process a dependency. 2018-06-11 brucedawson@chromium.org Improve post_build_ninja_summary.py's incremental build handling 2018-06-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@b63c4663d478 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:839925,chromium:839925,chromium:787983 TBR=agable@chromium.org Change-Id: I067bdf689595ed16809b3cd667c29b62b71e5798 Reviewed-on: https://chromium-review.googlesource.com/1096219 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#566345} [modify] https://crrev.com/ba76c5f5dbec374e50a9efdbba41974a1afaf826/DEPS
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0c91147d50ae4b67828a1d8551bb7ba876d5955d commit 0c91147d50ae4b67828a1d8551bb7ba876d5955d Author: Edward Lemur <ehmaldonado@chromium.org> Date: Thu Jun 14 19:39:52 2018 gclient: Don't allow None URLs (except in .gclient files) This reverts commit crrev.com/4e9b50ab86b9b9f8ebf0b9ba6bd4954217ebeff9 and thus relands the following commits: ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a: "gclient: Remove URLs from hierarchy." 54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9: "gclient: Refactor PrintRevInfo" 083eb25f9acbe034db94a1bd5c1659125b6ebf98: "gclient: Don't allow URL to be None." When a None URL is specified in a .gclient file, and a DEPS file is given, the DEPS file is treated as a .gclient file and its dependencies are added. Bug: 839925 Change-Id: I1068b66487874bfa0a788bf9da5273714b6ad39e Reviewed-on: https://chromium-review.googlesource.com/1083340 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Aaron Gable <agable@chromium.org> Reviewed-by: Michael Moss <mmoss@chromium.org> [modify] https://crrev.com/0c91147d50ae4b67828a1d8551bb7ba876d5955d/tests/gclient_test.py [modify] https://crrev.com/0c91147d50ae4b67828a1d8551bb7ba876d5955d/tests/gclient_smoketest.py [modify] https://crrev.com/0c91147d50ae4b67828a1d8551bb7ba876d5955d/gclient.py [modify] https://crrev.com/0c91147d50ae4b67828a1d8551bb7ba876d5955d/recipes/trigger_recipe_roller.txt
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68bd2e31608bc0fdb34a0f6f9c59e681e1c6c320 commit 68bd2e31608bc0fdb34a0f6f9c59e681e1c6c320 Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 15 00:51:01 2018 Roll src/third_party/depot_tools 425d9ce2d32c..c91211414086 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/425d9ce2d32c..c91211414086 git log 425d9ce2d32c..c91211414086 --date=short --no-merges --format='%ad %ae %s' 2018-06-14 ehmaldonado@chromium.org gclient_scm: Use cherry-picking instead of rebasing. 2018-06-14 ehmaldonado@chromium.org gclient: Don't allow None URLs (except in .gclient files) Created with: gclient setdep -r src/third_party/depot_tools@c91211414086 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812,chromium:839925 TBR=agable@chromium.org Change-Id: I8a9d2c829bf6a650fd793567fa3e122972016a09 Reviewed-on: https://chromium-review.googlesource.com/1101718 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567504} [modify] https://crrev.com/68bd2e31608bc0fdb34a0f6f9c59e681e1c6c320/DEPS
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/d683d7ced42ddcf9bb1f943471dd455a4e326902 commit d683d7ced42ddcf9bb1f943471dd455a4e326902 Author: Michael Moss <mmoss@chromium.org> Date: Fri Jun 15 05:05:17 2018 Revert "gclient: Don't allow None URLs (except in .gclient files)" This reverts commit 0c91147d50ae4b67828a1d8551bb7ba876d5955d. Reason for revert: This is causing 'gclient revinfo' to fail on the release builders, and appears to be somehow related to the "--output-json" flag. Original change's description: > gclient: Don't allow None URLs (except in .gclient files) > > This reverts commit crrev.com/4e9b50ab86b9b9f8ebf0b9ba6bd4954217ebeff9 > and thus relands the following commits: > > ebdd0db493b20f0abeab8960e6ea0ceb7c6b379a: "gclient: Remove URLs from hierarchy." > 54a5c2ba8ac2f9b8f4a32fe79913f13545e4aab9: "gclient: Refactor PrintRevInfo" > 083eb25f9acbe034db94a1bd5c1659125b6ebf98: "gclient: Don't allow URL to be None." > > When a None URL is specified in a .gclient file, and a DEPS file is > given, the DEPS file is treated as a .gclient file and its dependencies > are added. > > Bug: 839925 > > Change-Id: I1068b66487874bfa0a788bf9da5273714b6ad39e > Reviewed-on: https://chromium-review.googlesource.com/1083340 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org Change-Id: I46785bd272b16b3672e553b6443cee6d6b370ec1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839925, 853093 Reviewed-on: https://chromium-review.googlesource.com/1101978 Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> [modify] https://crrev.com/d683d7ced42ddcf9bb1f943471dd455a4e326902/tests/gclient_test.py [modify] https://crrev.com/d683d7ced42ddcf9bb1f943471dd455a4e326902/tests/gclient_smoketest.py [modify] https://crrev.com/d683d7ced42ddcf9bb1f943471dd455a4e326902/gclient.py [modify] https://crrev.com/d683d7ced42ddcf9bb1f943471dd455a4e326902/recipes/trigger_recipe_roller.txt
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f36dbe3faee926ba8e385d0a8814c1608ea7fd7 commit 0f36dbe3faee926ba8e385d0a8814c1608ea7fd7 Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Jun 15 07:44:24 2018 Roll src/third_party/depot_tools fce7bc9e0825..d683d7ced42d (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fce7bc9e0825..d683d7ced42d git log fce7bc9e0825..d683d7ced42d --date=short --no-merges --format='%ad %ae %s' 2018-06-15 mmoss@chromium.org Revert "gclient: Don't allow None URLs (except in .gclient files)" Created with: gclient setdep -r src/third_party/depot_tools@d683d7ced42d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:839925,chromium:853093 TBR=agable@chromium.org Change-Id: Ic2fcedc6339d00e687ff31a3992d237406a95d4a Reviewed-on: https://chromium-review.googlesource.com/1101728 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567573} [modify] https://crrev.com/0f36dbe3faee926ba8e385d0a8814c1608ea7fd7/DEPS |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, May 9 2018