ChromeWebView generate_license step fails |
|||||
Issue description
Running ios/web_view:ios_web_view_generate_license fails with the following error:
[1/2] ACTION //ios/web_view:ios_web_view_generate_license(//build/toolchain/mac:ios_clang_x64)
FAILED: ios_web_view/LICENSE
python ../../tools/licenses.py license_file ios_web_view/LICENSE --gn-target //ios/web_view --gn-out-dir .
Traceback (most recent call last):
File "../../tools/licenses.py", line 756, in <module>
sys.exit(main())
File "../../tools/licenses.py", line 748, in main
args.output_file, args.gn_out_dir, args.gn_target):
File "../../tools/licenses.py", line 701, in GenerateLicenseFile
directory, _REPOSITORY_ROOT, require_license_file=True)
File "../../tools/licenses.py", line 368, in ParseDir
"SPECIAL_CASES entry in %s\n" % path)
__main__.LicenseError: missing README.chromium or licenses.py SPECIAL_CASES entry in third_party/skia/third_party/skcms
ninja: build stopped: subcommand failed.
,
May 4 2018
Issue 839985 has been merged into this issue.
,
May 4 2018
This looks like a problem in Skia, with the way they added this dependency. I'm not sure why we're only noticing this now, given that we added it in January. @mtklein - can you take a look and add a README.chromium or something as appropriate to fix this? I'm not actually seeing much in the Skia repo around this so I'm not sure how you've handled it in the past for similar dependencies.
,
May 5 2018
Issue 840137 has been merged into this issue.
,
May 7 2018
Hey, is third_party/skia/third_party/skcms not covered by third_party/skcms/README.chromium?
,
May 7 2018
Am I missing something? AFAICT, there is no README.chromium.
,
May 7 2018
Oops, typo. I mean third_party/skia/README.chromium. Is third_party/skia/third_party/skcms not covered by third_party/skia/README.chromium?
,
May 7 2018
No, it wouldn't be, at least not by default. Anything under a third_party directory needs its own README.chromium to clarify what the relationship is. It looks like skcms is actually part of Skia (maybe you wrote it)? Why is it in a separate repo?
,
May 7 2018
Yep, we copy its source (skipping test code and data) into Skia with an autoroller, which then rolls out as normal to people who use it.
,
May 7 2018
Okay. Can you add a stub README explaining that? I can double-check what we might need to do to make sure the license script can handle it.
,
May 7 2018
Just curious... if you don't have a cooperative upstream, does this mean you can't DEPS in third_party targets? You have to copy them in and add a README.chromium?
,
May 7 2018
Often we'll create a placeholder directory with the needed file(s) and then put the actual repo in a subdirectory, e.g., //third_party/junit/README.chromium and //third_party/junit/src.
,
May 7 2018
So the problem is just that we sync it into Skia under a directory named third_party? If we sync it into third_party/skia/skcms, it's fine? but third_party/skia/third_party/skcms is not?
,
May 7 2018
Correct. I'm still a bit unclear why it's a separate repo at all, though. I suppose there are other users of just that directory?
,
May 7 2018
,
May 7 2018
Yep, it's standalone, and an optional dependency of Skia. Chromium uses it both directly and indirectly via Skia, and most other clients work the same way, though some just use skcms, and some use Skia without skcms. Why would we care what repo it's in?
,
May 7 2018
I don't really care, just curious.
,
May 8 2018
Issue 840650 has been merged into this issue.
,
May 8 2018
The following revision refers to this bug: https://skia.googlesource.com/skcms/+/ba83c975ac9eff93b8c840fa516ec578aca112dc commit ba83c975ac9eff93b8c840fa516ec578aca112dc Author: Mike Klein <mtklein@chromium.org> Date: Tue May 08 13:22:47 2018 add README.chromium ¯\_(ツ)_/¯ Bug: chromium:839924 Change-Id: I0f97d121bcbb1c0491bdf043361b6815edb61683 Reviewed-on: https://skia-review.googlesource.com/126701 Auto-Submit: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> [add] https://crrev.com/ba83c975ac9eff93b8c840fa516ec578aca112dc/README.chromium
,
May 8 2018
mtklein: Just wondering what's the current plan on this bug. According to issue 840137, this blocks Chrome for iOS' nightly canary build (which impacts our Dev channel) as well as another trybot for our new UI development/testing. Our last successful build was last Wednesday (May 2) evening.
,
May 8 2018
I think we just gotta let that CL up there in #19 roll into Chromium?
,
May 8 2018
Autoroll should work. Thank you for the quick feedback. Sorry that I seemed naggy, our comments 19/20 must have crossed in the ether.
,
May 8 2018
We've just noticed it's going to be an hour or two more than we thought... autorollers configured in funny ways. I definitely don't think it should be a problem past today.
,
May 8 2018
The following revision refers to this bug: https://skia.googlesource.com/buildbot/+/48ce2ac432b0b2308b3bb1cc63264c960077e515 commit 48ce2ac432b0b2308b3bb1cc63264c960077e515 Author: Mike Klein <mtklein@chromium.org> Date: Tue May 08 15:16:04 2018 add README.chromium to skcms->skia whitelist Bug: chromium:839924 Change-Id: Ieccdc33744a5258618d4693b0ea37960b46d6329 Reviewed-on: https://skia-review.googlesource.com/126800 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Ravi Mistry <rmistry@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Ravi Mistry <rmistry@google.com> [modify] https://crrev.com/48ce2ac432b0b2308b3bb1cc63264c960077e515/autoroll/config/skcms-skia.json
,
May 8 2018
The following revision refers to this bug: https://skia.googlesource.com/skcms/+/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e commit 289cedcdb6874b9ebe68ce12c2b620768e6c1b3e Author: Mike Klein <mtklein@chromium.org> Date: Tue May 08 15:24:56 2018 trim end of line whitespace This is mostly a no-op to trigger an skcms->skia roll, but you know, always nice to tidy up. Bug: chromium:839924 Change-Id: I023c11170166bf34bdf2bd41dd1909915443a48a Reviewed-on: https://skia-review.googlesource.com/126821 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com> [modify] https://crrev.com/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e/build/clang.tsan [modify] https://crrev.com/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e/build/clang.m32 [modify] https://crrev.com/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e/build/gcc.avx512 [modify] https://crrev.com/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e/build/android-arm-gcc [modify] https://crrev.com/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e/build/ios.tiny [modify] https://crrev.com/289cedcdb6874b9ebe68ce12c2b620768e6c1b3e/build/android-arm
,
May 10 2018
This is fixed right? |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by michaeldo@chromium.org
, May 4 2018Owner: ----
Status: Available (was: Started)