New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839913 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: May 2018
Cc:
█ elizabethchiu@chromium.org
█ warx@chromium.org
ovanieva@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

KSH - Dynamic spacing between shortcut description and keys

Project Member Reported by wutao@chromium.org, May 4 2018 
Per UX requests:
"lots of white space between text and the shortcut. Can we dynamically adjust the spacing here.. Could we expand dynamically to fill the space"

"For the spacing here, is it possible to detect how much space it is in the middle and readjust the breaking point?"


New specs:
Set the space between the minimum space between "shortcut names" and "shortcuts" to be 64dp.
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc3baf2c77a19772a487d51d44759a88314b3904

commit dc3baf2c77a19772a487d51d44759a88314b3904
Author: wutao <wutao@chromium.org>
Date: Sat May 05 00:30:24 2018

cros: Shortcut Viewer can adjust spacing between text

Currently lots of white space between description and the shortcut. This
cl dynamically adjusts the width of the desciption to fill available
space.

Bug:  839913 
Test: manual.
Change-Id: Ic39f662183faec9eb1ef9b5bfc62bda91ccc61e5
Reviewed-on: https://chromium-review.googlesource.com/1044650
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#556271}
[modify] https://crrev.com/dc3baf2c77a19772a487d51d44759a88314b3904/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc
[modify] https://crrev.com/dc3baf2c77a19772a487d51d44759a88314b3904/ash/components/shortcut_viewer_strings.grdp
Project Member

Comment 2 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ccc9338c77902ad18006d9a79e739b4de60aa9

commit a2ccc9338c77902ad18006d9a79e739b4de60aa9
Author: wutao <wutao@chromium.org>
Date: Mon May 07 20:20:49 2018

Optimize Shortcut Viewer width when it is too small

When calculated |description_view_preferred_width| is too small, we fall
back to previous implementation to set a minimum width for it.

Bug:  839913 
Test: manual
Change-Id: Ie133b2c51ce7359cec8fc4aad563f88791086b8c
Reviewed-on: https://chromium-review.googlesource.com/1048051
Reviewed-by: Qiang Xu <warx@google.com>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556550}
[modify] https://crrev.com/a2ccc9338c77902ad18006d9a79e739b4de60aa9/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc

Comment 3 by wutao@chromium.org, May 8 2018

Description: Show this description

Comment 4 by wutao@chromium.org, May 8 2018

Cc: ovanieva@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment