Issue metadata
Sign in to add a comment
|
RLZ ping no longer being sent in Guest mode |
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3396.26 Chrome OS Version: 10575.22.0 (beta-channel samus) What steps will reproduce the problem? 1) Setup: - In dev mode, set should_send_rlz_ping=1 in RW_VPD - In /etc/chrome_dev.conf set --rlz-ping-delay=60 2) Powerwash 3) Go through OOBE. Don't login with any user. 4) Enter Guest mode. Search in omnibox. What is the expected result? CAF event should be captured after the omnibox search is performed. CAF and CAI events should be sent in RLZ ping after delay has passed. What happens instead? Neither CAF or CAI events are captured or sent in a ping. This is a regression in behavior. Older behavior confirmed on M65 Stable where both CAF and CAI events are captured and sent. This is not considered release blocking for M67 as RLZ pings will eventually be sent for a regular user login, just not Guest mode. But, likely we'll request a merge to M67 if the changes for the fix are simple.
,
May 4 2018
Changing component based on https://cs.chromium.org/chromium/src/components/rlz/OWNERS.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vpd/+/17fd16b23e36148d437014463c08d4356f81d55d commit 17fd16b23e36148d437014463c08d4356f81d55d Author: Thiemo Nagel <tnagel@chromium.org> Date: Tue May 08 11:58:01 2018 dump_vpd_log: Add to filter whitelist Include more VPD keys in the filtered file to support crbug.com/813015 and crbug.com/820800 launches: Product_S/N serial_number should_send_rlz_ping rlz_embargo_end_date BRANCH=none BUG= chromium:823724 , chromium:813015 , chromium:839910 TEST=none Change-Id: Iccbcfaf971aa5b77b71d19c30fcd29fa2b4dd0be Reviewed-on: https://chromium-review.googlesource.com/1041965 Commit-Ready: Thiemo Nagel <tnagel@chromium.org> Tested-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> [modify] https://crrev.com/17fd16b23e36148d437014463c08d4356f81d55d/util/dump_vpd_log
,
May 8 2018
I know it's late in the cycle but we'd like to prevent regressing RLZ for guest mode if we can help it. The change is pretty benign (adding 4 entries to a whitelist) which btw also fixes issue 823724 . (Stephen is a better person to drive this, though, as I only contributed a fix.)
,
May 8 2018
This bug requires manual review: M67 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 9 2018
I've just verified on canary 10661.0.0 that the serial number isn't filtered from VPD anymore.
,
May 10 2018
Approving merge to M67 Chrome OS.
,
May 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/vpd/+/7981ec789af5714b9bed80773f68d7879ba44ee8 commit 7981ec789af5714b9bed80773f68d7879ba44ee8 Author: Thiemo Nagel <tnagel@chromium.org> Date: Thu May 10 20:58:02 2018 dump_vpd_log: Add to filter whitelist Include more VPD keys in the filtered file to support crbug.com/813015 and crbug.com/820800 launches: Product_S/N serial_number should_send_rlz_ping rlz_embargo_end_date BRANCH=none BUG= chromium:823724 , chromium:813015 , chromium:839910 TEST=none Change-Id: Iccbcfaf971aa5b77b71d19c30fcd29fa2b4dd0be Reviewed-on: https://chromium-review.googlesource.com/1041965 Commit-Ready: Thiemo Nagel <tnagel@chromium.org> Tested-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Thiemo Nagel <tnagel@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> (cherry picked from commit 17fd16b23e36148d437014463c08d4356f81d55d) Reviewed-on: https://chromium-review.googlesource.com/1054228 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> [modify] https://crrev.com/7981ec789af5714b9bed80773f68d7879ba44ee8/util/dump_vpd_log
,
May 14 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 17 2018
I've confirmed in testing that Thiemo's changes fix the problem though there's a caveat. Unless .oobe_completed exists, no ping will be sent. So, if the user enters Guest mode right after OOBE and before any regular user login then no ping will be sent while in that Guest mode session. A subsequent Guest mode session will result in a ping. For M69, I plan to disable RLZ entirely for this situation, so I think we can consider this issue fully resolved. If you want to independently test note that the --rlz-ping-delay override switch doesn't seem to be respected for Guest mode, so if you want to avoid the 24 hour delay you'll need to recreate the .oobe_completed file after changing the system clock to pretend it's 24 hours ago, and then change the system clock back.
,
May 18 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 22 2018
,
Nov 8
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pbe...@chromium.org
, May 4 2018