New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839895 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Smoke test crosvm_Sanity are failing on M66 Moblab

Project Member Reported by haddowk@chromium.org, May 4 2018

Issue description

 /usr/local/autotest/site_utils/run_suite.py --pool='' --board=cyan --build=cyan-release/R66-10452.74.0 --suite_name=smoke --retry=True --max_retries=1

05/04 01:56:52.872 ERROR|             utils:0282| [stderr] crosvm_Sanity                           [ FAILED ]
05/04 01:56:52.872 ERROR|             utils:0282| [stderr] crosvm_Sanity                             FAIL: Failed: Expecting 8 CPU cores but found 4 cores

https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/197112773-chromeos-test/chromeos2-row2-rack8-host5/moblab_RunSuite/debug/
 
Cc: pwang@chromium.org
Summary: Smoke test crosvm_Sanity are failing on M66 Moblab (was: Smoke test crosvm_Sanity are failing on M66)

Comment 2 by pwang@chromium.org, May 4 2018

This is intended behavior as we use dedicate generic builds for VM test now. (see crbug.com/710629)
Why cyan want to pass suite:smoke now?
This is a moblab - so the suite "smoke" is being run on the guado_moblab, the cyans are the sub duts connected to the moblab.

This is not a VM it a dut so I am not sure I understand why a VM test is running.
Cc: mattmallett@chromium.org

Comment 5 by pwang@chromium.org, May 4 2018

I do not get the problem here.... To my understanding, moblab itself is just another type of HW devices in the lab serving as a testing server to its underlying DUTs. Thus, neither of them are VM.

This issue sounds like moblab is trying to run suite:smoke against its DUTs without qemu (via script/bin/cros_start_vm)? 
Cc: pprabhu@chromium.org
Adding Prathmesh as I am confused, all I know is the builds for moblab are red now because of this failure.

Prathmesh, do you understand why this test is being run at all on moblab ?  It seems like it is a VM test, but we have no VM on moblab.

Comment 7 by pwang@chromium.org, May 4 2018

I would just recommend deleting moblab_RunSuite/control.smoke from suite:moblab, thus we no longer schedule it on real moblab.

@pprabhu, would delete this affect the MoblabVMTestStage? 

Comment 8 by pwang@chromium.org, May 4 2018

Cc: ihf@chromium.org

Comment 9 by ihf@chromium.org, May 4 2018

suite:smoke is VM only, it should not run on hardware. Hardware runs bvt-* primarily. If you for some reason need an extra suite for moblab, define a new one with no VM specific tests?

Other than that, short term fix sounds like #7.
Owner: pprabhu@chromium.org
Status: Assigned (was: Untriaged)
Owner: haddowk@chromium.org
Re #7, MoblabVMTestStage does not run the smoke suite. It only runs a simple dummyPass suite.

I think way back when moblab HWTest was setup, smoke suite was used. Looks like the right thing to do is to move to bvt suite, now that we've actually broken smoke suite for HW.
This is for the moblab team to field.
-->haddowk for triage.

Just dropping suite smoke is the wrong answer, since we need the coverage that a full test suite provides for moblab. Instead, use bvt-inline or bvt-cq here: http://shortn/_xF4OuxdMya

Comment 12 by ihf@chromium.org, May 9 2018

I would make a new suite that contains 3 client tests (like dummy_Pass and maybe some other super stable client tests) and 3 server tests. After all this just tests that moblab can control a DUT.

But if you want to chose a suite bvt-inline for various reasons is much cleaner than bvt-cq.
https://stainless.corp.google.com/search?col=build&exclude_non_release=true&exclude_cts=true&suite=%5Ebvt%5C-inline%24&row=test&view=matrix&first_date=2018-05-03&last_date=2018-05-09
https://stainless.corp.google.com/search?col=build&exclude_non_release=true&exclude_cts=true&suite=%5Ebvt%5C-cq%24&row=test&view=matrix&first_date=2018-05-03&last_date=2018-05-09

It is just a waste of time to use bvt-* and more flaky than carefully picking a smaller and more stable set.
Cc: shapiroc@chromium.org
Re #12, I agree partially. I think it'd be more effective to have a leaner suite as ihf@ mentioned on guado_moblab-paladin.
OTOH, for guado_moblab-release, I think the moblab team may want the full bvt-* suite, since they want to be sure that partners can indeed run the full suite via moblab.

+shapiroc: Looping in for test planning discussions 
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bfd5bea3c478711bae50394778a28508546b2498

commit bfd5bea3c478711bae50394778a28508546b2498
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Jul 19 01:15:27 2018

[autotest] Add new moblab_BVTInline test to run bvt-inline.

Currently the moblab runs the smoke test - it is for VM only and
fails in some cases.

As recomended run bvt-inline.  Follow on CL to change what the
builder calls.

BUG= chromium:839895 
TEST=None

Change-Id: Ib08b73448afcd68978fe5e630a7a1dd7c56101dd
Reviewed-on: https://chromium-review.googlesource.com/1141161
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[add] https://crrev.com/bfd5bea3c478711bae50394778a28508546b2498/server/site_tests/moblab_RunSuite/control.bvt-inline
[modify] https://crrev.com/bfd5bea3c478711bae50394778a28508546b2498/server/site_tests/moblab_RunSuite/control.smoke

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 2

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/52ac77c38f958aea7927e75946faaed1c3b1a687

commit 52ac77c38f958aea7927e75946faaed1c3b1a687
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Aug 02 00:46:58 2018

[autotest] Add new moblab_BVTInline test to run bvt-inline.

Currently the moblab runs the smoke test - it is for VM only and
fails in some cases.

As recomended run bvt-inline.  Follow on CL to change what the
builder calls.

BUG= chromium:839895 
TEST=None

Change-Id: Ib08b73448afcd68978fe5e630a7a1dd7c56101dd
Reviewed-on: https://chromium-review.googlesource.com/1141161
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
(cherry picked from commit bfd5bea3c478711bae50394778a28508546b2498)
Reviewed-on: https://chromium-review.googlesource.com/1159741
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/52ac77c38f958aea7927e75946faaed1c3b1a687/server/site_tests/moblab_RunSuite/control.bvt-inline
[modify] https://crrev.com/52ac77c38f958aea7927e75946faaed1c3b1a687/server/site_tests/moblab_RunSuite/control.smoke

Status: Fixed (was: Assigned)

Sign in to add a comment