New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839893 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android
Pri: 2
Type: Feature

Blocked on:
issue angleproject:2161
issue 840875
issue 844164

Blocking:
issue angleproject:2549
issue 861814
issue angleproject:2550



Sign in to add a comment

Run the dEQP-GLES 2.0 test suite against the ANGLE Vulkan back-end on Android and Linux

Project Member Reported by jmad...@chromium.org, May 4 2018

Issue description

Currently we only run this back-end on Windows against NVIDIA and AMD. It would be great if we could also run in on Android and a Linux vendor. Android especially will be an important test target.

Yuly could you possibly help with this?

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d6cf24edf2e0cecd1c7782b1c22d3fbf6a81942

commit 9d6cf24edf2e0cecd1c7782b1c22d3fbf6a81942
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Tue May 08 04:15:54 2018

Don't run non-ANGLE gpu tests on Vk N5X GPU.FYI bots

We need to reduce the load on Vk N5X bots in order to be able to run
dEQP Vk tests on them.

Bug:  839893 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I036c98e02e22c269399feed20225ecd6759cb413
Tbr: kbr@chromium.org
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/1048210
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556684}
[modify] https://crrev.com/9d6cf24edf2e0cecd1c7782b1c22d3fbf6a81942/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/9d6cf24edf2e0cecd1c7782b1c22d3fbf6a81942/testing/buildbot/chromium.gpu.fyi.json

Status: Started (was: Assigned)
Blockedon: 840875
Project Member

Comment 4 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/882e2badd22f78c97712737dd5337956b325703e

commit 882e2badd22f78c97712737dd5337956b325703e
Author: Yuly Novikov <ynovikov@google.com>
Date: Fri May 11 02:17:07 2018

Blocking: angleproject:2549
Blocking: angleproject:2550
Project Member

Comment 7 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/81307a3198d56e389c11a78f20f04bb374ba46d6

commit 81307a3198d56e389c11a78f20f04bb374ba46d6
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri May 11 17:45:11 2018

Update dEQP GLES2 expectations for Android Vulkan backend

Bug:  839893 , angleproject:2549,  angleproject:2550 

Change-Id: Id51ad7df2dc225eb6d4e8d4a8668e7e2295d2fa3
Reviewed-on: https://chromium-review.googlesource.com/1054581
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/81307a3198d56e389c11a78f20f04bb374ba46d6/src/tests/deqp_support/deqp_gles2_test_expectations.txt

Project Member

Comment 8 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de4c73a8e0c0db48fb441eb8531145db07d3401e

commit de4c73a8e0c0db48fb441eb8531145db07d3401e
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri May 11 18:36:03 2018

Add GPU FYI Android dEQP Vk bots

Bug:  839893 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8861024bb7cadc741ca8f1b366a95472d125ed90
Reviewed-on: https://chromium-review.googlesource.com/1055107
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557955}
[modify] https://crrev.com/de4c73a8e0c0db48fb441eb8531145db07d3401e/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/de4c73a8e0c0db48fb441eb8531145db07d3401e/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/de4c73a8e0c0db48fb441eb8531145db07d3401e/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/de4c73a8e0c0db48fb441eb8531145db07d3401e/infra/config/global/luci-scheduler.cfg
[modify] https://crrev.com/de4c73a8e0c0db48fb441eb8531145db07d3401e/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/de4c73a8e0c0db48fb441eb8531145db07d3401e/tools/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/79ae37ae3fdf03e77d1a39691a1b8673da12e91c

commit 79ae37ae3fdf03e77d1a39691a1b8673da12e91c
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri May 11 18:48:33 2018

Add GPU FYI Android dEQP Vk bots recipes

Bug:  chromium:839893 
Change-Id: I98d544d77118c3fc5b87c2ee70eaf109f8cd0f6e
Reviewed-on: https://chromium-review.googlesource.com/1054732
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/79ae37ae3fdf03e77d1a39691a1b8673da12e91c/scripts/slave/recipe_modules/chromium_tests/chromium_gpu_fyi.py

Project Member

Comment 10 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e75252451a3a2aff0183228890344180ccd3aa1

commit 8e75252451a3a2aff0183228890344180ccd3aa1
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri May 11 21:02:52 2018

Shard angle_deqp_gles2_vulkan_tests on Android

Bug:  839893 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib50865f70c7038bd6ba69aae675212b9f571b6c3
Tbr: kbr@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1055856
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558015}
[modify] https://crrev.com/8e75252451a3a2aff0183228890344180ccd3aa1/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/8e75252451a3a2aff0183228890344180ccd3aa1/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 11 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f993de114d277efd6b86bca00ad6c9abe9cc3ba8

commit f993de114d277efd6b86bca00ad6c9abe9cc3ba8
Author: angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat May 12 01:52:54 2018

Roll src/third_party/angle/ 586620825..422f2ce24 (5 commits)

https://chromium.googlesource.com/angle/angle.git/+log/586620825ed1..422f2ce24c5b

$ git log 586620825..422f2ce24 --date=short --no-merges --format='%ad %ae %s'
2018-05-10 geofflang GL: Refactor ShaderGL to not hold renderer objects.
2018-05-11 geofflang Request EGL_DONT_CARE version instead of 0 on GL NULL configs.
2018-04-23 lfy GLES1: Renderer (minimal)
2018-05-09 ynovikov Update dEQP GLES2 expectations for Android Vulkan backend
2018-05-04 lucferron Vulkan: Incomplete textures support

Created with:
  roll-dep src/third_party/angle
BUG= chromium:839893 


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ia034b1c82429d878831a8292a9f18c6faeadb61d
Reviewed-on: https://chromium-review.googlesource.com/1056191
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558092}
[modify] https://crrev.com/f993de114d277efd6b86bca00ad6c9abe9cc3ba8/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a8cafcc272f80a51144395e0de84ecc6abefaac

commit 2a8cafcc272f80a51144395e0de84ecc6abefaac
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed May 16 02:59:29 2018

Pass test runner command-line flags to the binary also when listing tests

This allows to apply expectation filters
which are specific to the selected ANGLE backend.

Bug:  839893 
Change-Id: Iafbb487e3eb5ef5400c8b478b350bafba38e0007
Reviewed-on: https://chromium-review.googlesource.com/1056034
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558947}
[modify] https://crrev.com/2a8cafcc272f80a51144395e0de84ecc6abefaac/build/android/pylib/local/device/local_device_gtest_run.py

Cc: bpastene@chromium.org fjhenigman@chromium.org ynovikov@chromium.org
 Issue 842319  has been merged into this issue.
Blockedon: 844164
Project Member

Comment 15 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/f342460dee37a0afd24373e4c18d15bc17a803e7

commit f342460dee37a0afd24373e4c18d15bc17a803e7
Author: Yuly Novikov <ynovikov@google.com>
Date: Tue May 29 23:01:18 2018

Project Member

Comment 16 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/f342460dee37a0afd24373e4c18d15bc17a803e7

commit f342460dee37a0afd24373e4c18d15bc17a803e7
Author: Yuly Novikov <ynovikov@google.com>
Date: Tue May 29 23:01:18 2018

Project Member

Comment 17 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8b0ab6d0c78da7f551a9caa486265caa7fdb2a0

commit f8b0ab6d0c78da7f551a9caa486265caa7fdb2a0
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Tue May 29 23:34:14 2018

Add Android Vulkan ANGLE trybots to LUCI and MB

Bug:  839893 
Change-Id: If9ef931f18994225498be4759e4e7aef43abc47f
Reviewed-on: https://chromium-review.googlesource.com/1077377
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562654}
[modify] https://crrev.com/f8b0ab6d0c78da7f551a9caa486265caa7fdb2a0/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/f8b0ab6d0c78da7f551a9caa486265caa7fdb2a0/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/f8b0ab6d0c78da7f551a9caa486265caa7fdb2a0/tools/mb/mb_config.pyl

Project Member

Comment 18 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d2a732b95b9c85a89d0e801bceb6fb19bb637618

commit d2a732b95b9c85a89d0e801bceb6fb19bb637618
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Tue May 29 23:47:09 2018

Add Android Vulkan bot recipes to tryserver.chromium.angle

Bug:  chromium:839893 
Change-Id: I7163abf47c53a762298bacc239d18c72f429e1a1
Reviewed-on: https://chromium-review.googlesource.com/1077330
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/d2a732b95b9c85a89d0e801bceb6fb19bb637618/scripts/slave/recipe_modules/chromium_tests/trybots.py

Project Member

Comment 19 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/dc0daf8bd9d30848b6e804bb275c567953213407

commit dc0daf8bd9d30848b6e804bb275c567953213407
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed May 30 17:21:06 2018

Add Android Vulkan trybots to ANGLE CQ

Bug:  chromium:839893 
Change-Id: I418d054ca149fb2360606aeee31787f27bec1efa
Reviewed-on: https://chromium-review.googlesource.com/1077760
Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

[modify] https://crrev.com/dc0daf8bd9d30848b6e804bb275c567953213407/infra/config/cq.cfg

Project Member

Comment 20 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23311f5cdd1687f49a80817863b53ce37f7574c1

commit 23311f5cdd1687f49a80817863b53ce37f7574c1
Author: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 31 06:29:08 2018

Roll src/third_party/angle 95fb2a1..86ce210 (5 commits)

https://chromium.googlesource.com/angle/angle.git/+log/95fb2a1..86ce210


git log 95fb2a1..86ce210 --date=short --no-merges --format='%ad %ae %s'
2018-05-22 jmadill@chromium.org Vulkan: Clean up onResourceChanged.
2018-05-30 jmadill@chromium.org Vulkan: Clean up object releasing APIs.
2018-05-18 jmadill@chromium.org Vulkan: Mark some Resource APIs are protected.
2018-05-30 jmadill@chromium.org Vulkan: Make Resource's updateSerial private.
2018-05-29 ynovikov@chromium.org Add Android Vulkan trybots to ANGLE CQ

Created with:
  gclient setdep -r src/third_party/angle@86ce210

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:839893 

TBR=jmadill@chromium.org

Change-Id: Id023a4548840073e574cc861f27f6c0a249092fa
Reviewed-on: https://chromium-review.googlesource.com/1079642
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563163}
[modify] https://crrev.com/23311f5cdd1687f49a80817863b53ce37f7574c1/DEPS

Is work complete here Yuly?
Doesn't work on Linux yet
Cc: lucferron@chromium.org
FYI the Linux bots seem to be running angle_deqp_gles2_vulkan_tests. But they are running on the GL back-end for some reason:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20dEQP%20Release%20%28NVIDIA%29/17680

Looking in the test logs:

WARN: LogGLDebugMessage(158): 
	Source: OpenGL
	Type: Other
	ID: 0x00010000
	Severity: Medium
	Message: Framebuffer unsupported. Framebuffer object 1 is unsupported because the depth and stencil attachments are mismatched.
WARN: checkStatus(626): GL framebuffer returned incomplete.
WARN: LogGLDebugMessage(158): 
	Source: OpenGL
	Type: Other
	ID: 0x00010000
	Severity: Medium
	Message: Framebuffer unsupported. Framebuffer object 1 is unsupported because the depth and stencil attachments are mismatched.
Not supported! Not supported
That's what I've meant by "Doesn't work on Linux yet".
Not many wrangling issues today so far, so maybe I'll try fixing this.
Cool, thanks!
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/caac66bc0d58305e84d0d5e32acff759742ee85f

commit caac66bc0d58305e84d0d5e32acff759742ee85f
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Jun 29 20:52:29 2018

Ensure ANGLE-specific arguments are passed to ChildGTestProcess

Bug:  839893 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I04433ae8f98448817a86f882fa70342c055a4633
Reviewed-on: https://chromium-review.googlesource.com/1121039
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571622}
[modify] https://crrev.com/caac66bc0d58305e84d0d5e32acff759742ee85f/gpu/angle_deqp_tests_main.cc

Status: Fixed (was: Started)
Should work now, as exemplified by https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_angle_deqp_rel_ng/1842
Blocking: 861814

Sign in to add a comment