New issue
Advanced search Search tips

Issue 839862 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

40 KB regression in resource_sizes (MonochromePublic.apk) at 555963:555963

Project Member Reported by cjgrant@google.com, May 4 2018

Issue description

Caused by "[Layered API] Implement std:virtual-list behind a flag"

Commit: 00ef7646f44f96280db6825ca64511b71b73463f

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

The increase looks to be the resources added.  The CL mentions that the resources are at a temporary home.  A few questions:

- Will the resources be moved out before the flag is enabled?
- Is there a bug tracking the move?
- After a suitable long-term home is found, will we still be incurring the same binary size increase, just with files from a different location?

Thanks in advance for clarification!
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=839862

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fd9484136741122d8bd7f3e3de350db058522a32574762a6c304b782d6ae506b


Bot(s) for this bug's original alert(s):

Android Builder Perf
Owner: hirosh...@chromium.org
Assigning to hiroshige@chromium.org because this is the only CL in range:
[Layered API] Implement std:virtual-list behind a flag

This CL imports the virtual-list implementation as-is except for
renaming virtual-list-element.js to index.js.

Original author:
    Valdrin Koshi (valdrin@google.com) and
    Gray Norton (graynorton@google.com)
https://github.com/valdrinkoshi/virtual-list

All code were written and contributed by Googlers
who are Chromium Contributors.

Tentatively this CL imports the files under core/script/resources
until a long-term plan for repository location etc. is settled.

This is a still experimental feature behind a flag, and its
API interface and implementation can be changed significantly
before shipped.

Change-Id: I07071ae2dd17481d3240198f91f28cf0cef5536d
Reviewed-on: https://chromium-review.googlesource.com/1031749
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Alex Russell <slightlyoff@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555963}
Thanks for sheriffing.
This is an expected size increase as I intentionally bundle scripts.

- Will the resources be moved out before the flag is enabled?
No. The resources should be included in the release (e.g. in .apk in this case).
"temporary home" refers to the location in the Chromium source tree (core/script/resource), not to the location where bundled in the release binary (GRIT archive then apk).

- Is there a bug tracking the move?
No.

- After a suitable long-term home is found, will we still be incurring the same binary size increase, just with files from a different location?
Yes.

Status: WontFix (was: Assigned)
Thanks for confirming.  Closing this off.

Sign in to add a comment