New issue
Advanced search Search tips

Issue 839847 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IDL build dependencies broken for ImplementedAs dictionaries

Project Member Reported by rayankans@chromium.org, May 4 2018

Issue description

Annotating a dictionary with ImplementedAs, then referencing the dictionary from another IDL file is broken. 

The problem is tin the build rule: https://cs.chromium.org/chromium/src/third_party/blink/renderer/bindings/scripts/scripts.gni?l=286&rcl=ddf61b968ad5a0225a9efcf3358dbed0a160a341

The generated dependencies only has access to the name of the idl file, and not the ImplementedAs value
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7722bedfc91a8b03ba7209781bdc9385493650b9

commit 7722bedfc91a8b03ba7209781bdc9385493650b9
Author: Rayan Kanso <rayankans@chromium.org>
Date: Mon May 14 14:04:16 2018

Fix IDL compiler dictionary ImplementedAs bug

The dependencies in the build rule use the name of the idl file
containing the dictionary defintion. For the cases where ImplementedAs
is used, the build rule will fail since the generated file matches the
ImplementedAs value.

This CL changes the file name of the generated dictionary implementation
to match the idl name rather than the ImplementedAs name.

Bug:  839847 
Change-Id: Ic5d9dfc82ba90188e26f1206465eb790dc8a193b
Reviewed-on: https://chromium-review.googlesource.com/1044217
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558291}
[modify] https://crrev.com/7722bedfc91a8b03ba7209781bdc9385493650b9/third_party/blink/renderer/bindings/scripts/code_generator_v8.py
[rename] https://crrev.com/7722bedfc91a8b03ba7209781bdc9385493650b9/third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
[rename] https://crrev.com/7722bedfc91a8b03ba7209781bdc9385493650b9/third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.h

Status: Fixed (was: Assigned)

Sign in to add a comment