New issue
Advanced search Search tips

Issue 839829 link

Starred by 1 user
Status: Fixed
Owner:
tzik@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Missing Test]: MiDIOutput.send() doesn't handle timestamp correctly

Project Member Reported by krajshree@chromium.org, May 4 2018 
Automated tests for the below commit have been missing.Would it be possible to add test coverage to avoid regressions in future?

CL: 
----
https://chromium.googlesource.com/chromium/src.git/+/0e5ce9438849cb3ac042e45f8ee964204634be06

Ref Bug: 
---------
https://bugs.chromium.org/p/chromium/issues/detail?id=835664

Thank you.
Project Member

Comment 1 by bugdroid1@chromium.org, May 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcaed64b595c2ff1c78ad83b0c8212a345cb9d72

commit fcaed64b595c2ff1c78ad83b0c8212a345cb9d72
Author: tzik <tzik@chromium.org>
Date: Fri May 18 06:23:13 2018

Add a regression test for MIDIOutput.send() with non-zero timestamp

As a follow up of  http://crbug.com/835664 , this adds a test to cover
the failing code path.

Bug:  839829 
Change-Id: Idd0f6917f9add14233091239f8ee70902cf8faab
Reviewed-on: https://chromium-review.googlesource.com/1061634
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559817}
[modify] https://crrev.com/fcaed64b595c2ff1c78ad83b0c8212a345cb9d72/content/shell/test_runner/mock_web_midi_accessor.cc
[modify] https://crrev.com/fcaed64b595c2ff1c78ad83b0c8212a345cb9d72/content/shell/test_runner/mock_web_midi_accessor.h
[add] https://crrev.com/fcaed64b595c2ff1c78ad83b0c8212a345cb9d72/third_party/WebKit/LayoutTests/webmidi/loopback-with-timestamp.html

Comment 2 by tzik@chromium.org, May 18 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment