New issue
Advanced search Search tips

Issue 839813 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 839816
issue 839818



Sign in to add a comment

Several unit_tests tests fail on first run, pass on retry, due to missing SequencedTaskRunner during PageSignalReceiver::AddObserver

Project Member Reported by w...@chromium.org, May 4 2018

Issue description

Running a Debug build of unit_tests locally I get the following tests listed as needing to be retried:

[8078/8105] WebViewUnitTest.EmbeddedFullscreenDuringScreenCapture_Switching (299 ms)
[8079/8105] WebViewUnitTest.EmbeddedFullscreenDuringScreenCapture_Layout (232 ms)
[8080/8105] WebViewUnitTest.EmbeddedFullscreenDuringScreenCapture_ClickToFocus (252 ms)
[8081/8105] WebViewUnitTest.CrashedOverlayViewOwnedbyClient (239 ms)
[8082/8105] WebViewUnitTest.CrashedOverlayView (228 ms)
[8083/8105] WebDialogWebContentsDelegateTest.OpenURLFromTabTest (416 ms)
[8084/8105] WebDialogWebContentsDelegateTest.DoNothingMethodsTest (247 ms)
[8085/8105] WebDialogWebContentsDelegateTest.DetachTest (263 ms)
[8086/8105] WebDialogWebContentsDelegateTest.AddNewContentsForegroundTabTest (430 ms)
[8087/8105] SyncableFileOperationRunnerTest.Cancel (65 ms)
[8088/8105] SyncInternalsMessageHandlerTest.WriteUserEventZero (123 ms)
[8089/8105] SyncInternalsMessageHandlerTest.WriteUserEventBlank (138 ms)
[8090/8105] SyncInternalsMessageHandlerTest.WriteUserEventBadParse (119 ms)
[8091/8105] SyncInternalsMessageHandlerTest.WriteUserEvent (131 ms)
[8092/8105] SyncInternalsMessageHandlerTest.SendAboutInfoSyncDisabled (125 ms)
[8093/8105] SyncInternalsMessageHandlerTest.RepeatedHandleRegisterForPerTypeCounters (135 ms)
[8094/8105] SyncInternalsMessageHandlerTest.HandleGetAllNodes (110 ms)
[8095/8105] SyncInternalsMessageHandlerTest.AddRemoveObserversSyncDisabled (92 ms)
[8096/8105] SyncInternalsMessageHandlerTest.AddRemoveObserversDisallowJavascript (116 ms)
[8097/8105] DownloadsListTrackerTest.SetSearchTerms (62 ms)
[8098/8105] BrowsingHistoryHandlerTest.MdTruncatesTitles (92 ms)
[8099/8105] AppInfoPermissionsPanelTest.RequiredPermissionsObtainedCorrectly (59 ms)
[8100/8105] AppInfoPermissionsPanelTest.NoPermissionsObtainedCorrectly (93 ms)
[8101/8105] AppInfoDialogViewsTest.ViewInStore (510 ms)
[8102/8105] AppInfoDialogViewsTest.UninstallingOtherAppDoesNotCloseDialog (276 ms)
[8103/8105] AppInfoDialogViewsTest.UninstallingAppClosesDialog (362 ms)
[8104/8105] AppInfoDialogViewsTest.DestroyedProfileClosesDialog (396 ms)
[8105/8105] AppInfoDialogViewsTest.DestroyedOtherProfileDoesNotCloseDialog (288 ms)

They then pass on the retry.  Note that if a test crashes then other tests in the same batch are treated as "unknown" and will need to be retried, so this may be a small number of tests reliably crashing on first run.

[8078/8104] WebViewUnitTest.EmbeddedFullscreenDuringScreenCapture_Switching (308 ms)
[8079/8104] WebViewUnitTest.EmbeddedFullscreenDuringScreenCapture_Layout (265 ms)
[8080/8104] WebViewUnitTest.EmbeddedFullscreenDuringScreenCapture_ClickToFocus (247 ms)
[8081/8104] WebViewUnitTest.CrashedOverlayViewOwnedbyClient (220 ms)
[8082/8104] WebViewUnitTest.CrashedOverlayView (250 ms)
[8083/8104] WebDialogWebContentsDelegateTest.OpenURLFromTabTest (434 ms)
[8084/8104] WebDialogWebContentsDelegateTest.DoNothingMethodsTest (301 ms)
[8085/8104] WebDialogWebContentsDelegateTest.DetachTest (298 ms)
[8086/8104] WebDialogWebContentsDelegateTest.AddNewContentsForegroundTabTest (423 ms)
[8087/8104] SyncInternalsMessageHandlerTest.WriteUserEventZero (122 ms)
[8088/8104] SyncInternalsMessageHandlerTest.WriteUserEventBlank (124 ms)
[8089/8104] SyncInternalsMessageHandlerTest.WriteUserEventBadParse (115 ms)
[8090/8104] SyncInternalsMessageHandlerTest.WriteUserEvent (91 ms)
[8091/8104] SyncInternalsMessageHandlerTest.SendAboutInfoSyncDisabled (93 ms)
[8092/8104] SyncInternalsMessageHandlerTest.RepeatedHandleRegisterForPerTypeCounters (115 ms)
[8093/8104] SyncInternalsMessageHandlerTest.HandleGetAllNodes (93 ms)
[8094/8104] SyncInternalsMessageHandlerTest.AddRemoveObserversSyncDisabled (121 ms)
[8095/8104] SyncInternalsMessageHandlerTest.AddRemoveObserversDisallowJavascript (133 ms)
[8096/8104] DownloadsListTrackerTest.SetSearchTerms (46 ms)
[8097/8104] BrowsingHistoryHandlerTest.MdTruncatesTitles (91 ms)
[8098/8104] AppInfoPermissionsPanelTest.RequiredPermissionsObtainedCorrectly (59 ms)
[8099/8104] AppInfoPermissionsPanelTest.NoPermissionsObtainedCorrectly (55 ms)
[8100/8104] AppInfoDialogViewsTest.ViewInStore (515 ms)
[8101/8104] AppInfoDialogViewsTest.UninstallingOtherAppDoesNotCloseDialog (296 ms)
[8102/8104] AppInfoDialogViewsTest.UninstallingAppClosesDialog (337 ms)
[8103/8104] AppInfoDialogViewsTest.DestroyedProfileClosesDialog (384 ms)
[8104/8104] AppInfoDialogViewsTest.DestroyedOtherProfileDoesNotCloseDialog (201 ms)

 

Comment 1 by w...@chromium.org, May 4 2018

Blockedon: 839816

Comment 2 by w...@chromium.org, May 4 2018

Blockedon: 839818

Comment 3 by w...@chromium.org, May 4 2018

Components: Tests>Flaky
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
Also:

[ RUN      ] BrowsingHistoryHandlerTest.MdTruncatesTitles
[13586:13586:0504/052413.180170:3683701125886:FATAL:sequenced_task_runner_handle.cc(33)] Check failed: ThreadTaskRunnerHandle::IsSet(). Error: This caller requires a sequenced context (i.e. the current task needs to run from a SequencedTaskRunner).
#0 0x7fa8e259989d base::debug::StackTrace::StackTrace()
#1 0x7fa8e22c454c base::debug::StackTrace::StackTrace()
#2 0x7fa8e2335e5a logging::LogMessage::~LogMessage()
#3 0x7fa8e24b3cd9 base::SequencedTaskRunnerHandle::Get()
#4 0x7fa8e6ce8305 mojo::internal::GetTaskRunnerToUseFromUserProvidedTaskRunner()
#5 0x7fa8e6cbe88e mojo::internal::InterfacePtrStateBase::Bind()
#6 0x000002178e78 mojo::internal::InterfacePtrState<>::Bind()
#7 0x000002178962 mojo::InterfacePtr<>::Bind()
#8 0x00000217777c mojo::MakeRequest<>()
#9 0x0000076f79f7 resource_coordinator::PageSignalReceiver::AddObserver()
#10 0x000007961ba5 resource_coordinator::TabManager::ResourceCoordinatorSignalObserver::ResourceCoordinatorSignalObserver()
#11 0x00000794dd46 resource_coordinator::TabManager::TabManager()
#12 0x00000681a9a8 TestingBrowserProcess::GetTabManager()
#13 0x000006814a23 (anonymous namespace)::ChromeUnitTestSuiteInitializer::OnTestStart()
#14 0x000004b4a715 testing::internal::TestEventRepeater::OnTestStart()
#15 0x000004b463b1 testing::TestInfo::Run()
#16 0x000004b46ecf testing::TestCase::Run()
#17 0x000004b59288 testing::internal::UnitTestImpl::RunAllTests()
#18 0x000004b6b58e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#19 0x000004b63612 testing::internal::HandleExceptionsInMethodIfSupported<>()
#20 0x000004b58ee7 testing::UnitTest::Run()
#21 0x00000684c071 RUN_ALL_TESTS()
#22 0x000006848a3b base::TestSuite::Run()
#23 0x0000069a4f80 content::UnitTestTestSuite::Run()
#24 0x000001c96b6d _ZN4base8internal13FunctorTraitsIMNS_7RunLoopEFvvEvE6InvokeIS4_PS2_JEEEvT_OT0_DpOT1_
#25 0x000001c96ae4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMNS_7RunLoopEFvvEJPS4_EEEvOT_DpOT0_
#26 0x000001c96a95 _ZN4base8internal7InvokerINS0_9BindStateIMNS_7RunLoopEFvvEJNS0_17UnretainedWrapperIS3_EEEEEFvvEE7RunImplIS5_NSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NSC_16integer_sequenceImJXspT1_EEEE
#27 0x000002285adc _ZN4base8internal7InvokerINS0_9BindStateIM13ThreadWatcherFvvEJNS0_17UnretainedWrapperI19CustomThreadWatcherEEEEEFvvEE3RunEPNS0_13BindStateBaseE
#28 0x0000052f88fe _ZNO4base12OnceCallbackIFivEE3RunEv
#29 0x0000068519d5 base::(anonymous namespace)::LaunchUnitTestsInternal()
#30 0x000006851825 base::LaunchUnitTests()
#31 0x000006832a31 main
#32 0x7fa8c61402b1 __libc_start_main
#33 0x000001c7c02a _start

All of these failures are failure to find a SequencedTaskRunner in PageSignalReceiver::AddObserver(), it seems.

Comment 4 by w...@chromium.org, May 4 2018

Cc: chrisha@chromium.org
+chrisha, since lpy@ has apparently not visited Monorail in some time. :)

Comment 5 by w...@chromium.org, May 4 2018

Cc: jkrcal@chromium.org
 Issue 839816  has been merged into this issue.

Comment 6 by w...@chromium.org, May 4 2018

Cc: l...@chromium.org
 Issue 839818  has been merged into this issue.

Comment 7 by w...@chromium.org, May 4 2018

Summary: Several unit_tests tests fail on first run, pass on retry, due to missing SequencedTaskRunner during PageSignalReceiver::AddObserver (was: 28 fixtures in unit_tests fail first time, and succeed on retry, in Debug/DCHECK build)
Components: -Infra

Comment 9 by l...@chromium.org, May 4 2018

Cc: -l...@chromium.org
Owner: chrisha@chromium.org
Components: Services>Sync
Labels: Hotlist-TooManyTabs
lpy@ has moved on to other things. I'll try to take a look at this tomorrow.
Ping: Any updates on this? Did you get a chance to investigate?
chrisha@: friendly ping, thanks!
Components: -Internals -Services>Sync Internals>ResourceCoordinator
Sorry, been snowed under with 10th birthday release work. Will bump the priority on this.
I like debug systems.

Sign in to add a comment