New issue
Advanced search Search tips

Issue 839792 link

Starred by 2 users
Status: WontFix
Owner:
dpa...@chromium.org
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Flickering of 'Remove all' button is seen while deleting entries from chrome://settings/siteData

Reported by rp...@etouch.net, May 4 2018 
Version: 68.0.3419.0 (Official Build)  Revision	222512a0ce7deab81dad3af945bad2196e8a8838-refs/heads/master@{#555962}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.5)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/siteData
2. Now click on remove dustbin icon to remove entries(Try to remove all entries) and immediately observe 'Remove all' button 
 
Actual: Flickering of 'Remove all' button is seen while deleting entries from chrome://settings/siteData
Expected: Flickering of 'Remove all' button should not be seen while deleting entries from chrome://settings/siteData

This is a regression issue broken in 'M-64' and below is the manual regression and Narrow bisect info:
Good build : 64.0.3244.0
Bad build : 64.0.3245.0

Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/ff5b6944f36e0e4fcc62d8c65ce07b2b17809291..f61ca1d5f202920c05dbe12f660123ae9bf11f4b?pretty=fuller&n=100
(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)

Suspecting : r509957 from Narrow bisect 

@dschuyler: Could you please help to reassign if your change is not the cause for this change.

NOTE: This issue is also reproducible on M-66 Stable (build # 66.0.3359.139),M-67 Beta (build # 67.0.3396.30) and M-68 Dev (build # 68.0.3409.2).

Thanks!
Actual_video.mp4
237 KB View Download
Expected_video.mp4
237 KB View Download

Comment 1 by dschuyler@chromium.org, May 22 2018

Owner: dpa...@chromium.org
I agree that the suspected CL likely caused the issue. But this is also WAI for that CL. The button is being disabled while the work is being done. (This can be seen if the 'actual' video is stepped through frame by frame).

Though this could be handled a different way if the disabling is undesired. E.g. we could keep the button enabled and ignore clicks on the button while work is in-progress. (though that would create a different bug).

I'm passing this to dpapad@ for a judgement call. My vote is WontFix WAI.

Comment 2 by dpa...@chromium.org, Jun 18 2018

Status: WontFix (was: Assigned)
I am not able to reproduce this. I believe it has been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1044764, which causes the list to be updated in place.
►

Sign in to add a comment