New issue
Advanced search Search tips

Issue 839782 link

Starred by 1 user
Status: Fixed
Owner:
rayankans@chromium.org
Closed: May 2018
Cc:
peria@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

IDL compiler ImplementedAs broken for dictionaries referenced elsewhere

Project Member Reported by rayankans@chromium.org, May 4 2018 
Annotating a dictionary with ImplementedAs, then referencing the dictionary from another IDL file is broken. It seems that the generated file referencing the ImplementedAs dictionary is using the spec name rather than the ImplementedAs name.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/530acee5a1147f5340f31b6129941c3e862dd1f9

commit 530acee5a1147f5340f31b6129941c3e862dd1f9
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri May 04 12:25:28 2018

Fix bug in IDL compiler

I was getting build errors when using ImplementedAs on a dictionary and
referencing it from another dictionary idl file.

The file referencing the ImplementedAs dictionary wasn't using the
ImplementedAs value.

Bug:  839782 
Change-Id: I3c3f91cecf9d6be0b33a7d990a32aabe2a48eefc
Reviewed-on: https://chromium-review.googlesource.com/1042710
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556030}
[modify] https://crrev.com/530acee5a1147f5340f31b6129941c3e862dd1f9/third_party/blink/renderer/bindings/scripts/v8_types.py

Comment 2 by rayankans@chromium.org, May 4 2018

Status: Fixed (was: Assigned)

Comment 3 by raphael....@intel.com, May 4 2018

Labels: M-68
►

Sign in to add a comment