Issue metadata
Sign in to add a comment
|
42% regression in blink_perf.canvas at 555288:555325 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 4 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/107157c3c40000
,
May 4 2018
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/107157c3c40000 Qualify #includes in files generated by make_qualified_names.py. by tkent@chromium.org https://chromium.googlesource.com/chromium/src/+/66e7407fa8b5729ad380bd4c3e52cfc43b9a5db4 blink: Set up a cc::SoftwareImageDecodeCache for canvas image decodes. by khushalsagar@chromium.org https://chromium.googlesource.com/chromium/src/+/49fc8a9c4a9eb46faa2258daea5bdbee48da7dcb Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
May 4 2018
Interestingly the regression is only for drawimage-not-pixelaligned. I don't think this is related to any of the filtering quality changes in this patch. I did a local run with always using medium with both cc and skia cache and I can still repro a regression, avg runs/s going from 5926 to 5337. Need to investigate this more.
,
May 9 2018
It was a false alarm that the regression is drawimage-not-pixelaligned only. There is also a drop in drawimage.html (https://chromeperf.appspot.com/report?sid=8e2e7fb87bed39a25727b98ab61ebdbcae07fb4f961622e1dca1f65c639b9c7e) in the same range. There is definitely no scaling, we use the image at the original size. Again, I think its the extra cost of querying the cache for the image showing up. Its not good that retrieving a cached decode from the cache has this significant cost. I'm going to try to do some profiling to improve this.
,
May 16 2018
,
May 17 2018
,
Jul 25
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, May 4 2018