WebRTC tests should cover IETF video codec requirements |
|
Issue descriptionWe should have Web Platform Tests that test, as far as possible, that Chrome conforms to the IETF protocol requirements for WebRTC browsers. This includes having tests that the VP8 and H.264 video codecs are supported, as well as all the other requirements listed in RFC 7742.
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d1dda318f73e9293d572e08b8773cf137ee7014 commit 8d1dda318f73e9293d572e08b8773cf137ee7014 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue May 08 02:03:11 2018 Revert "Adds a test for basic WebRTC video codec conformance." This reverts commit 72aef1a4cea800fff0d5375c284c6d071cf3d46c. Reason for revert: Failing on Win / Mac / Linux bots Unexpected Failures: * external/wpt/webrtc/protocol/video-codecs.html * virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.html WebKit Win7 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/63947 WebKit Win10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/34576 WebKit Mac10.10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/46846 WebKit Mac10.11 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/32883 WebKit Linux Trusty https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/44403 (It passes on Mac 10.12.) Original change's description: > Adds a test for basic WebRTC video codec conformance. > > This tests that the browser conforms to RFC 7742, "WebRTC Video > Processing and Codec Requrements". > > It establishes a new subdirectory for protocol-related WebRTC tests. > > Bug: chromium:839753 > Change-Id: Ia4795c4532fb74ae76e6a47329a41807479113c5 > Reviewed-on: https://chromium-review.googlesource.com/1043886 > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556454} TBR=mflodman@webrtc.org,hta@chromium.org,foolip@chromium.org Change-Id: Id3789b69df63d7e41be3573ca1fbb5a07b00e7e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:839753 Reviewed-on: https://chromium-review.googlesource.com/1049088 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#556645} [delete] https://crrev.com/ab9fc65b771f4ef4a206a7084aef9aefd73237e1/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/README.txt [delete] https://crrev.com/ab9fc65b771f4ef4a206a7084aef9aefd73237e1/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/video-codecs.html
,
May 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f468ca9093f275ac78b444b4f48c3e887678819 commit 1f468ca9093f275ac78b444b4f48c3e887678819 Author: Harald Alvestrand <hta@chromium.org> Date: Tue May 08 08:38:53 2018 Reland "Adds a test for basic WebRTC video codec conformance." This reverts commit 8d1dda318f73e9293d572e08b8773cf137ee7014. Reason for revert: Now disabling test on relevant platforms. Original change's description: > Revert "Adds a test for basic WebRTC video codec conformance." > > This reverts commit 72aef1a4cea800fff0d5375c284c6d071cf3d46c. > > Reason for revert: Failing on Win / Mac / Linux bots > > Unexpected Failures: > * external/wpt/webrtc/protocol/video-codecs.html > * virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.html > > WebKit Win7 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/63947 > WebKit Win10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/34576 > WebKit Mac10.10 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/46846 > WebKit Mac10.11 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/32883 > WebKit Linux Trusty https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/44403 > > (It passes on Mac 10.12.) > > Original change's description: > > Adds a test for basic WebRTC video codec conformance. > > > > This tests that the browser conforms to RFC 7742, "WebRTC Video > > Processing and Codec Requrements". > > > > It establishes a new subdirectory for protocol-related WebRTC tests. > > > > Bug: chromium:839753 > > Change-Id: Ia4795c4532fb74ae76e6a47329a41807479113c5 > > Reviewed-on: https://chromium-review.googlesource.com/1043886 > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556454} > > TBR=mflodman@webrtc.org,hta@chromium.org,foolip@chromium.org > > Change-Id: Id3789b69df63d7e41be3573ca1fbb5a07b00e7e7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:839753 > Reviewed-on: https://chromium-review.googlesource.com/1049088 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556645} TBR=mflodman@webrtc.org,hta@chromium.org,ksakamoto@chromium.org,foolip@chromium.org Change-Id: I867cf04bfc7cd48afea3b5a26f0af77eef731434 Bug: chromium:839753, chromium:840659 Reviewed-on: https://chromium-review.googlesource.com/1049525 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#556731} [modify] https://crrev.com/1f468ca9093f275ac78b444b4f48c3e887678819/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/1f468ca9093f275ac78b444b4f48c3e887678819/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/README.txt [add] https://crrev.com/1f468ca9093f275ac78b444b4f48c3e887678819/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/video-codecs.html
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89e8f4ddc3551b54158e7b177f756ae81e6bec07 commit 89e8f4ddc3551b54158e7b177f756ae81e6bec07 Author: Harald Alvestrand <hta@chromium.org> Date: Mon May 28 10:10:46 2018 More video protocol tests This bunch of tests uses the getParameters function to get insight into conformance of the video requirements. It tests the codecs after negotiation, and that profile-level-id is always set. Bug: chromium:839753 Change-Id: I607f1ae21320698bd1633be14ae9c33752c16a1c Reviewed-on: https://chromium-review.googlesource.com/1072087 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#562224} [rename] https://crrev.com/89e8f4ddc3551b54158e7b177f756ae81e6bec07/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/video-codecs.https.html
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43c098364c9470c09542798210c828d6c10a562f commit 43c098364c9470c09542798210c828d6c10a562f Author: Olga Sharonova <olka@chromium.org> Date: Mon May 28 11:10:59 2018 Revert "More video protocol tests" This reverts commit 89e8f4ddc3551b54158e7b177f756ae81e6bec07. Reason for revert: failing on WebKit Linux Trusty Leak see: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19437 03:46:20.467 25977 worker/4 virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.https.html output stderr lines: 03:46:20.467 25977 [1:17:0528/034620.208283:ERROR:adm_helpers.cc(73)] Failed to query stereo recording. 03:46:20.467 25977 [1:16:0528/034620.408117:WARNING:rtpreceiver.cc(273)] VideoRtpReceiver::Stop: No video channel exists. 03:46:20.467 25977 [1:16:0528/034620.412041:WARNING:rtpreceiver.cc(273)] VideoRtpReceiver::Stop: No video channel exists. 03:46:20.468 25977 [1:16:0528/034620.414673:WARNING:rtpreceiver.cc(273)] VideoRtpReceiver::Stop: No video channel exists. 03:46:20.469 25819 [1846/6906] virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.https.html failed unexpectedly (asserts failed) 03:46:20.468 25977 worker/4 virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.https.html failed: 03:46:20.468 25977 worker/4 asserts failed Original change's description: > More video protocol tests > > This bunch of tests uses the getParameters function to get insight into > conformance of the video requirements. > > It tests the codecs after negotiation, and that profile-level-id is > always set. > > Bug: chromium:839753 > Change-Id: I607f1ae21320698bd1633be14ae9c33752c16a1c > Reviewed-on: https://chromium-review.googlesource.com/1072087 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562224} TBR=hta@chromium.org,guidou@chromium.org,orphis@chromium.org Change-Id: I35685e607a3ea2cabcf7971a652b93298366e1b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:839753 Reviewed-on: https://chromium-review.googlesource.com/1075067 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562231} [rename] https://crrev.com/43c098364c9470c09542798210c828d6c10a562f/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/video-codecs.html
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce436965701017f4a122c9ba209805415dedd3bd commit ce436965701017f4a122c9ba209805415dedd3bd Author: Harald Alvestrand <hta@chromium.org> Date: Mon May 28 12:23:38 2018 Reland "More video protocol tests" This reverts commit 43c098364c9470c09542798210c828d6c10a562f. Reason for revert: Updated TestExpectations to reflect test name change Original change's description: > Revert "More video protocol tests" > > This reverts commit 89e8f4ddc3551b54158e7b177f756ae81e6bec07. > > Reason for revert: failing on WebKit Linux Trusty Leak > see: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/19437 > > 03:46:20.467 25977 worker/4 virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.https.html output stderr lines: > 03:46:20.467 25977 [1:17:0528/034620.208283:ERROR:adm_helpers.cc(73)] Failed to query stereo recording. > 03:46:20.467 25977 [1:16:0528/034620.408117:WARNING:rtpreceiver.cc(273)] VideoRtpReceiver::Stop: No video channel exists. > 03:46:20.467 25977 [1:16:0528/034620.412041:WARNING:rtpreceiver.cc(273)] VideoRtpReceiver::Stop: No video channel exists. > 03:46:20.468 25977 [1:16:0528/034620.414673:WARNING:rtpreceiver.cc(273)] VideoRtpReceiver::Stop: No video channel exists. > 03:46:20.469 25819 [1846/6906] virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.https.html failed unexpectedly (asserts failed) > 03:46:20.468 25977 worker/4 virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/protocol/video-codecs.https.html failed: > 03:46:20.468 25977 worker/4 asserts failed > > Original change's description: > > More video protocol tests > > > > This bunch of tests uses the getParameters function to get insight into > > conformance of the video requirements. > > > > It tests the codecs after negotiation, and that profile-level-id is > > always set. > > > > Bug: chromium:839753 > > Change-Id: I607f1ae21320698bd1633be14ae9c33752c16a1c > > Reviewed-on: https://chromium-review.googlesource.com/1072087 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Commit-Queue: Harald Alvestrand <hta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#562224} > > TBR=hta@chromium.org,guidou@chromium.org,orphis@chromium.org > > Change-Id: I35685e607a3ea2cabcf7971a652b93298366e1b8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:839753 > Reviewed-on: https://chromium-review.googlesource.com/1075067 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562231} TBR=hta@chromium.org,guidou@chromium.org,olka@chromium.org,orphis@chromium.org Change-Id: Id8f74407371d9b58401c9a898235b789844b2cb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:839753 Reviewed-on: https://chromium-review.googlesource.com/1075068 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#562234} [modify] https://crrev.com/ce436965701017f4a122c9ba209805415dedd3bd/third_party/WebKit/LayoutTests/TestExpectations [rename] https://crrev.com/ce436965701017f4a122c9ba209805415dedd3bd/third_party/WebKit/LayoutTests/external/wpt/webrtc/protocol/video-codecs.https.html |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, May 7 2018