New issue
Advanced search Search tips

Issue 839747 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Multiple HeadlessRenderBrowserTests are flaky on Linux dbg

Project Member Reported by treib@chromium.org, May 4 2018

Issue description

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=headless_browsertests&tests=HeadlessRenderBrowserTest

Failing tests are:
HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest
HeadlessRenderBrowserTestRedirectInvalidUrl.RunAsyncTest
HeadlessRenderBrowserTestServerRedirectToFailure.RunAsyncTest

Seems to have started recently, first failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71801
I couldn't immediately find anything that looks related in the blamelist.
 

Comment 1 by treib@chromium.org, May 4 2018

Failures look like this:
[0503/224938.648626:FATAL:thread_load_tracker.cc(81)] Check failed: time_ <= now (8714267944 bogo-microseconds vs. 10010000 bogo-microseconds)
Cc: headless-dev@chromium.org
+headless-dev@ to help triage while FindIt is trying to find the CL that caused this
Might also be due to https://chromium-review.googlesource.com/c/chromium/src/+/988833 which was just reverted.
Flakes have continued in builds (71808) after the revert landed(71807):

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/71808

I'll put together a patch to disable the flaking tests until headless-dev@ can triage further.
Starting with just the test that recently flaked, to see if the revert mentioned in #4 fixed the others.

https://chromium-review.googlesource.com/c/chromium/src/+/1044303
Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37711150a587c46d52e2cb8c7588e09d8f47befe

commit 37711150a587c46d52e2cb8c7588e09d8f47befe
Author: jonross <jonross@chromium.org>
Date: Fri May 04 16:00:56 2018

Disable flaky HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest

A series of HeadlessRenderBrowserTests have been failing. A suspected fix to
some of them has landed.

However HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest still
fails. This disables it on Linux until the team can provide a fix.

TEST=HeadlessRenderBrowserTestCookieSetFromJs_NoCookies.RunAsyncTest
TBR=eseckler@chromium.org

Bug:  839747 
Change-Id: I526358528bd6b1922afc930db213be183426ae07
Reviewed-on: https://chromium-review.googlesource.com/1044303
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556072}
[modify] https://crrev.com/37711150a587c46d52e2cb8c7588e09d8f47befe/headless/test/headless_render_browsertest.cc

Labels: -Sheriff-Chromium
Owner: eseckler@chromium.org
Setting eseckler@ as the owner based randomly on the owners file. Until headless-dev@ has a chance to triage.

With the known flake disabled I'm removing the sheriff label, but will keep an eye out for others.
Project Member

Comment 10 by bugdroid1@chromium.org, May 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb054ef275af619e1790098622908e2d0d992ff9

commit fb054ef275af619e1790098622908e2d0d992ff9
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon May 07 11:00:42 2018

Disable flaky HeadlessRenderBrowserTests on Linux

TBR=eseckler@chromium.org

Bug:  839747 
Change-Id: Ic98a3b585163f663c983403d34d958460658c884
Reviewed-on: https://chromium-review.googlesource.com/1046597
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556410}
[modify] https://crrev.com/fb054ef275af619e1790098622908e2d0d992ff9/headless/test/headless_render_browsertest.cc

Cc: -headless-dev@chromium.org
Owner: caseq@chromium.org
Status: Available (was: Untriaged)
Off to caseq@ since all these tests seem to be network related and caseq is working on refactoring networking in headless for compatibility with the network service. I'm not sure if we should tackle these flakes before that's resolved, wdyt?
Status: Assigned (was: Available)
Status: Fixed (was: Assigned)
These tests don't seem to be flaky anymore, likely as a result of both tests and underlying network interception layer being rewritten.

Sign in to add a comment