New issue
Advanced search Search tips

Issue 839745 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

innerText considers display:contents elements as not being rendered.

Project Member Reported by futhark@chromium.org, May 4 2018

Issue description

Fails innerText for display:contents with whitespaces in [1].

[1] external/wpt/html/dom/elements/the-innertext-idl-attribute/getter.js

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1db9cd28e195d4af700dc841988282de7c58bbd6

commit 1db9cd28e195d4af700dc841988282de7c58bbd6
Author: Rune Lillesveen <futhark@chromium.org>
Date: Mon May 28 21:03:43 2018

Display:contents elements are "rendered" for innerText.

We incorrectly returned textContent for display:contents elements.

Bug:  839745 
Change-Id: I94be65c758a9a4a85693d0364fd305cbc806c162
Reviewed-on: https://chromium-review.googlesource.com/1043945
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562310}
[modify] https://crrev.com/1db9cd28e195d4af700dc841988282de7c58bbd6/third_party/WebKit/LayoutTests/external/wpt/html/dom/elements/the-innertext-idl-attribute/getter-expected.txt
[modify] https://crrev.com/1db9cd28e195d4af700dc841988282de7c58bbd6/third_party/blink/renderer/core/dom/element.cc

Status: Fixed (was: Started)

Sign in to add a comment