New issue
Advanced search Search tips

Issue 839734 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Layout Test paint/invalidation/table/table-hover-on-link.html is failing

Project Member Reported by treib@chromium.org, May 4 2018

Issue description

The following layout test is failing on Linux

paint/invalidation/table/table-hover-on-link.html
virtual/disable-spv175/paint/invalidation/table/table-hover-on-link.html

Probable cause:

https://chromium-review.googlesource.com/c/chromium/src/+/1041573

 

Comment 2 by treib@chromium.org, May 4 2018

Since this was a pretty big CL and revert likely wouldn't land cleanly, I'll mark the test as flaky instead. Please investigate and fix soon.

Comment 3 by treib@chromium.org, May 4 2018

Components: Tests>Flaky
Project Member

Comment 4 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/759127140a311342ea1cfa696fe283ecb7946fe5

commit 759127140a311342ea1cfa696fe283ecb7946fe5
Author: Marc Treib <treib@chromium.org>
Date: Fri May 04 10:34:25 2018

Mark paint/invalidation/table/table-hover-on-link.html as flaky on Linux

TBR=wangxianzhu@chromium.org

Bug:  839734 
Change-Id: Ic35abab341a46e52d2586f2f5515bf0701f96fec
Reviewed-on: https://chromium-review.googlesource.com/1043985
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556025}
[modify] https://crrev.com/759127140a311342ea1cfa696fe283ecb7946fe5/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by treib@chromium.org, May 4 2018

Labels: -Sheriff-Chromium
Labels: -Pri-1 Pri-2
My CL just changed some names, so it can't be the cause of the flaky. Also the test had been flaky before my change. Anyway I will look into it.
Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/565fdb2d7c48b7b6d839b7d5e16e4967be72f652

commit 565fdb2d7c48b7b6d839b7d5e16e4967be72f652
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri May 04 17:05:39 2018

[PE] Deflake paint/invalidation/table/table-hover-on-link.html

The test flakily failed in the following ways:
1. Hover state was not applied and the background was still red. The
   test perhaps finished before the hover state was visualized.
2. The actual result showed net::ERR_FILE_NOT_FOUND. This was perhaps
   caused by the click.

Now
1. Use runAfterLayoutAndPaint() before the test finishes;
2. Remove the click. Just hover.

Also simplify the test and convert it into a ref test.

Bug:  839734 
Change-Id: I0c5e0a1b0ef2319c6c8d9809fac9cbd4bd0732d0
Reviewed-on: https://chromium-review.googlesource.com/1044489
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556092}
[modify] https://crrev.com/565fdb2d7c48b7b6d839b7d5e16e4967be72f652/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/565fdb2d7c48b7b6d839b7d5e16e4967be72f652/third_party/WebKit/LayoutTests/paint/invalidation/table/table-hover-on-link-expected.html
[delete] https://crrev.com/a32dc902e72b9a32665a979bd86af7cd471c3fc5/third_party/WebKit/LayoutTests/paint/invalidation/table/table-hover-on-link-expected.txt
[modify] https://crrev.com/565fdb2d7c48b7b6d839b7d5e16e4967be72f652/third_party/WebKit/LayoutTests/paint/invalidation/table/table-hover-on-link.html
[delete] https://crrev.com/a32dc902e72b9a32665a979bd86af7cd471c3fc5/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/table-hover-on-link-expected.png
[delete] https://crrev.com/a32dc902e72b9a32665a979bd86af7cd471c3fc5/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/table/table-hover-on-link-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment