Text is seen chopped in remove extension overlay when 'views-browser-windows' flag is enabled.
Reported by
shruti.j...@etouch.net,
May 4 2018
|
||||||||
Issue descriptionChrome Version: 68.0.3418.2 (Official Build) Revision 21ed427687d402ad4eb216ae47655d044bce655a-refs/branch-heads/3418@{#4}(64-bit) OS:Mac (10.12.6, 10.13.1, 10.13.5) Pre-Condition:Enable 'Use Views browser windows instead of Cocoa'from chrome://flags. Test URL:https://chrome.google.com/webstore/detail/honey/bmnlcjabgnpnenekpadlanbbkooimhnj Steps to reproduce: 1.Launch chrome and navigate to above URL and download the extensiom. 2.Right click on extension icon in omnibox and click on 'Remove from chrome' 3.Observe the 'Remove from chrome' overlay . Actual Result : Contents get chopped ('Report abuse') in 'Remove from chrome' overlay . Expected Result :Contents should not get chopped ('Report abuse') in 'Remove from chrome' overlay . This is a Non-regression issue seen from ‘M-67’ series(#67.0.3381.0) Note: 1.Issue is MAC Specific only. 2.This happens for couple of extension remove overlay. Kindly review the attached screen-cast . Thank You!
,
May 4 2018
,
May 4 2018
,
May 4 2018
Assigning to ellyjones for macviews triage to get it out of the extensions queue (Elly, let me know if there's something else you'd prefer me to do with these in the future).
,
May 7 2018
macviews triage: to spqchan@ :)
,
May 17 2018
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91b4468da17d6cf74c60042ac5ee0a56a764dd97 commit 91b4468da17d6cf74c60042ac5ee0a56a764dd97 Author: spqchan <spqchan@chromium.org> Date: Thu May 24 18:50:10 2018 [MacViews] Fix Incorrect Bubble Window Bounds When BubbleDialogDelegateView::SizeToContents() is called, it doesn't take into account that the bounds from GetBubbleBounds() doesn't include the NSWindow's style. This causes the SizeToContents() to potentially set the bubble window's bounds to an incorrect value. Bug: 839709 Change-Id: I6e27ff4f30673b5f7c26b68459be1e1cdac51587 Reviewed-on: https://chromium-review.googlesource.com/1069541 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561575} [modify] https://crrev.com/91b4468da17d6cf74c60042ac5ee0a56a764dd97/ui/views/BUILD.gn [modify] https://crrev.com/91b4468da17d6cf74c60042ac5ee0a56a764dd97/ui/views/bubble/bubble_dialog_delegate.cc [add] https://crrev.com/91b4468da17d6cf74c60042ac5ee0a56a764dd97/ui/views/widget/widget_utils_mac.h [add] https://crrev.com/91b4468da17d6cf74c60042ac5ee0a56a764dd97/ui/views/widget/widget_utils_mac.mm
,
May 25 2018
Update : Rechecked the above issue on Mac OS X(10.12.6,10.13.1,10.13.5) OS using latest Canary Chrome version : 68.0.3440.0 and the issue is fixed.Text contents is seen properly in remove extension overlay.Kindly refer the attached screen cast for reference.
,
May 25 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by shruti.j...@etouch.net
, May 4 2018