New issue
Advanced search Search tips

Issue 839699 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Pinned Crostini apps not removed on uninstall

Project Member Reported by timloh@chromium.org, May 4 2018

Issue description

Upon uninstall of Crostini apps (e.g. apt-get remove, or removing Crostini entirely), the app list is updated but apps pinned on the shelf remain.
 
Components: OS>Systems>Containers
Components: OS>Systems>Containers
Labels: Hotlist-Crostini-UI
Project Member

Comment 4 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c6293de2931fae672f1f2efdc4ba509a7d496b1

commit 7c6293de2931fae672f1f2efdc4ba509a7d496b1
Author: Timothy Loh <timloh@chromium.org>
Date: Mon May 14 02:22:04 2018

Remove pinned Crostini apps on uninstall

This CL adds a LauncherCrostiniAppUpdater that ensures the Shelf knows
about app uninstallation so it can remove pinned Crostini apps.

TEST=Manually uninstalled an app and saw the pin disappear. Manually
uninstalled Crostini and saw pins disappear.

Bug:  839699 
Change-Id: I81e6b60414ad8766ef159a9ea3969809beb5112c
Reviewed-on: https://chromium-review.googlesource.com/1046605
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558175}
[modify] https://crrev.com/7c6293de2931fae672f1f2efdc4ba509a7d496b1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/7c6293de2931fae672f1f2efdc4ba509a7d496b1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[add] https://crrev.com/7c6293de2931fae672f1f2efdc4ba509a7d496b1/chrome/browser/ui/ash/launcher/launcher_crostini_app_updater.cc
[add] https://crrev.com/7c6293de2931fae672f1f2efdc4ba509a7d496b1/chrome/browser/ui/ash/launcher/launcher_crostini_app_updater.h

Comment 5 by timloh@chromium.org, May 14 2018

Status: Fixed (was: Started)

Comment 6 by timloh@chromium.org, May 14 2018

Labels: -Restrict-View-Google

Sign in to add a comment