New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839691 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

VK pops up automatically while opening Settings page from VK's menu list

Project Member Reported by xiulingw@chromium.org, May 4 2018

Issue description

Version 68.0.3417.0(Official build) canary (32 bit)
Platform 10643.0.0(official build) canary-channel link 
Firmware Google_Link.2695.1.169


REPRO STEPS:
1.Switch to any keyboard (Dock or Floating mode)
2.Click Menu list, select Settings button


Actual result:
VK pops up as soon as the Settings page pops up.

Note:
1.VK does not pop up if open Settings page from by system menu.
2.This issue did not repro on the prior version.

 
May 4 2018 11_25 AM.webm
301 KB View Download
VK does not pop up if open Settings page from the opt-menu.
Owner: shend@chromium.org
Darren,
Is the bug relate to your recent change?

Comment 4 by shend@chromium.org, May 4 2018

Hmm I don't think so...bug still repros in 68.0.3419.0, which includes my revert in https://chromium-review.googlesource.com/c/chromium/src/+/1041445 . I also landed a patch an hour ago (https://chromium-review.googlesource.com/c/chromium/src/+/1015446), but that's not in that version.

xiulingw@, what was the prior working version number?
I do not remember the exact version number, and i'm trying to find the version which is fine. Shall i tell the number once find it? Thanks.
Tried 66.0.3344.0 dev (10399.0.0) version is fine.
Tried and found the last version without this issue (On Clapper): 

66.0.3355.0(Official Build) dev (64-bit)
10442.0.0(Official Build) dev-channel Clapper
10442.0.0.webm
2.2 MB View Download

Comment 8 by shend@chromium.org, May 7 2018

Cc: shend@chromium.org
Owner: blakeo@chromium.org
Thanks xiulingw@! Based on that version information, could this CL have caused the issue: https://chromium.googlesource.com/chromium/src/+/89c26e1a35c53d98481bd3bbb3847293f0684513 ? ShowKeyboardIfWithinTransientBlurThreshold might be triggered, causing the keyboard to show.




My pleasure.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c5f676c9642f538e49453a8445a9b8c6a97b22b

commit 2c5f676c9642f538e49453a8445a9b8c6a97b22b
Author: Blake O'Hare <blakeo@chromium.org>
Date: Sat Jun 02 10:19:01 2018

Clear transient blur threshold when clicking the VK settings link

The settings menu has an auto-focused search field. Because the
keyboard has a direct settings link button, clicking the link will
activate the settings menu which will clear the keyboard. Then when the
HTML loads, the keyboard comes back due to the transient blur
heurisitc.

Solution is to dismiss the keyboard, which will set the transient blur
timeout value, and then manually clear it. Then when the settings page
appears, it will not open the keyboard.

Only clearing the timeout from the API is not sufficient, since it is
the invocation of the settings menu that dismisses the keyboard and
will reset the timeout.

Bug:  839691 
Change-Id: Ic54a7590f905a00c43bd13cb152354e7100fe0b1
Reviewed-on: https://chromium-review.googlesource.com/1049409
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563940}
[modify] https://crrev.com/2c5f676c9642f538e49453a8445a9b8c6a97b22b/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/2c5f676c9642f538e49453a8445a9b8c6a97b22b/ui/keyboard/keyboard_controller.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on the latest version: 69.0.3451.0, 10757.0.0.

Sign in to add a comment