New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839676 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Terminal window also handled as Chromium

Project Member Reported by timloh@chromium.org, May 4 2018

Issue description

The Terminal window is being handled both by the Terminal app and the Chromium app. Potentially causing some of the multi-profile issues?
 
Screenshot 2018-05-04 at 11.53.25.png
24.1 KB View Download
Components: OS>Systems>Containers
i wonder if changing the crosh extension to a v2 app would help with this.  it doesn't have any of the weirdness that v1.5 apps need (shared cookie jar).
Cc: rjwright@chromium.org
It probably would, but maybe we can hardcode some fix in the meantime.
Cc: -rjwright@chromium.org benwells@chromium.org nverne@chromium.org
Owner: rjwright@chromium.org
Status: Assigned (was: Available)
Labels: Hotlist-Crostini-UI

Comment 5 by vapier@chromium.org, May 23 2018

Labels: -Restrict-View-Google allpublic
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be2b4c69f67f4da82c9343c3082d77db96a63c52

commit be2b4c69f67f4da82c9343c3082d77db96a63c52
Author: Timothy Loh <timloh@chromium.org>
Date: Fri May 25 02:23:12 2018

Don't show Crostini Terminal windows in the list of Chrome browsers

Bug: 839676
Change-Id: I203a06e7c4136f0d359d265010bd9b74ee08426a
Reviewed-on: https://chromium-review.googlesource.com/1071492
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561738}
[modify] https://crrev.com/be2b4c69f67f4da82c9343c3082d77db96a63c52/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc

Tim has fixed one manifestation of this issue (Crostini Terminal showing in the list of browsers). There is another problem: clicking the Crostini Teminal icon causes the Terminal to maximize from or minimize to the Chrome icon. I'll close this bug once I fix that. The broader issue of how to package Crostini Terminal will be tracked under a different bug.
Labels: -Pri-2 Pri-1
More general bug: crbug.com/846546
Labels: M-70
Moving to M70.

Sign in to add a comment