New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839667 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove CreateClassicRemoteDeviceForTest()

Project Member Reported by hansberry@chromium.org, May 4 2018

Issue description

Whoa, I didn't even realize that that file existed!

We may also want to just phase it out in favor of https://cs.chromium.org/chromium/src/components/cryptauth/remote_device_test_util.h.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43c54509d44f031e04ff806b9de1a335e566be1e

commit 43c54509d44f031e04ff806b9de1a335e566be1e
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri May 04 22:51:37 2018

CryptAuth: Remove BT Classic test method.

R=hansberry@chromium.org

Bug:  839667 
Test: none
Change-Id: I2c5b269bb1c526d73e3282ccd9c384e59b8b81b1
Reviewed-on: https://chromium-review.googlesource.com/1045165
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556228}
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/chromeos/components/proximity_auth/messenger_impl_unittest.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/chromeos/components/proximity_auth/unlock_manager_impl_unittest.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/components/cryptauth/BUILD.gn
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc
[delete] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/components/cryptauth/cryptauth_test_util.cc
[delete] https://crrev.com/a97b45a124fb93b11ce1841ba19ae4ae8cbec739/components/cryptauth/cryptauth_test_util.h
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/components/cryptauth/device_to_device_authenticator_unittest.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/components/cryptauth/remote_device_test_util.cc
[modify] https://crrev.com/43c54509d44f031e04ff806b9de1a335e566be1e/components/cryptauth/remote_device_test_util.h

Status: Fixed (was: Started)

Sign in to add a comment