Remove SLOW and NEEDSMANUALREBASELINE from expectation of WebKit layout tests |
|
Issue descriptionSLOW: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/SlowTests https://chromium.googlesource.com/chromium/src/+/9098f900d68af46e15806188fb60f51c1682207a/third_party/WebKit/LayoutTests/TestExpectations#4227 NEEDSMANUALREBASELINE: https://chromium.googlesource.com/chromium/src/+/9098f900d68af46e15806188fb60f51c1682207a/third_party/WebKit/LayoutTests/fast/harness/results.html#954 https://chromium.googlesource.com/chromium/src/+/9098f900d68af46e15806188fb60f51c1682207a/third_party/WebKit/LayoutTests/TestExpectations#3777
,
May 4 2018
No, they don't show up in `actual` values. (Sorry, forgot to make it clear on that) To avoid further confusion, I've rephrased my comments from the CL as below. Based on the 120-day data below, SLOW, NEEDSMANUALREBASELINE and LEAK do show up in run.expected, while 'TEXT', 'AUDIO', 'IMAGE', 'IMAGE_TEXT' and 'MISSING' do not show up in run.expected. Are all these legal? If yes, we could close this bug; otherwise, let's keep it open. Either way, this does affect the query to find flaky test failures on CQ: https://chromium-review.googlesource.com/c/infra/infra/+/1031017/13/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql#278 --------------- 120-day data in step '%webkit_layout_test%', values showed up in `actual` ----------------- 1 PASS 2 MISSING 3 LEAK 4 TEXT 5 SKIP 6 IMAGE_TEXT 7 CRASH 8 IMAGE 9 TIMEOUT --------------- 120-day data in step '%webkit_layout_test%', values showed up in `expected` ----------------- 1 TIMEOUT 2 SLOW 3 PASS 4 CRASH 5 WONTFIX 6 LEAK 7 SKIP 8 FAIL 9 NEEDSMANUALREBASELINE |
|
►
Sign in to add a comment |
|
Comment 1 by dpranke@chromium.org
, May 4 2018