New issue
Advanced search Search tips

Issue 839645 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 838658



Sign in to add a comment

Support for profiling on Android/Linux using simpleperf for Telemetry

Project Member Reported by nednguyen@chromium.org, May 3 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/f0ae6bb58a452c1c129858c17359e56539d3da76

commit f0ae6bb58a452c1c129858c17359e56539d3da76
Author: Nghia Nguyen <nednguyen@google.com>
Date: Fri May 04 12:16:22 2018

Define simple_perf attribute in BrowserFinderOptions directly

Bug: chromium:839645
Change-Id: I363d008afe903d332329e08e5369cba83a023820
Reviewed-on: https://chromium-review.googlesource.com/1043021
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/f0ae6bb58a452c1c129858c17359e56539d3da76/telemetry/telemetry/internal/browser/browser_options.py
[modify] https://crrev.com/f0ae6bb58a452c1c129858c17359e56539d3da76/telemetry/telemetry/page/shared_page_state.py

Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73bc32d061b88963b09690db5d4059210784f93c

commit 73bc32d061b88963b09690db5d4059210784f93c
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 04 14:40:46 2018

Roll src/third_party/catapult/ 4f42243e8..f0ae6bb58 (1 commit)

https://chromium.googlesource.com/catapult.git/+log/4f42243e85c8..f0ae6bb58a45

$ git log 4f42243e8..f0ae6bb58 --date=short --no-merges --format='%ad %ae %s'
2018-05-04 nednguyen Define simple_perf attribute in BrowserFinderOptions directly

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Iad036eef3380833c35c375601aec69225c3189e5
Reviewed-on: https://chromium-review.googlesource.com/1044225
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#556047}
[modify] https://crrev.com/73bc32d061b88963b09690db5d4059210784f93c/DEPS

Cc: sullivan@chromium.org
Blockedon: 838658
Summary: Support for profiling on Android/Linux using simpleperf for Telemetry (was: Support for profiling on Android using simpleperf for Telemetry)
Project Member

Comment 7 by bugdroid1@chromium.org, May 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c54abf5f77824bd37ddab41df116845cc05f63b5

commit c54abf5f77824bd37ddab41df116845cc05f63b5
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 15 03:28:29 2018

Roll src/third_party/catapult/ dd13313c3..075ca3000 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/dd13313c34d3..075ca3000abf

$ git log dd13313c3..075ca3000 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 kendaljharland Support fuchsia project revisions in tooltips.
2018-05-14 szager Rename browser_simpleperf_controller to browser_interval_profiling_controller.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: If1d98d42fab9b95555eb658fcda29abf3740a075
Reviewed-on: https://chromium-review.googlesource.com/1058683
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558600}
[modify] https://crrev.com/c54abf5f77824bd37ddab41df116845cc05f63b5/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63c450575899b85d59064c0c83c86fb0833c28b8

commit 63c450575899b85d59064c0c83c86fb0833c28b8
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 16 23:24:39 2018

Roll src/third_party/catapult/ d95db22a6..a7e134aa0 (8 commits)

https://chromium.googlesource.com/catapult.git/+log/d95db22a613c..a7e134aa0dbf

$ git log d95db22a6..a7e134aa0 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 szager Refactor browser_interval_profiling_controller
2018-05-16 benjhayden Add google-signin to third_party/polymer2.
2018-05-16 nednguyen Add logging of the apk name picked by android backend settings
2018-05-16 benjhayden Add paper-checkbox to third_party/polymer2.
2018-05-16 benjhayden Add polymer-redux to third_party.
2018-05-16 eyaich Updating telemetry smoke-test-mode flag to not take a value
2018-05-16 benjhayden Add paper-input to third_party/polymer2.
2018-05-16 nednguyen Make sure Telemetry use <benchmark>/<story_name> consistenly when printing to stdout

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645,chromium:843516, chromium:840427 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I25330250acecec6a49829102e25e07ff8b35db93
Reviewed-on: https://chromium-review.googlesource.com/1062933
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559328}
[modify] https://crrev.com/63c450575899b85d59064c0c83c86fb0833c28b8/DEPS

Project Member

Comment 11 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c1cb561a10ef426987990ce69230c5799d01a44

commit 9c1cb561a10ef426987990ce69230c5799d01a44
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu May 17 00:38:20 2018

Roll src/third_party/catapult/ a7e134aa0..07bcf9fc1 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/a7e134aa0dbf..07bcf9fc1678

$ git log a7e134aa0..07bcf9fc1 --date=short --no-merges --format='%ad %ae %s'
2018-05-16 szager Add linux support for interval profiling
2018-05-16 benjhayden Add iron-icons to third_party/polymer2.
2018-05-16 simonhatch Histogram - Cache info types

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I506c9407ed2cebcdce0ff04dacf5e1e68a849206
Reviewed-on: https://chromium-review.googlesource.com/1062936
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559364}
[modify] https://crrev.com/9c1cb561a10ef426987990ce69230c5799d01a44/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc3c976b63917ea800607ea0c8405fcdf2986036

commit bc3c976b63917ea800607ea0c8405fcdf2986036
Author: Stefan Zager <szager@chromium.org>
Date: Mon Jun 04 22:03:45 2018

Run page activity during RunPageInteractions phase for blink_perf tests

Previously, the main activity of tests would run immediately once the
page loaded. With this change, the main activity will instead run during
the RunPageInteractions phase. That will make it possible to profile the
page activity by running:

src/tools/perf/run_benchmark run blink_perf \
    --interval-profiling-period=interactions \
    --interval-profiling-target=renderer:main

BUG=chromium:839645

Change-Id: I82c9cbabe01a7219cddc62c571787cd31892f930
Reviewed-on: https://chromium-review.googlesource.com/1079198
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564256}
[modify] https://crrev.com/bc3c976b63917ea800607ea0c8405fcdf2986036/third_party/blink/perf_tests/resources/runner.js
[modify] https://crrev.com/bc3c976b63917ea800607ea0c8405fcdf2986036/tools/perf/benchmarks/blink_perf.js
[modify] https://crrev.com/bc3c976b63917ea800607ea0c8405fcdf2986036/tools/perf/benchmarks/blink_perf.py
[modify] https://crrev.com/bc3c976b63917ea800607ea0c8405fcdf2986036/tools/perf/benchmarks/blink_perf_unittest.py

Comment 13 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 14 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment