[JZO54K] 'Share' and 'Open in chrome' options for PWA's persistent notification not shown |
|||||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 67.0.3396.29 Android Build Number (from "Android Settings > About Phone/Tablet"): JZO54K (4.1.2) Device: Samsung Galaxy S3 (GT-I9300) and S3 (SCH-I535 Verizon) Steps to reproduce: 1. Launch Chrome 2. Navigate to a PWA enabled URL (Ex. airhorner.com or Twitter.com) 3. Either from the Add to homescreen banner or from Chrome menu add/install PWA for that site 4. Go to homescreen and launch the installed PWA 5. Pull down the Android notifications drawer 6. Expand the persistent PWA notification if its collapsed Observed behavior: 6. On this device there is no way to expand the notification.'Share' and 'Open in chrome' options for PWA's persistent notification not shown. NOTE: On Samsung S3 SGH-I747/ 4.3 (JSS15J) and Samsung S3 (GT-I9305) / 4.4, 'Share and 'Open in Chrome' options are shown. Frequency: 100% on JZO54K Additional comments:
,
May 7 2018
+Piotr - do you remember if this is expected on Android 4.1?
,
May 8 2018
I am confident I tested this on Jellybean and it was fine. I cannot finds the screenshots though now. According to https://developer.android.com/guide/topics/ui/notifiers/notifications 4.1 does support expandable notifications and notification actions. The issue here might be something with the Touchviz layer.
,
May 8 2018
Thanks Piotr! I don't think this should block launch as it is relatively minor. It also doesn't break anything. Let's try and fix for 68 though.
,
May 8 2018
Yaron - Any idea who would own this kind of stuff now?
,
May 9 2018
No idea. +peter/awdf in case they might know off-hand about system limitations there?
,
May 10 2018
(why is this private?) Android 4.1 was the first release that supported expandable notifications, so it wouldn't surprise me if not including buttons were an Android and/or Samsung TouchViz issue.
,
May 10 2018
(No reason to be private) I'm thinking we should just close this bug; I can't see us finding time to fix it and it doesn't seem important. Does anyone disagree?
,
May 10 2018
Agreed. We're likely going to drop JB support soon anyway
,
May 10 2018
+1 from me too - thanks :)
,
May 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/629360d2d2b5a84ebc49c612ee2804e05a0a79ad commit 629360d2d2b5a84ebc49c612ee2804e05a0a79ad Author: Hongchan Choi <hongchan@chromium.org> Date: Mon May 21 17:30:12 2018 Check WorkletPendingTasks when BaseAudioContext is going away This is a speculative fix for the bug associated. The following is the scenario of potential NULL-deference: 1. BaseAudioContext.audioWorklet.addModule('some.url'); 2. BaseAudioContext is destroyed. 3. The callback originated from the module loading arrives, but the associated context is already gone. 4. Crash with NULL deference, because the callback touches the destination node of the AudioContext. This CL fixes the issue by keeping track of WorkletPendingTasks until module loading tasks are resolved. Bug: 839642 Change-Id: I154bb8c56f0fa95d6708c642047c7b05acf83eb2 Reviewed-on: https://chromium-review.googlesource.com/1062795 Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560290} [modify] https://crrev.com/629360d2d2b5a84ebc49c612ee2804e05a0a79ad/third_party/blink/renderer/core/workers/worklet.cc [modify] https://crrev.com/629360d2d2b5a84ebc49c612ee2804e05a0a79ad/third_party/blink/renderer/core/workers/worklet.h [modify] https://crrev.com/629360d2d2b5a84ebc49c612ee2804e05a0a79ad/third_party/blink/renderer/core/workers/worklet_pending_tasks.cc [modify] https://crrev.com/629360d2d2b5a84ebc49c612ee2804e05a0a79ad/third_party/blink/renderer/core/workers/worklet_pending_tasks.h [modify] https://crrev.com/629360d2d2b5a84ebc49c612ee2804e05a0a79ad/third_party/blink/renderer/modules/webaudio/base_audio_context.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by aska...@chromium.org
, May 3 2018