Local Screens - Cast icon stays in active session state after session terminated |
||
Issue descriptionChrome Version: 68.0.3409.2 OS: Win 8, Mac MR: 6818.430.0.0 Doesn't repro with 67.0.3396.30 What steps will reproduce the problem? (1) Connect second monitor to machine (2) Go to https://googlechromelabs.github.io/presentation-api-samples/photowall/ (3) Select cast icon on page (4) Select receiver to begin Cast session. <-- note that the Cast icon on the page is now filled white indicating an active session. (5) Click on the same Cast icon on the page to end the current session. What is the expected result? The Cast session ends and the Cast icon on the page changes state from filled white to just an outline. What happens instead? The Cast session ends but the icon on the page remains in the filled white state.
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0694de545489a1b6e95b2bb4c0f2034446421de4 commit 0694de545489a1b6e95b2bb4c0f2034446421de4 Author: btolsch <btolsch@chromium.org> Date: Fri May 11 21:00:58 2018 Add termination event for local screen receivers Although most presentation connection state change and communication is handled directly between the two renderers involved, termination (and sometimes closing) is handled by the provider updating Media Router directly. In the case of local screens, the presentation ending always means it's terminating, so we should send that notification to Media Router. Bug: 839623 Change-Id: I11145bfd1bf165e8816c0b7431c909d59f78d2af Reviewed-on: https://chromium-review.googlesource.com/1054258 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#558014} [modify] https://crrev.com/0694de545489a1b6e95b2bb4c0f2034446421de4/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.cc [modify] https://crrev.com/0694de545489a1b6e95b2bb4c0f2034446421de4/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider_unittest.cc
,
May 11 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by mfo...@chromium.org
, May 7 2018Owner: btolsch@chromium.org
Status: Assigned (was: Untriaged)