New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 839620 link

Starred by 2 users
Status: Fixed
Owner:
lijeffrey@chromium.org
Closed: Oct 17
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Deprecate obsolete fields from DataPoint

Project Member Reported by lijeffrey@chromium.org, May 3 2018 
blame_list
previous_build_git_hash
previous_build_commit_position

These fields originally were meant to display build-level information in the analysis result, but now that things are commit position based, they can be computed at runtime and don't need to be stored
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/44772651fc27c1e33bba88741f461b62a491ac5e

commit 44772651fc27c1e33bba88741f461b62a491ac5e
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Oct 08 18:09:39 2018

[Findit] Flake Analyzer - Cleaning up dead code in MasterFlakeAnalysis

No functional changes - all code removed has been dead since migrating
to the new pipelines.

Bug:  839620 , 798231
Change-Id: I71328173880922b6281aa1c13cfdcaf4f535d289
Reviewed-on: https://chromium-review.googlesource.com/c/1262921
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18148}
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/model/flake/analysis/test/master_flake_analysis_test.py
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/handlers/flake/test/check_flake_test.py
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/model/flake/analysis/flake_swarming_task.py
[modify] https://crrev.com/44772651fc27c1e33bba88741f461b62a491ac5e/appengine/findit/model/flake/analysis/master_flake_analysis.py

Comment 2 by lijeffrey@chromium.org, Oct 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment