New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839610 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

[Regression] The gradient mask in the user scroll list needs UI polish

Project Member Reported by wzang@chromium.org, May 3 2018

Issue description

Not urgent, since it's a pure UI improvement and only applies to >6 users.

There should be a gradient mask at the top and the bottom of the user scroll list. Currently the mask does exist in the views-based login, but: 1) its color should change together with wallpaper changes, 2) its height should be higher according to spec https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCEk7MHTx6J1uiGu0WFxf6l3wMSJbxAVNpw)
 
Expected.png
220 KB View Download
Actual.png
242 KB View Download

Comment 1 by wzang@chromium.org, May 4 2018

Cc: -jdufault@chromium.org wzang@chromium.org
Labels: -Pri-3 ReleaseBlock-Stable Pri-1
Owner: jdufault@chromium.org
Status: Assigned (was: Available)
Labels: -M-68 M-69
Owner: qnnguyen@chromium.org
Cc: jdufault@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0bf4841162789baf0de248a3997ec072e527ee6

commit d0bf4841162789baf0de248a3997ec072e527ee6
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Wed Jun 06 17:48:00 2018

Upgrade ScrollableUsersListView GradientParams on wallpaper change

Bug:  839610 
Change-Id: I4a4ee5e8c80a57a32f8368fe3716803c82148183
Reviewed-on: https://chromium-review.googlesource.com/1086068
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564957}
[modify] https://crrev.com/d0bf4841162789baf0de248a3997ec072e527ee6/ash/login/ui/scrollable_users_list_view.cc
[modify] https://crrev.com/d0bf4841162789baf0de248a3997ec072e527ee6/ash/login/ui/scrollable_users_list_view.h

Status: Fixed (was: Assigned)

Sign in to add a comment