New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 839604 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

[Regression] Views-based login needs special UI for device policy wallpaper

Project Member Reported by wzang@chromium.org, May 3 2018

Issue description

When the wallpaper is set from device policy, wallpaper controller will not blur it, so this requires the views-based login screen to have the same UI treatment with the web-ui login.
 
Screenshot from 2018-05-03 15-03-20.png
1.7 MB View Download
Screenshot from 2018-05-03 15-03-59.png
1.3 MB View Download

Comment 1 by wzang@chromium.org, May 4 2018

Cc: -jdufault@chromium.org wzang@chromium.org
Labels: ReleaseBlock-Stable
Owner: jdufault@chromium.org
Status: Assigned (was: Available)
Labels: -M-68 M-69
Labels: -M-69 M-70
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b0083d518b826c8b6bb0898a76455b097c7452

commit 51b0083d518b826c8b6bb0898a76455b097c7452
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Aug 06 21:34:27 2018

cros: Update views-login layout for small displays

All of the whitespace views will now shrink to width=0 in views-login,
which means that login/lock will function better on extremely small
displays.

Bug:  839604 
Change-Id: I86d67b718e339a7856f9a7c4d2527c8e1e742ee0
Reviewed-on: https://chromium-review.googlesource.com/1147510
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580995}
[modify] https://crrev.com/51b0083d518b826c8b6bb0898a76455b097c7452/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/51b0083d518b826c8b6bb0898a76455b097c7452/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/51b0083d518b826c8b6bb0898a76455b097c7452/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/51b0083d518b826c8b6bb0898a76455b097c7452/ash/login/ui/scrollable_users_list_view.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9eed774c39a21652350064616a026a31b75ce57

commit c9eed774c39a21652350064616a026a31b75ce57
Author: Jacob Dufault <jdufault@google.com>
Date: Tue Aug 07 22:50:11 2018

cros: Allow screen rotation when --ash-dev-shortcuts is passed on login

Bug:  839604 
Change-Id: I7a9048afb50151a6c3eab2a0a2ca09cd5f5ec2ae
Reviewed-on: https://chromium-review.googlesource.com/1166185
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581381}
[modify] https://crrev.com/c9eed774c39a21652350064616a026a31b75ce57/ash/login/ui/lock_contents_view.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe

commit dc9a33eef47122012d34dd4e1de5e5d47b5af0fe
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Aug 08 18:13:29 2018

cros: Draw backgrounds around views in login/lock when wallpaper is not blurred.

Device-policy wallpapers are not blurred. A blurred wallpaper is required for
readability of the UI elements. To increase readability when the wallpaper is
not blurred, draw dark rounded rectangles around the user views and the shelf.

Bug:  839604 
Change-Id: I560613402bc37feb5f7fd02dd29b86c3eb10cc5d
Reviewed-on: https://chromium-review.googlesource.com/1138861
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581630}
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/lock_screen.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/scrollable_users_list_view.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/login/ui/scrollable_users_list_view.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/public/cpp/login_constants.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/public/cpp/shelf_types.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/shelf/shelf_background_animator.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/shelf/shelf_background_animator.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/dc9a33eef47122012d34dd4e1de5e5d47b5af0fe/ash/wm/lock_state_controller.cc

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Had to reopen this because the public session pod should also have the black background when device policy wallpaper is applied. It's necessary since public session and device policy wallpaper may appear together when device is enrolled. (Sorry I missed this part in the code review.) 
views.jpg
2.4 MB View Download
web-ui.jpg
3.0 MB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 21

Status: Fixed (was: Assigned)

Sign in to add a comment